From: Sagi Grimberg <sagi@grimberg.me>
To: Lv Yunlong <lyl2019@mail.ustc.edu.cn>,
hch@lst.de, chaitanya.kulkarni@wdc.com,
Israel Rukshin <israelr@mellanox.com>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme/rdma: Fix a use after free in nvmet_rdma_write_data_done
Date: Mon, 15 Mar 2021 10:20:00 -0700 [thread overview]
Message-ID: <3ffd40a5-efe8-d3e6-9142-c3fbd3419f65@grimberg.me> (raw)
In-Reply-To: <20210311054413.8731-1-lyl2019@mail.ustc.edu.cn>
> In nvmet_rdma_write_data_done, rsp is recoverd by wc->wr_cqe
> and freed by nvmet_rdma_release_rsp(). But after that, pr_info()
> used the freed chunk's member object and could leak the freed
> chunk address with wc->wr_cqe by computing the offset.
>
> Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
> ---
> drivers/nvme/target/rdma.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
> index 06b6b742bb21..6c1f3ab7649c 100644
> --- a/drivers/nvme/target/rdma.c
> +++ b/drivers/nvme/target/rdma.c
> @@ -802,9 +802,8 @@ static void nvmet_rdma_write_data_done(struct ib_cq *cq, struct ib_wc *wc)
> nvmet_req_uninit(&rsp->req);
> nvmet_rdma_release_rsp(rsp);
> if (wc->status != IB_WC_WR_FLUSH_ERR) {
> - pr_info("RDMA WRITE for CQE 0x%p failed with status %s (%d).\n",
> - wc->wr_cqe, ib_wc_status_msg(wc->status),
> - wc->status);
> + pr_info("RDMA WRITE for CQE failed with status %s (%d).\n",
> + ib_wc_status_msg(wc->status), wc->status);
There is nothing wrong with this reference, wr_cqe is a valid reference
and I think Israel added this for some extra information that may be
useful to him.
Israel? you ok with this removed?
> nvmet_rdma_error_comp(queue);
> }
> return;
>
prev parent reply other threads:[~2021-03-15 17:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 5:44 [PATCH] nvme/rdma: Fix a use after free in nvmet_rdma_write_data_done Lv Yunlong
2021-03-11 10:51 ` Christoph Hellwig
2021-03-15 17:20 ` Sagi Grimberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ffd40a5-efe8-d3e6-9142-c3fbd3419f65@grimberg.me \
--to=sagi@grimberg.me \
--cc=chaitanya.kulkarni@wdc.com \
--cc=hch@lst.de \
--cc=israelr@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=lyl2019@mail.ustc.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).