From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay02.th.seeweb.it (relay02.th.seeweb.it [5.144.164.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1A9914F6C for ; Tue, 19 Dec 2023 09:26:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=somainline.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=somainline.org Received: from SoMainline.org (82-72-63-87.cable.dynamic.v4.ziggo.nl [82.72.63.87]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id 7089820058; Tue, 19 Dec 2023 10:17:18 +0100 (CET) Date: Tue, 19 Dec 2023 10:17:16 +0100 From: Marijn Suijten To: Johan Hovold Cc: Lee Jones , phone-devel@vger.kernel.org, Pavel Machek , Bjorn Andersson , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , linux-arm-msm@vger.kernel.org, linux-leds@vger.kernel.org, Rob Herring , Bhupesh Sharma , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Boyd , Satya Priya Subject: Re: [PATCH v4 2/2] leds: qcom-lpg: Add PM660L configuration and compatible Message-ID: <3lsapoxlqijes5m4nqcbhdfhhs4chq3mcq3jaty7v2zihsqnwu@nn67a4h6425k> References: <20220719211848.1653920-1-marijn.suijten@somainline.org> <20220719211848.1653920-2-marijn.suijten@somainline.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Johan and Lee, On 2023-12-19 09:22:43, Johan Hovold wrote: > Hi Marijn and Lee, > > On Tue, Jul 19, 2022 at 11:18:48PM +0200, Marijn Suijten wrote: > > Inherit PM660L PMIC LPG/triled block configuration from downstream > > drivers and DT sources, consisting of a triled block with automatic > > trickle charge control and source selection, three colored led channels > > belonging to the synchronized triled block and one loose PWM channel. > > > > Signed-off-by: Marijn Suijten > > Reviewed-by: Bjorn Andersson > > --- > > > > Changes since v3: > > - Rebased on -next; > > - (series) dropped DTS patches that have been applied through the > > Qualcomm DTS tree, leaving only leds changes (driver and > > accompanying dt-bindings). > > > diff --git a/drivers/leds/rgb/leds-qcom-lpg.c b/drivers/leds/rgb/leds-qcom-lpg.c > > index 02f51cc61837..102ab0c33887 100644 > > --- a/drivers/leds/rgb/leds-qcom-lpg.c > > +++ b/drivers/leds/rgb/leds-qcom-lpg.c > > @@ -1304,6 +1304,23 @@ static int lpg_remove(struct platform_device *pdev) > > return 0; > > } > > > > +static const struct lpg_data pm660l_lpg_data = { > > + .lut_base = 0xb000, > > + .lut_size = 49, > > + > > + .triled_base = 0xd000, > > + .triled_has_atc_ctl = true, > > + .triled_has_src_sel = true, > > + > > + .num_channels = 4, > > + .channels = (const struct lpg_channel_data[]) { > > + { .base = 0xb100, .triled_mask = BIT(5) }, > > + { .base = 0xb200, .triled_mask = BIT(6) }, > > + { .base = 0xb300, .triled_mask = BIT(7) }, > > + { .base = 0xb400 }, > > + }, > > +}; > > + > > static const struct lpg_data pm8916_pwm_data = { > > .num_channels = 1, > > .channels = (const struct lpg_channel_data[]) { > > @@ -1424,6 +1441,7 @@ static const struct lpg_data pm8350c_pwm_data = { > > }; > > > > static const struct of_device_id lpg_of_table[] = { > > + { .compatible = "qcom,pm660l-lpg", .data = &pm660l_lpg_data }, > > { .compatible = "qcom,pm8150b-lpg", .data = &pm8150b_lpg_data }, > > { .compatible = "qcom,pm8150l-lpg", .data = &pm8150l_lpg_data }, > > { .compatible = "qcom,pm8350c-pwm", .data = &pm8350c_pwm_data }, > > When reviewing the Qualcomm SPMI PMIC bindings I noticed that this patch > was never picked up by the LEDs maintainer, while the binding and dtsi > changes made it in: > > https://lore.kernel.org/r/20220719211848.1653920-2-marijn.suijten@somainline.org > > Looks like it may still apply cleanly, but otherwise, would you mind > rebasing and resending so that Lee can pick this one up? > > Johan Coincidentally I haven't touched this device/platform for months... until last weekend where I noticed the same. It does not apply cleanly and I had to solve some conflicts: https://github.com/SoMainline/linux/commit/8ec5d02eaffcec24fcab6a989ab117a5b72b96b6 I'll gladly resend this! Note that I have one more unmerged leds patch around, that hasn't been looked at either. Would it help to send this once again, perhaps with more reviewers/ testing (Johan, would you mind taking a look too)? https://lore.kernel.org/linux-leds/20220719213034.1664056-1-marijn.suijten@somainline.org/ Thanks! - Marijn