From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: david.vrabel@citrix.com, JGross@suse.com,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
roger.pau@citrix.com
Subject: Re: [Xen-devel] [PATCH 5/8] xen/pvh: Prevent PVH guests from using PIC, RTC and IOAPIC
Date: Fri, 14 Oct 2016 15:37:40 -0400 [thread overview]
Message-ID: <4006b86b-a259-1519-d9b2-6d59e04cad23@oracle.com> (raw)
In-Reply-To: <20161014191613.GB16777@localhost.localdomain>
On 10/14/2016 03:16 PM, Konrad Rzeszutek Wilk wrote:
> On Fri, Oct 14, 2016 at 02:05:15PM -0400, Boris Ostrovsky wrote:
>> Make sure they don't use these devices since they are not emulated
>> for unprivileged PVH guest.
> Which means they would just return 0 ? Or would it get worst since
> the in/out would go to the hypervisor which would kill the guest?
For PIC and IOAPIC (and I think RTC too) we will get a warning (with a
splat) that SCI cannot be initialized. But the guest will continue
running without problems.
-boris
>> Also don't initialize hypercall page for them in init_hvm_pv_info()
>> since this has already been done.
>>
>> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>> ---
>> arch/x86/xen/enlighten.c | 24 +++++++++++++++++-------
>> 1 file changed, 17 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
>> index d38d568..6c1a330 100644
>> --- a/arch/x86/xen/enlighten.c
>> +++ b/arch/x86/xen/enlighten.c
>> @@ -1803,10 +1803,21 @@ static void __init init_hvm_pv_info(void)
>> minor = eax & 0xffff;
>> printk(KERN_INFO "Xen version %d.%d.\n", major, minor);
>>
>> - cpuid(base + 2, &pages, &msr, &ecx, &edx);
>> + xen_domain_type = XEN_HVM_DOMAIN;
>>
>> - pfn = __pa(hypercall_page);
>> - wrmsr_safe(msr, (u32)pfn, (u32)(pfn >> 32));
>> + /* PVH set up hypercall page earlier in xen_prepare_pvh() */
> A period at the end?
>> + if (xen_pvh_domain()) {
>> + pv_info.name = "Xen PVH";
>> +#ifdef CONFIG_ACPI
>> + /* No PIC or IOAPIC */
> Here?
>> + acpi_irq_model = ACPI_IRQ_MODEL_PLATFORM;
>> +#endif
>> + } else {
>> + pv_info.name = "Xen HVM";
>> + cpuid(base + 2, &pages, &msr, &ecx, &edx);
> Could you use cpuid_ebx ?
>> + pfn = __pa(hypercall_page);
>> + wrmsr_safe(msr, (u32)pfn, (u32)(pfn >> 32));
>> + }
>>
>> xen_setup_features();
>>
>> @@ -1815,10 +1826,6 @@ static void __init init_hvm_pv_info(void)
>> this_cpu_write(xen_vcpu_id, ebx);
>> else
>> this_cpu_write(xen_vcpu_id, smp_processor_id());
>> -
>> - pv_info.name = "Xen HVM";
>> -
>> - xen_domain_type = XEN_HVM_DOMAIN;
>> }
>>
>> static int xen_cpu_up_prepare(unsigned int cpu)
>> @@ -1892,6 +1899,9 @@ static void __init xen_hvm_guest_init(void)
>>
>> init_hvm_pv_info();
>>
>> + if (xen_pvh_domain())
>> + x86_platform.legacy.rtc = 0;
>> +
>> xen_hvm_init_shared_info();
>>
>> xen_panic_handler_init();
>> --
>> 1.8.3.1
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xen.org
>> https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-10-14 19:37 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 18:05 [PATCH 0/8] PVH v2 support Boris Ostrovsky
2016-10-14 18:05 ` [PATCH 1/8] xen/x86: Remove PVH support Boris Ostrovsky
2016-10-14 18:31 ` [Xen-devel] " Konrad Rzeszutek Wilk
2016-10-18 13:46 ` Juergen Gross
2016-10-18 14:45 ` Boris Ostrovsky
2016-10-18 15:33 ` Juergen Gross
2016-10-18 15:42 ` Boris Ostrovsky
2016-10-14 18:05 ` [PATCH 2/8] x86/head: Refactor 32-bit pgtable setup Boris Ostrovsky
2016-10-14 18:31 ` hpa
2016-10-14 18:44 ` Boris Ostrovsky
2016-10-14 19:04 ` hpa
2016-10-14 19:18 ` Boris Ostrovsky
2016-10-31 12:33 ` Boris Ostrovsky
2016-12-01 15:33 ` Boris Ostrovsky
2016-12-02 9:45 ` Ingo Molnar
2016-12-02 14:04 ` Boris Ostrovsky
2016-12-02 16:08 ` Ingo Molnar
2016-12-02 17:52 ` hpa
2016-12-02 19:49 ` Boris Ostrovsky
2016-12-03 5:49 ` Ingo Molnar
2016-12-03 6:36 ` hpa
2016-10-14 18:05 ` [PATCH 3/8] xen/pvh: Import PVH-related Xen public interfaces Boris Ostrovsky
2016-10-14 18:34 ` [Xen-devel] " Konrad Rzeszutek Wilk
2016-10-21 10:58 ` Juergen Gross
2016-10-14 18:05 ` [PATCH 4/8] xen/pvh: Bootstrap PVH guest Boris Ostrovsky
2016-10-14 18:38 ` [Xen-devel] " Andrew Cooper
2016-10-14 18:55 ` Boris Ostrovsky
2016-10-14 19:12 ` Andrew Cooper
2016-10-14 19:14 ` Konrad Rzeszutek Wilk
2016-10-14 19:34 ` Boris Ostrovsky
2016-10-14 18:05 ` [PATCH 5/8] xen/pvh: Prevent PVH guests from using PIC, RTC and IOAPIC Boris Ostrovsky
2016-10-14 19:16 ` [Xen-devel] " Konrad Rzeszutek Wilk
2016-10-14 19:37 ` Boris Ostrovsky [this message]
2016-10-26 10:42 ` Roger Pau Monné
2016-10-26 14:50 ` Boris Ostrovsky
2016-10-26 15:18 ` Roger Pau Monné
2016-10-26 16:06 ` Boris Ostrovsky
2016-10-14 18:05 ` [PATCH 6/8] xen/pvh: Initialize grant table for PVH guests Boris Ostrovsky
2016-10-14 19:19 ` [Xen-devel] " Konrad Rzeszutek Wilk
2016-10-14 19:43 ` Boris Ostrovsky
2016-10-14 19:51 ` Konrad Rzeszutek Wilk
2016-10-14 20:02 ` Boris Ostrovsky
2016-10-18 16:08 ` Juergen Gross
2016-10-18 16:40 ` Boris Ostrovsky
2016-10-19 5:47 ` Juergen Gross
2016-10-14 18:05 ` [PATCH 7/8] xen/pvh: PVH guests always have PV devices Boris Ostrovsky
2016-10-14 19:17 ` [Xen-devel] " Konrad Rzeszutek Wilk
2016-10-18 15:54 ` Juergen Gross
2016-10-14 18:05 ` [PATCH 8/8] xen/pvh: Enable CPU hotplug Boris Ostrovsky
2016-10-14 18:41 ` [Xen-devel] " Andrew Cooper
2016-10-14 19:01 ` Boris Ostrovsky
2016-10-27 14:25 ` Boris Ostrovsky
2016-10-27 15:00 ` Andrew Cooper
2016-10-27 16:23 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4006b86b-a259-1519-d9b2-6d59e04cad23@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=JGross@suse.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).