From: Markus Elfring <Markus.Elfring@web.de>
To: Denis Efremov <efremov@linux.com>,
Coccinelle <cocci@systeme.lip6.fr>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Julia Lawall <julia.lawall@inria.fr>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Nicolas Palix <nicolas.palix@imag.fr>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
"Gustavo A. R. Silva" <garsilva@embeddedor.com>,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH v4] coccinelle: misc: add array_size_dup script to detect missed overflow checks
Date: Tue, 23 Jun 2020 08:12:39 +0200 [thread overview]
Message-ID: <4014118b-90a6-68c5-048f-32485fa3e852@web.de> (raw)
> Changes in v2:
…
> - assignment operator used
I prefer the distinction for the application of corresponding metavariables.
> Changes in v3:
…
> - \(&E1\|&E2\) changed to &\(E1\|E2\)
Would it be more helpful to mention the movement of the ampersand
before SmPL disjunctions?
…
>+/// Three types of patterns for these functions:
Will another adjustment be needed according to your information “duplicates warning removed”?
…
> +virtual context
> +virtual report
> +virtual org
Can the following SmPL code variant ever become more attractive?
+virtual context, report, org
…
> +expression subE1 <= as.E1;
> +expression subE2 <= as.E2;
> +expression as.E1, as.E2, E3;
How do you think about the following SmPL code variant?
+expression subE1 <= as.E1,
+ subE2 <= as.E2,
+ as.E1, as.E2, E3;
…
> +msg = "WARNING: array_size is used later (line %s) to compute the same size" % (p2[0].line)
> +coccilib.report.print_report(p1[0], msg)
Please omit the extra Python variable “msg” for the passing of such simple message objects.
What does hinder you to take the proposed script variants better into account?
Regards,
Markus
next reply other threads:[~2020-06-23 6:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 6:12 Markus Elfring [this message]
2020-06-23 7:02 ` [PATCH v4] coccinelle: misc: add array_size_dup script to detect missed overflow checks Julia Lawall
2020-06-23 9:42 ` [v4] " Markus Elfring
-- strict thread matches above, loose matches on Subject: below --
2020-06-15 10:20 [PATCH] coccinelle: misc: add array_size_dup script to detect missed overlow checks Denis Efremov
2020-06-22 22:10 ` [PATCH v4] coccinelle: misc: add array_size_dup script to detect missed overflow checks Denis Efremov
2020-06-24 19:42 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4014118b-90a6-68c5-048f-32485fa3e852@web.de \
--to=markus.elfring@web.de \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=efremov@linux.com \
--cc=garsilva@embeddedor.com \
--cc=julia.lawall@inria.fr \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).