From: Julius Niedworok <julius.n@gmx.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Oliver Hartkopp <socketcan@hartkopp.net>,
linux-wireless@vger.kernel.org, ga58taw@mytum.de,
David Hildenbrand <david@redhat.com>,
nc@net.in.tum.de, "David S. Miller" <davem@davemloft.net>,
Edward Cree <ecree@solarflare.com>,
Jiri Pirko <jiri@mellanox.com>,
Ido Schimmel <idosch@mellanox.com>,
Petr Machata <petrm@mellanox.com>,
Kirill Tkhai <ktkhai@virtuozzo.com>,
Alexander Duyck <alexander.h.duyck@intel.com>,
Amritha Nambiar <amritha.nambiar@intel.com>,
Li RongQing <lirongqing@baidu.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Julius Niedworok <julius.n@gmx.net>
Subject: Re: [PATCH RFC] mac80211: Use IFF_ECHO to force delivery of tx_status frames
Date: Sat, 2 Mar 2019 16:16:31 +0100 [thread overview]
Message-ID: <40145B82-DCFB-40EC-88BD-BA71DA0CB86F@gmx.net> (raw)
In-Reply-To: <e20962001ee10a0f90f8e2f1f8baafcf3b70e9dd.camel@sipsolutions.net>
> On 01.03.2019 09:32, Johannes Berg wrote:
>
> Thus, I don't think this was ever intended for any cross-interface
> behaviour, even if it may be on the same physical NIC.
Now we got your point. We are sorry for the confusion - it seems we
understood that wrong.
> Not all drivers can and do this, I believe. Some things don't work very
> well if they don't do it, but I _think_ you've just been lucky and used
> hardware that does in fact support it.
If the drivers do not adhere to the API, this is a problem of the drivers,
right? Because, how can we rely on *any* functionality of the drivers when
we assume that they do not adhere to the documented interfaces?
> Also note that for some hardware that does support this, there's
> sometimes significant overhead - not just the performance overhead of
> actually reporting the frames, but sometimes also overhead in how the
> hardware is programmed and used, and how TX status is extracted.
The default of this option will be disabled. If it is turned on manually
for debugging, the performance impact is probably acceptable.
> I suppose it could be in mac80211 (perhaps debugfs?) too. I just really
> don’t think IFF_ECHO is the right approach.
We see your point. So you think we should use debugfs to enable/disable
our functionality? If so, we are happy to see that we find a way to force
REQ_TX_STATUS to one from there.
Thank you,
Julius and Charlie
next prev parent reply other threads:[~2019-03-02 15:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 9:40 [PATCH RFC] mac80211: Use IFF_ECHO to force delivery of tx_status frames Julius Niedworok
2019-02-26 11:04 ` Oliver Hartkopp
2019-02-26 13:13 ` Julius Niedworok
2019-02-26 13:33 ` Johannes Berg
2019-02-28 9:05 ` Julius Niedworok
2019-03-01 8:32 ` Johannes Berg
2019-03-02 15:16 ` Julius Niedworok [this message]
2019-03-06 20:02 ` [PATCH RFC v2] mac80211: debugfs option to force TX status frames Julius Niedworok
2019-03-07 15:42 ` Kalle Valo
2019-03-07 19:30 ` ga58taw
2019-03-11 14:03 ` Kalle Valo
2019-03-11 14:52 ` Jeremy Sowden
2019-03-19 15:07 ` Julius Niedworok
2019-03-20 12:13 ` Jeremy Sowden
2019-03-28 20:01 ` [PATCH v3] " Julius Niedworok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40145B82-DCFB-40EC-88BD-BA71DA0CB86F@gmx.net \
--to=julius.n@gmx.net \
--cc=alexander.h.duyck@intel.com \
--cc=amritha.nambiar@intel.com \
--cc=davem@davemloft.net \
--cc=david@redhat.com \
--cc=ecree@solarflare.com \
--cc=ga58taw@mytum.de \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=johannes@sipsolutions.net \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=nc@net.in.tum.de \
--cc=netdev@vger.kernel.org \
--cc=petrm@mellanox.com \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).