From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753635Ab2KTA5D (ORCPT ); Mon, 19 Nov 2012 19:57:03 -0500 Received: from ogre.sisk.pl ([193.178.161.156]:54110 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753546Ab2KTA47 (ORCPT ); Mon, 19 Nov 2012 19:56:59 -0500 From: "Rafael J. Wysocki" To: Mika Westerberg Cc: Bjorn Helgaas , Jean Delvare , ben-linux@fluff.org, w.sang@pengutronix.de, linux-kernel@vger.kernel.org, lenb@kernel.org, rafael.j.wysocki@intel.com, broonie@opensource.wolfsonmicro.com, grant.likely@secretlab.ca, linus.walleij@linaro.org, mathias.nyman@linux.intel.com, linux-acpi@vger.kernel.org, Greg Kroah-Hartman Subject: [Update][PATCH 0/3] ACPI: Simplify "glueing" to physical nodes Date: Tue, 20 Nov 2012 01:55:46 +0100 Message-ID: <4036218.zBRlg5OZsZ@vostro.rjw.lan> User-Agent: KMail/4.9.3 (Linux/3.7.0-rc6; KDE/4.9.3; x86_64; ; ) In-Reply-To: <1758879.PKgPhTGcB7@vostro.rjw.lan> References: <1352977397-2280-1-git-send-email-mika.westerberg@linux.intel.com> <20121118155539.GE17774@intel.com> <1758879.PKgPhTGcB7@vostro.rjw.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, November 18, 2012 10:10:33 PM Rafael J. Wysocki wrote: > On Sunday, November 18, 2012 05:55:39 PM Mika Westerberg wrote: > > On Sat, Nov 17, 2012 at 12:24:45PM +0100, Rafael J. Wysocki wrote: > > > Well, maybe there is one. Perhaps we can make acpi_platform_notify() > > > call acpi_bind_one() upfront and only if that fails, do the whole > > > type->find_device() dance? Of course, acpi_bind_one() would need to > > > be modified slightly too, like in the patch below. > > > > > > If we did that, acpi_i2c_add_device() would only need to assign acpi_handle > > > as appropriate before calling i2c_new_device() (and analogously for SPI). > > > > > > What do you think? > > > > This is certainly better than the thing we use currently. It makes adding > > I2C and SPI support much shorter and simpler. If others don't object I > > would suggest that we switch to use this method. > > OK, thanks. > > The first of the following two patches is a slightly modified version of the > one that you commented. Patch [2/2] implements the idea for platform devices > and since it modifies struct platform_device_info, I'm adding a CC to Greg. > > The patches are on top of current linux-pm.git/linux-next. > > It looks like we may be able to use this approach for PCI too, in which case > the whole .find_device() stuff won't be necessary any more. Following is the series with the Greg's feedback taken into account. Patch [1/3] is the same as before with the bug found by Mika fixed, [2/3] is an additional patch adding struct acpi_dev_node to compile out unused stuff if CONFIG_ACPI is not set and [3/3] is the previous [2/2] rebased on top of it. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.