From: Markus Elfring <Markus.Elfring@web.de>
To: Navid Emamdoost <navid.emamdoost@gmail.com>,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Navid Emamdoost" <emamd001@umn.edu>,
"Hans Ulli Kroll" <ulli.kroll@googlemail.com>
Subject: Re: [PATCH] net: gemini: Fix memory leak in gmac_setup_txqs
Date: Sun, 15 Dec 2019 15:27:31 +0100 [thread overview]
Message-ID: <403e8b6d-57df-e8d1-316c-150f833de842@web.de> (raw)
In-Reply-To: <20191215011045.15453-1-navid.emamdoost@gmail.com>
> +++ b/drivers/net/ethernet/cortina/gemini.c
> @@ -576,6 +576,8 @@ static int gmac_setup_txqs(struct net_device *netdev)
>
> if (port->txq_dma_base & ~DMA_Q_BASE_MASK) {
> dev_warn(geth->dev, "TX queue base is not aligned\n");
> + dma_free_coherent(geth->dev, len * sizeof(*desc_ring),
> + desc_ring, port->txq_dma_base);
> kfree(skb_tab);
> return -ENOMEM;
> }
The added function call seems to be fine.
Would you like to avoid a bit of duplicate code for the exception handling?
Regards,
Markus
next prev parent reply other threads:[~2019-12-15 14:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-15 1:10 [PATCH] net: gemini: Fix memory leak in gmac_setup_txqs Navid Emamdoost
2019-12-15 14:27 ` Markus Elfring [this message]
2019-12-16 10:20 ` Linus Walleij
2019-12-17 0:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=403e8b6d-57df-e8d1-316c-150f833de842@web.de \
--to=markus.elfring@web.de \
--cc=davem@davemloft.net \
--cc=emamd001@umn.edu \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=navid.emamdoost@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ulli.kroll@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).