From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93517C0650F for ; Mon, 5 Aug 2019 11:49:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 713A520856 for ; Mon, 5 Aug 2019 11:49:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728593AbfHELtT convert rfc822-to-8bit (ORCPT ); Mon, 5 Aug 2019 07:49:19 -0400 Received: from eu-smtp-delivery-151.mimecast.com ([207.82.80.151]:27849 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727259AbfHELtR (ORCPT ); Mon, 5 Aug 2019 07:49:17 -0400 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-160-NQwNEFbuMJmxd-wtY4RQAg-1; Mon, 05 Aug 2019 12:49:13 +0100 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b::d117) by AcuMS.aculab.com (fd9f:af1c:a25b::d117) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Mon, 5 Aug 2019 12:49:12 +0100 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Mon, 5 Aug 2019 12:49:12 +0100 From: David Laight To: 'Joe Perches' , Neil Horman CC: Vlad Yasevich , Marcelo Ricardo Leitner , "David S. Miller" , "linux-sctp@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] net: sctp: Rename fallthrough label to unhandled Thread-Topic: [PATCH] net: sctp: Rename fallthrough label to unhandled Thread-Index: AQHVSJCHKC4hvRwdKE+hlvEjJaGqZabsda0g Date: Mon, 5 Aug 2019 11:49:12 +0000 Message-ID: <40493bf4256c4b62b211e2e60fa7f8b8@AcuMS.aculab.com> References: <20190731111932.GA9823@hmswarspite.think-freely.org> <20190731121646.GD9823@hmswarspite.think-freely.org> <20190731205804.GE9823@hmswarspite.think-freely.org> <20190801105051.GA11487@hmswarspite.think-freely.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-MC-Unique: NQwNEFbuMJmxd-wtY4RQAg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joe Perches > Sent: 01 August 2019 18:43 > On Thu, 2019-08-01 at 06:50 -0400, Neil Horman wrote: > > On Wed, Jul 31, 2019 at 03:23:46PM -0700, Joe Perches wrote: > [] > > You can say that if you want, but you made the point that your think the macro > > as you have written is more readable. You example illustrates though that /* > > fallthrough */ is a pretty common comment, and not prefixing it makes it look > > like someone didn't add a comment that they meant to. The __ prefix is standard > > practice for defining macros to attributes (212 instances of it by my count). I > > don't mind rewriting the goto labels at all, but I think consistency is > > valuable. > > Hey Neil. > > Perhaps you want to make this argument on the RFC patch thread > that introduces the fallthrough pseudo-keyword. > > https://lore.kernel.org/patchwork/patch/1108577/ ISTM that the only place where you need something other than the traditional comment is inside a #define where (almost certainly) the comments have to get stripped too early. Adding a 'fallthough' as unknown C keyword sucks... David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)