From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753872AbdEHIMw (ORCPT <rfc822;w@1wt.eu>);
        Mon, 8 May 2017 04:12:52 -0400
Received: from mail-pf0-f195.google.com ([209.85.192.195]:34612 "EHLO
        mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753833AbdEHIMt (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 8 May 2017 04:12:49 -0400
Subject: Re: [PATCH] perf probe: Fix examples section of documentation
To: SeongJae Park <sj38.park@gmail.com>
References: <20170507103642.30560-1-sj38.park@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>,
        Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
        linux-kernel@vger.kernel.org, Masami Hiramatsu <mhiramat@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>
From: Taeung Song <treeze.taeung@gmail.com>
Message-ID: <404d6351-7a31-21aa-173e-3ef75a754de5@gmail.com>
Date: Mon, 8 May 2017 17:12:43 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170507103642.30560-1-sj38.park@gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi SeongJae,

Nice to see you :)

On 05/07/2017 07:36 PM, SeongJae Park wrote:
> An example in perf-probe documentation for pattern of function name
> based probe addition is not providing example command for the case.
> This commit fixes the example to give appropriate example command.
>
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
> ---
>  tools/perf/Documentation/perf-probe.txt | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/Documentation/perf-probe.txt b/tools/perf/Documentation/perf-probe.txt
> index e6c9902c6d82..165c2b1d4317 100644
> --- a/tools/perf/Documentation/perf-probe.txt
> +++ b/tools/perf/Documentation/perf-probe.txt
> @@ -240,9 +240,13 @@ Add a probe on schedule() function 12th line with recording cpu local variable:
>   or
>   ./perf probe --add='schedule:12 cpu'
>
> - this will add one or more probes which has the name start with "schedule".
> +Add one or more probes which has the name start with "schedule".
>
> - Add probes on lines in schedule() function which calls update_rq_clock().
> + ./perf probe schedule*
> + or
> + ./perf probe --add='schedule*'
> +
> +Add probes on lines in schedule() function which calls update_rq_clock().
>
>   ./perf probe 'schedule;update_rq_clock*'
>   or
>

LGTM
As a nitpick, it would be better to add "Fixes:" such as:

   Fixes: ee391de876ae ("perf probe: Update perf probe document")

And I added Cc: Masami Hiramatsu related to the line you modified
and Cc: other developers who can review this.

Thanks,
Taeung