From: Marc Zyngier <marc.zyngier@arm.com>
To: Florian Fainelli <f.fainelli@gmail.com>, linux-kernel@vger.kernel.org
Cc: jaedon.shin@gmail.com, Kevin Cernekee <cernekee@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Brian Norris <computersforpeace@gmail.com>,
Gregory Fong <gregory.0xf0@gmail.com>,
"maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>,
"open list:BROADCOM BMIPS MIPS ARCHITECTURE"
<linux-mips@vger.kernel.org>,
"moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] irqchip/bcm: Restore registration print with %pOF
Date: Mon, 29 Apr 2019 09:29:00 +0100 [thread overview]
Message-ID: <4050a32c-c0dd-32d5-04f0-243e70e929af@arm.com> (raw)
In-Reply-To: <bebfeb44-cfc0-78e7-77d9-431441c80edc@gmail.com>
On 26/04/2019 18:33, Florian Fainelli wrote:
> On 3/20/19 12:39 PM, Florian Fainelli wrote:
>> It is useful to print which interrupt controllers are registered in the
>> system and which parent IRQ they use, especially given that L2 interrupt
>> controllers do not call request_irq() on their parent interrupt and do
>> not appear under /proc/interrupts for that reason.
>>
>> We used to print the base register address virtual address which had
>> little value, use %pOF to print the path to the Device Tree node which
>> maps to the physical address more easily and is what people need to
>> troubleshoot systems.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>
> Marc, are you okay with taking that patch?
I find it slightly pointless, but if you find it useful in the field,
fair enough. I've queued it for 5.2.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
prev parent reply other threads:[~2019-04-29 8:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 19:39 [PATCH] irqchip/bcm: Restore registration print with %pOF Florian Fainelli
2019-04-26 17:33 ` Florian Fainelli
2019-04-29 8:29 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4050a32c-c0dd-32d5-04f0-243e70e929af@arm.com \
--to=marc.zyngier@arm.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=cernekee@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=gregory.0xf0@gmail.com \
--cc=jaedon.shin@gmail.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).