From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753669AbcICMKf (ORCPT ); Sat, 3 Sep 2016 08:10:35 -0400 Received: from mout.web.de ([212.227.15.14]:54733 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752839AbcICMKc (ORCPT ); Sat, 3 Sep 2016 08:10:32 -0400 Subject: [PATCH 01/17] s390/debug: Use kmalloc_array() in debug_areas_alloc() To: linux-s390@vger.kernel.org, David Hildenbrand , Heiko Carstens , Joe Perches , Martin Schwidefsky References: <566ABCD9.1060404@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Message-ID: <405a67ff-0f3b-a172-b8f1-2867cdd5ce07@users.sourceforge.net> Date: Sat, 3 Sep 2016 14:10:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:LPMrdN9Xyc9Kve+PnF4sFE1x2KuReHnCo2xpd8UFL2CezR+A+s5 jcDi/W4P9P5btBErJ9ZGgyZw1jtMhM+T/lQTxJxVvpTAoaeQT83YglUBwZOq7jBfqJ6lh8M dmMA2l1vXQ81Hlmb3BEJjb9+mGAd2NBFUxfGp9JOFFihI/ihp8ubRYHl/IscX9hnPHx+Udx OxPwOlALCFxGTftgmx4dA== X-UI-Out-Filterresults: notjunk:1;V01:K0:Z5W1JHJYocI=:BUBjD0+hytm0rR89x35TtI 4kI6K7tAcYsrKrWYfLoJKJ+64wMpnWyZrd3Yt8AaT7j7NdKlC9XFvlRsihqXyHZjcmzjpwB85 OaWzvjD5xq7YqJyO8Mp6fQ8bhDAYo2iopA0ZmeA68KRH6UAxuvCFDsKnAZWE4NIKzuLGqrptZ AutX7lM6Xmiop8hBEIudLk8kKQbOSZYHhCTr/dzYepOCq4mPPsIP0nS3Z+KG518J4XjcnlpyB YlAO4o9L5rb4GiARznF4XFGOf9WgCuQtPWqB4qyh5SDG/5lNOmB2kJtx9F9FZl/eCAtOXF70h boR00vt5cqWyH2c1HDs8RMMncqwS86u3zmuplHLlmGnx4DkDL2RfqKQz2OYA8mcl3O6sDQiJ3 odcnn/aierqZieSk0o0HYMWbmm7EmUYMdUdrjr6WBQtHM4Qh5+v6DNcd43L3hrwAx28Oxq4G1 BJ9aiGGyvMRuQuBqE9RxoUM7gdeh1QWHESFkq9aSR+byv5e9TXU8MAkeJjrYsXRJFcY5fLHIn n77iDH20YNOYMGhZgO8lWNizP83GHbhKIYqGIjaqnrRXI32gJlM+QpFvph5+8NXmLYT5faRY7 unla5U6UULFzxk6N0JZPf4ZewLd5bGz0AyQykGMLmX472ax0qI2V6D0zqztOqxGciVR7p6S8f Utou7qxXOgq6FZmowfMBsCYfIkD9rRWsXIueN/UtP3sdKls3h2PfhOII7wDtIj8+897onJC+/ UvX++7skf3jAgcdz34KexMrZxrMzrLmxzJRTLWtoIUksApyzcyYO8U3LOBuK2nzbd8RhRmmz7 RqODJSz Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 1 Sep 2016 14:41:01 +0200 * Multiplications for the size determination of memory allocations indicated that array data structures should be processed. Thus use the corresponding function "kmalloc_array". * Replace the specification of data types by pointer dereferences to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- arch/s390/kernel/debug.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/arch/s390/kernel/debug.c b/arch/s390/kernel/debug.c index aa12de7..8e2be30 100644 --- a/arch/s390/kernel/debug.c +++ b/arch/s390/kernel/debug.c @@ -196,14 +196,13 @@ debug_areas_alloc(int pages_per_area, int nr_areas) debug_entry_t*** areas; int i,j; - areas = kmalloc(nr_areas * - sizeof(debug_entry_t**), - GFP_KERNEL); + areas = kmalloc_array(nr_areas, sizeof(*areas), GFP_KERNEL); if (!areas) goto fail_malloc_areas; for (i = 0; i < nr_areas; i++) { - areas[i] = kmalloc(pages_per_area * - sizeof(debug_entry_t*),GFP_KERNEL); + areas[i] = kmalloc_array(pages_per_area, + sizeof(*areas[i]), + GFP_KERNEL); if (!areas[i]) { goto fail_malloc_areas2; } -- 2.9.3