linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Martin Kurbanov <mmkurbanov@salutedevices.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Christian Brauner <brauner@kernel.org>,
	Dave Chinner <dchinner@redhat.com>, Yu Zhe <yuzhe@nfschina.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-mtd <linux-mtd@lists.infradead.org>,
	kernel <kernel@sberdevices.ru>
Subject: Re: [PATCH v1 2/2] jffs2: make cleanmarker support option
Date: Mon, 23 Oct 2023 19:44:44 +0200 (CEST)	[thread overview]
Message-ID: <406915015.32119.1698083084288.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <3951ac21-a0a4-47b5-be94-edb0140c69a5@salutedevices.com>

----- Ursprüngliche Mail -----
> Von: "Martin Kurbanov" <mmkurbanov@salutedevices.com>
> If you disable the cleanmarker, the found clean block (filled with 0xff)
> will be erased again (see fs/jffs2/scan.c#L162).
> In my opinion, it is better to perform the block erasure again than to
> not work with such a nand flash at all.

Doesn't this case many re-erases at each mount time?

BTW: I tried your patch in nandsim, jffs2 was unhappy.
[   56.147361] jffs2: notice: (440) jffs2_build_xattr_subsystem: complete building xattr subsystem, 0 of xdatum (0 unchecked, 0 orphan) and 0 of xref (0 dead, 0 orphan) found.
[   56.200438] nand: nand_do_write_ops: attempt to write non page aligned data
[   56.201090] jffs2: Write clean marker to block at 0x001f8000 failed: -22

Do you have an idea?

Thanks,
//richard

  reply	other threads:[~2023-10-23 17:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-19  7:38 [PATCH v1 0/2] jffs2: make cleanmarker support option Martin Kurbanov
2023-10-19  7:38 ` [PATCH v1 1/2] jffs2: introduce jffs2_nandflash() Martin Kurbanov
2023-10-19  7:38 ` [PATCH v1 2/2] jffs2: make cleanmarker support option Martin Kurbanov
2023-10-19  8:12   ` Richard Weinberger
2023-10-23 14:54     ` Martin Kurbanov
2023-10-23 17:44       ` Richard Weinberger [this message]
2023-10-24 13:29         ` Martin Kurbanov
2023-10-23 17:55       ` David Woodhouse
2023-10-25 14:53         ` Martin Kurbanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=406915015.32119.1698083084288.JavaMail.zimbra@nod.at \
    --to=richard@nod.at \
    --cc=brauner@kernel.org \
    --cc=dchinner@redhat.com \
    --cc=dwmw2@infradead.org \
    --cc=kernel@sberdevices.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mmkurbanov@salutedevices.com \
    --cc=yuzhe@nfschina.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).