From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE70EC433F5 for ; Thu, 23 Sep 2021 12:06:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C695C61107 for ; Thu, 23 Sep 2021 12:06:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240770AbhIWMHq (ORCPT ); Thu, 23 Sep 2021 08:07:46 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:56604 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240769AbhIWMHP (ORCPT ); Thu, 23 Sep 2021 08:07:15 -0400 Received: from [192.168.0.20] (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 80BA745E; Thu, 23 Sep 2021 14:05:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1632398743; bh=wumMJjGSoh/Q5099IMcv3lMgAskRHGNIdxF7TvawJVU=; h=From:To:Cc:References:Subject:Date:In-Reply-To:From; b=axXBtEfQnE+VtwQ6zVq0PwkccBZSk1g+QVmEHAD15DNAnW7C2YbzYt9r8EzEPfaXE zCOJDLWFP16vfJgZzH4owXwH3AqH72ssmV/uTZMJ7px+l7x95m9K6GhYcwTBBsu31e 8hQ22QouC4yqNSp2tKmL0vX3XHwv7B8pgSvyZQ6A= From: Kieran Bingham To: Geert Uytterhoeven Cc: Linux-Renesas , Laurent Pinchart , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20210923010402.3418555-1-kieran.bingham@ideasonboard.com> <20210923010402.3418555-2-kieran.bingham@ideasonboard.com> Subject: Re: [PATCH v3 1/3] arm64: dts: renesas: r8a779a0: Add DU support Message-ID: <40831759-6827-ea6d-399e-7f27f3669013@ideasonboard.com> Date: Thu, 23 Sep 2021 13:05:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, On 23/09/2021 08:00, Geert Uytterhoeven wrote: > Hi Kieran, > > On Thu, Sep 23, 2021 at 3:04 AM Kieran Bingham > wrote: >> From: Kieran Bingham >> Provide the device nodes for the DU on the V3U platforms. >> >> Reviewed-by: Geert Uytterhoeven >> Reviewed-by: Laurent Pinchart >> Signed-off-by: Kieran Bingham >> --- >> v2 >> - Use a single clock specification for the whole DU. >> >> v3: >> - Use 'du.0' clock name instead of 'du' > > Thanks for the update! > >> --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi >> +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi >> @@ -1251,6 +1251,36 @@ vspd1: vsp@fea28000 { >> renesas,fcp = <&fcpvd1>; >> }; >> >> + du: display@feb00000 { >> + compatible = "renesas,du-r8a779a0"; >> + reg = <0 0xfeb00000 0 0x40000>; >> + interrupts = , >> + ; >> + clocks = <&cpg CPG_MOD 411>; >> + clock-names = "du.0"; >> + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; >> + resets = <&cpg 411>; > > You missed reset-names. Adding it in now. Sorry I must get the dtchecks automated in my builds... -- Kieran > >> + vsps = <&vspd0 0>, <&vspd1 0>; >> + status = "disabled"; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + du_out_dsi0: endpoint { >> + }; >> + }; >> + >> + port@1 { >> + reg = <1>; >> + du_out_dsi1: endpoint { >> + }; >> + }; >> + }; >> + }; >> + >> prr: chipid@fff00044 { >> compatible = "renesas,prr"; >> reg = <0 0xfff00044 0 4>; > > Gr{oetje,eeting}s, > > Geert >