From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755531AbcFQVEe (ORCPT ); Fri, 17 Jun 2016 17:04:34 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:60381 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753222AbcFQVEc (ORCPT ); Fri, 17 Jun 2016 17:04:32 -0400 From: Arnd Bergmann To: Deepa Dinamani Cc: John Stultz , "linux-fsdevel@vger.kernel.org" , lkml , Thomas Gleixner , Al Viro , Linus Torvalds , y2038 Mailman List Subject: Re: [PATCH 15/21] time: Add time64_to_tm() Date: Fri, 17 Jun 2016 23:06:10 +0200 Message-ID: <4087678.I9rJjzimLo@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <1465448705-25055-1-git-send-email-deepa.kernel@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:VPiqjD4SX4XQ1UnSRdUJiDJietViEoIdfv9ZMIYXWonlnvlUhuM jf3CtbgTfzuZj6s4Xio6AJpzDtjZw83E8SoEv9ggKWOasVeyIJhpWqImJ3fNxAs3iKOusTr OGUTtRdXjCnd9n3JyRzCyZVPJ3kE2ICsb1y5TPaioqViXykKn4Hbdi8J33EmbYMk0xfh/8Q DI/iT/a/xUFHkT5Ralcuw== X-UI-Out-Filterresults: notjunk:1;V01:K0:J931nVkCe9g=:i1pF4uhW9js9X2ymIoKc+9 tsP/a0TiApf7mVH6vMs4Ox2EPDwlAxDgvu25iiNjV67jpIcGEHRc+yFGu9aJfxz8OMGlDWqqR TdBxFwpirTv5vuhorTI9ns3aZaR3khcVLRCULpfVgC2bNgoBWDWNHfDzVs8e0mXf/MPD1AmOW 5W4g+tgF1E5gbI0EjiQDUbOdpV5RkLnzJo1DlXID20CkxQqEPhZaM3KNDEpgVLUwr1bWv7/Lo not7xdrytpAaAnNiet/5u649rx98DNRFVHBtzega2kG1PB8m+gUpQYR/TLn9JXH0yutmazHxV Kh8K/vsbnHv7rMtYkswLzz6WLVkuCUzbxlIx87gSQDyErHuCLJiVFMgJfuaHAnmm54i1RZHXw fzk9uVr6igQzYYjQw1279RvDT+nK2QdC0gOlGnrF76SjkeOC07SZWr0+oD/HYvTeJZm3a+rf0 mwoyV1SxaZ6cMriKVsg2IOPeBkDWtJn5DT1tuQFpu9OFICPVOhwEvK3Y917duZCRTckqefhJx PMT486hVZ99+QaF0pMv5XNoOBPp62m4+wPXUSMSVV+7eMm0FxPODbk0PEidRQktcWKgu3fv0V vienyrAgRA10bZvuo/WPkwvs6TXksgy0IKqekF4NWRpm6rLY3mW0KSa+ZW1iSJEeXVQAl4aGx n7nSzTyh08SzEL2gCpK6GppRuvuDlibtAJW7D3+KEJPM1/2CeMk0z4wPg8SVFWk7NgEOsHc6O Ezapwg4OjWPhMQ1l Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, June 17, 2016 1:59:06 PM CEST Deepa Dinamani wrote: > On Fri, Jun 17, 2016 at 1:52 PM, John Stultz wrote: > > On Wed, Jun 15, 2016 at 10:44 AM, Deepa Dinamani wrote: > >> On Tue, Jun 14, 2016 at 2:18 PM, John Stultz wrote: > >>> On Wed, Jun 8, 2016 at 10:04 PM, Deepa Dinamani wrote: > >>>> time_to_tm() takes time_t as an argument. > >>>> time_t is not y2038 safe. > >>>> Add time64_to_tm() that takes time64_t as an argument > >>>> which is y2038 safe. > >>>> The plan is to eventually replace all calls to time_to_tm() > >>>> by time64_to_tm(). > >>>> > >>>> Signed-off-by: Deepa Dinamani > >>>> Cc: John Stultz > >>>> Cc: Thomas Gleixner > >>> > >>> This looks sane to me. Are you hoping for me to queue this, or would > >>> you like i to go though the fsdev maintainers with my ack? > >>> > >>> In either case. > >>> > >>> Acked-by: John Stultz > >> > >> This is only used by the scsi fnic driver. > >> I will separate these 2 patches from this CURRENT_TIME series and > >> then both the patches can be merged through the respective trees. > > > > Sorry, this was not quite clear. I've gone ahead and queued this one > > patch for testing, but let me know and I'll drop it if its going > > through a different tree. > > Ok.This works too. Actually I have three more patches for other drivers that could use the time64_to_tm() function. I'll post them next week and we can decide whether we want to queue the driver changes on top (with the respective Ack). Arnd