From: Auger Eric <eric.auger@redhat.com>
To: Christoffer Dall <christoffer.dall@arm.com>
Cc: eric.auger.pro@gmail.com, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
marc.zyngier@arm.com, cdall@kernel.org, peter.maydell@linaro.org,
andre.przywara@arm.com, drjones@redhat.com, wei@redhat.com
Subject: Re: [PATCH v3 04/12] KVM: arm/arm64: Helper to locate free rdist index
Date: Thu, 26 Apr 2018 09:47:00 +0200 [thread overview]
Message-ID: <40978427-0cf7-3a03-f12e-bde73548180e@redhat.com> (raw)
In-Reply-To: <20180424210704.GG4533@C02W217FHV2R.local>
Hi Christoffer,
On 04/24/2018 11:07 PM, Christoffer Dall wrote:
> On Fri, Apr 13, 2018 at 10:20:50AM +0200, Eric Auger wrote:
>> We introduce vgic_v3_rdist_free_slot to help identifying
>> where we can place a new 2x64KB redistributor.
>>
>> Signed-off-by: Eric Auger <eric.auger@redhat.com>
>> ---
>> virt/kvm/arm/vgic/vgic-mmio-v3.c | 3 +--
>> virt/kvm/arm/vgic/vgic-v3.c | 17 +++++++++++++++++
>> virt/kvm/arm/vgic/vgic.h | 11 +++++++++++
>> 3 files changed, 29 insertions(+), 2 deletions(-)
>>
>> diff --git a/virt/kvm/arm/vgic/vgic-mmio-v3.c b/virt/kvm/arm/vgic/vgic-mmio-v3.c
>> index d1aab18..49ca176 100644
>> --- a/virt/kvm/arm/vgic/vgic-mmio-v3.c
>> +++ b/virt/kvm/arm/vgic/vgic-mmio-v3.c
>> @@ -593,8 +593,7 @@ int vgic_register_redist_iodev(struct kvm_vcpu *vcpu)
>> * function for all VCPUs when the base address is set. Just return
>> * without doing any work for now.
>> */
>> - rdreg = list_first_entry(&vgic->rd_regions,
>> - struct vgic_redist_region, list);
>> + rdreg = vgic_v3_rdist_free_slot(&vgic->rd_regions);
>> if (!rdreg)
>> return 0;
>>
>> diff --git a/virt/kvm/arm/vgic/vgic-v3.c b/virt/kvm/arm/vgic/vgic-v3.c
>> index 94de6cd..820012a 100644
>> --- a/virt/kvm/arm/vgic/vgic-v3.c
>> +++ b/virt/kvm/arm/vgic/vgic-v3.c
>> @@ -444,6 +444,23 @@ bool vgic_v3_check_base(struct kvm *kvm)
>> return false;
>> }
>>
>> +/**
>> + * vgic_v3_rdist_free_slot - Look up registered rdist regions and identify one
>> + * which has free space to put a new rdist regions
>
> Can this structure ever be sparse or do we always find the first empty
> one, as we fill them consecutively ?
We always find the first empty 2x64kB slot within the region (stride
between redistributors = 0). Regions are filled in the index order. The
only hole that can exist is at the end of the region if its size is not
multiple of 2x64kB.
>
> I assume there is some mapping between the regions and the VCPUs'
> redistributors, so perhaps the wording in this comment can be more
> precise.
changed into:
"
A redistributor regions maps n redistributors, n = region size / (2 x 64kB).
Stride between redistributors is 0 and regions are filled in the index
order.
"
>
>> + *
>> + * If any, return this redist region handle, otherwise returns NULL.
>> + */
>> +struct vgic_redist_region *vgic_v3_rdist_free_slot(struct list_head *rd_regions)
>> +{
>> + struct vgic_redist_region *rdreg;
>> +
>> + list_for_each_entry(rdreg, rd_regions, list) {
>> + if (!vgic_v3_redist_region_full(rdreg))
>> + return rdreg;
>> + }
>> + return NULL;
>> +}
>> +
>> int vgic_v3_map_resources(struct kvm *kvm)
>> {
>> int ret = 0;
>> diff --git a/virt/kvm/arm/vgic/vgic.h b/virt/kvm/arm/vgic/vgic.h
>> index 830e815..fea32cb 100644
>> --- a/virt/kvm/arm/vgic/vgic.h
>> +++ b/virt/kvm/arm/vgic/vgic.h
>> @@ -251,6 +251,17 @@ static inline int vgic_v3_max_apr_idx(struct kvm_vcpu *vcpu)
>> }
>> }
>>
>> +static inline bool
>> +vgic_v3_redist_region_full(struct vgic_redist_region *region)
>> +{
>> + if (!region->count)
>> + return false;
>> +
>> + return (region->free_index >= region->count);
>> +}
>> +
>> +struct vgic_redist_region *vgic_v3_rdist_free_slot(struct list_head *rdregs);
>> +
>> int vgic_its_resolve_lpi(struct kvm *kvm, struct vgic_its *its,
>> u32 devid, u32 eventid, struct vgic_irq **irq);
>> struct vgic_its *vgic_msi_to_its(struct kvm *kvm, struct kvm_msi *msi);
>> --
>> 2.5.5
>>
>
> Asides from the above:
>
> Reviewed-by: Christoffer Dall <christoffer.dall@arm.com>
Thanks
Eric
>
next prev parent reply other threads:[~2018-04-26 7:47 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 8:20 [PATCH v3 00/12] KVM: arm/arm64: Allow multiple GICv3 redistributor regions Eric Auger
2018-04-13 8:20 ` [PATCH v3 01/12] KVM: arm/arm64: Set dist->spis to NULL after kfree Eric Auger
2018-04-24 21:06 ` Christoffer Dall
2018-04-13 8:20 ` [PATCH v3 02/12] KVM: arm/arm64: Document KVM_VGIC_V3_ADDR_TYPE_REDIST_REGION Eric Auger
2018-04-13 9:00 ` Peter Maydell
2018-04-24 16:46 ` Christoffer Dall
2018-04-24 16:50 ` Peter Maydell
2018-04-24 20:34 ` Auger Eric
2018-04-24 21:12 ` Christoffer Dall
2018-04-13 8:20 ` [PATCH v3 03/12] KVM: arm/arm64: Replace the single rdist region by a list Eric Auger
2018-04-24 21:06 ` Christoffer Dall
2018-04-13 8:20 ` [PATCH v3 04/12] KVM: arm/arm64: Helper to locate free rdist index Eric Auger
2018-04-24 21:07 ` Christoffer Dall
2018-04-26 7:47 ` Auger Eric [this message]
2018-04-13 8:20 ` [PATCH v3 05/12] KVM: arm/arm64: Revisit Redistributor TYPER last bit computation Eric Auger
2018-04-24 21:06 ` Christoffer Dall
2018-04-13 8:20 ` [PATCH v3 06/12] KVM: arm/arm64: Helper to register a new redistributor region Eric Auger
2018-04-24 16:47 ` Christoffer Dall
2018-04-26 7:32 ` Auger Eric
2018-04-26 10:04 ` Christoffer Dall
2018-04-13 8:20 ` [PATCH v3 07/12] KVM: arm/arm64: Adapt vgic_v3_check_base to multiple rdist regions Eric Auger
2018-04-24 21:07 ` Christoffer Dall
2018-04-26 8:29 ` Auger Eric
2018-04-26 10:06 ` Christoffer Dall
2018-04-26 14:52 ` Auger Eric
2018-04-13 8:20 ` [PATCH v3 08/12] KVM: arm/arm64: Check vcpu redist base before registering an iodev Eric Auger
2018-04-24 21:07 ` Christoffer Dall
2018-04-26 9:25 ` Auger Eric
2018-04-26 10:12 ` Christoffer Dall
2018-04-13 8:20 ` [PATCH v3 09/12] KVM: arm/arm64: Check all vcpu redistributors are set on map_resources Eric Auger
2018-04-24 21:08 ` Christoffer Dall
2018-04-26 9:56 ` Auger Eric
2018-04-26 10:16 ` Christoffer Dall
2018-04-13 8:20 ` [PATCH v3 10/12] KVM: arm/arm64: Add KVM_VGIC_V3_ADDR_TYPE_REDIST_REGION Eric Auger
2018-04-24 21:08 ` Christoffer Dall
2018-04-13 8:20 ` [PATCH v3 11/12] KVM: arm/arm64: Implement KVM_VGIC_V3_ADDR_TYPE_REDIST_REGION Eric Auger
2018-04-24 21:06 ` Christoffer Dall
2018-04-30 7:25 ` Auger Eric
2018-04-27 19:14 ` Christoffer Dall
2018-04-13 8:20 ` [PATCH v3 12/12] KVM: arm/arm64: Bump VGIC_V3_MAX_CPUS to 512 Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40978427-0cf7-3a03-f12e-bde73548180e@redhat.com \
--to=eric.auger@redhat.com \
--cc=andre.przywara@arm.com \
--cc=cdall@kernel.org \
--cc=christoffer.dall@arm.com \
--cc=drjones@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=peter.maydell@linaro.org \
--cc=wei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).