* [PATCH net] ixgbe: recognize 1000BaseLX SFP modules as 1Gbps
@ 2018-11-24 20:57 Josh Elsasser
2018-11-25 11:07 ` Bjørn Mork
2018-11-26 23:35 ` Bowers, AndrewX
0 siblings, 2 replies; 9+ messages in thread
From: Josh Elsasser @ 2018-11-24 20:57 UTC (permalink / raw)
To: intel-wired-lan
Cc: Josh Elsasser, Jeff Kirsher, David S. Miller, netdev, linux-kernel
Add the two 1000BaseLX enum values to the X550's check for 1Gbps modules,
allowing the core driver code to establish a link over this SFP type.
This is done by the out-of-tree driver but the fix wasn't in mainline.
Fixes: 6a14ee0cfb19 ("ixgbe: Add X550 support function pointers")
Signed-off-by: Josh Elsasser <jelsasser@appneta.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c
index 10dbaf4f6e80..9c42f741ed5e 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c
@@ -2262,7 +2262,9 @@ static s32 ixgbe_get_link_capabilities_X550em(struct ixgbe_hw *hw,
*autoneg = false;
if (hw->phy.sfp_type == ixgbe_sfp_type_1g_sx_core0 ||
- hw->phy.sfp_type == ixgbe_sfp_type_1g_sx_core1) {
+ hw->phy.sfp_type == ixgbe_sfp_type_1g_sx_core1 ||
+ hw->phy.sfp_type == ixgbe_sfp_type_1g_lx_core0 ||
+ hw->phy.sfp_type == ixgbe_sfp_type_1g_lx_core1) {
*speed = IXGBE_LINK_SPEED_1GB_FULL;
return 0;
}
--
2.19.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH net] ixgbe: recognize 1000BaseLX SFP modules as 1Gbps
2018-11-24 20:57 [PATCH net] ixgbe: recognize 1000BaseLX SFP modules as 1Gbps Josh Elsasser
@ 2018-11-25 11:07 ` Bjørn Mork
2018-11-26 17:54 ` Josh Elsasser
2018-11-26 23:35 ` Bowers, AndrewX
1 sibling, 1 reply; 9+ messages in thread
From: Bjørn Mork @ 2018-11-25 11:07 UTC (permalink / raw)
To: Josh Elsasser
Cc: intel-wired-lan, Jeff Kirsher, David S. Miller, netdev, linux-kernel
Josh Elsasser <jelsasser@appneta.com> writes:
> Fixes: 6a14ee0cfb19 ("ixgbe: Add X550 support function pointers")
Not that it matters much I guess, but I think LX SFPs were unsupported
at that time. The LX support appears to have been added under the radar
while refactoring ixgbe_setup_sfp_modules_X550em in commit e23f33367882
("ixgbe: Fix 1G and 10G link stability for X550EM_x SFP+")
Bjørn
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net] ixgbe: recognize 1000BaseLX SFP modules as 1Gbps
2018-11-25 11:07 ` Bjørn Mork
@ 2018-11-26 17:54 ` Josh Elsasser
2018-11-26 23:52 ` Jeff Kirsher
0 siblings, 1 reply; 9+ messages in thread
From: Josh Elsasser @ 2018-11-26 17:54 UTC (permalink / raw)
To: Bjørn Mork
Cc: intel-wired-lan, Jeff Kirsher, David S. Miller, netdev, linux-kernel
Bjørn Mork <bjorn@mork.no> wrote:
> Not that it matters much I guess, but I think LX SFPs were unsupported
> at that time. The LX support appears to have been added under the radar
> while refactoring ixgbe_setup_sfp_modules_X550em in commit e23f33367882
> ("ixgbe: Fix 1G and 10G link stability for X550EM_x SFP+")
Looks like you’re right. Want me to respin with an additional “Fixes” tag?
- Josh
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [Intel-wired-lan] [PATCH net] ixgbe: recognize 1000BaseLX SFP modules as 1Gbps
2018-11-24 20:57 [PATCH net] ixgbe: recognize 1000BaseLX SFP modules as 1Gbps Josh Elsasser
2018-11-25 11:07 ` Bjørn Mork
@ 2018-11-26 23:35 ` Bowers, AndrewX
1 sibling, 0 replies; 9+ messages in thread
From: Bowers, AndrewX @ 2018-11-26 23:35 UTC (permalink / raw)
To: intel-wired-lan, netdev, linux-kernel
> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On
> Behalf Of Josh Elsasser
> Sent: Saturday, November 24, 2018 12:58 PM
> To: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org; David S. Miller <davem@davemloft.net>; Josh
> Elsasser <jelsasser@appneta.com>; linux-kernel@vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH net] ixgbe: recognize 1000BaseLX SFP
> modules as 1Gbps
>
> Add the two 1000BaseLX enum values to the X550's check for 1Gbps
> modules, allowing the core driver code to establish a link over this SFP type.
>
> This is done by the out-of-tree driver but the fix wasn't in mainline.
>
> Fixes: 6a14ee0cfb19 ("ixgbe: Add X550 support function pointers")
> Signed-off-by: Josh Elsasser <jelsasser@appneta.com>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net] ixgbe: recognize 1000BaseLX SFP modules as 1Gbps
2018-11-26 17:54 ` Josh Elsasser
@ 2018-11-26 23:52 ` Jeff Kirsher
2018-11-27 0:54 ` [Intel-wired-lan] " Josh Elsasser
0 siblings, 1 reply; 9+ messages in thread
From: Jeff Kirsher @ 2018-11-26 23:52 UTC (permalink / raw)
To: Josh Elsasser, Bjørn Mork
Cc: intel-wired-lan, David S. Miller, netdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 687 bytes --]
On Mon, 2018-11-26 at 09:54 -0800, Josh Elsasser wrote:
> Bjørn Mork <bjorn@mork.no> wrote:
>
> > Not that it matters much I guess, but I think LX SFPs were
> > unsupported
> > at that time. The LX support appears to have been added under the
> > radar
> > while refactoring ixgbe_setup_sfp_modules_X550em in commit
> > e23f33367882
> > ("ixgbe: Fix 1G and 10G link stability for X550EM_x SFP+")
>
> Looks like you’re right. Want me to respin with an additional “Fixes”
> tag?
No need to re-spin the patch, just reply with the additional "Fixes"
tag and if patchwork does not pick it up, I will add it to the patch I
have in my tree for validation and review.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-wired-lan] [PATCH net] ixgbe: recognize 1000BaseLX SFP modules as 1Gbps
2018-11-26 23:52 ` Jeff Kirsher
@ 2018-11-27 0:54 ` Josh Elsasser
2018-11-27 4:52 ` David Miller
0 siblings, 1 reply; 9+ messages in thread
From: Josh Elsasser @ 2018-11-27 0:54 UTC (permalink / raw)
To: Jeff Kirsher, intel-wired-lan; +Cc: netdev, linux-kernel
Jeff Kirsher <jeffrey.t.kirsher@intel.com> wrote:
> No need to re-spin the patch, just reply with the additional "Fixes"
> tag and if patchwork does not pick it up, I will add it to the patch I
> have in my tree for validation and review.
Thanks, let’s try that.
Fixes: e23f33367882 ("ixgbe: Fix 1G and 10G link stability for X550EM_x SFP+”)
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-wired-lan] [PATCH net] ixgbe: recognize 1000BaseLX SFP modules as 1Gbps
2018-11-27 0:54 ` [Intel-wired-lan] " Josh Elsasser
@ 2018-11-27 4:52 ` David Miller
2018-11-27 16:27 ` Jeff Kirsher
2018-11-27 18:07 ` Florian Fainelli
0 siblings, 2 replies; 9+ messages in thread
From: David Miller @ 2018-11-27 4:52 UTC (permalink / raw)
To: jelsasser; +Cc: jeffrey.t.kirsher, intel-wired-lan, netdev, linux-kernel
From: Josh Elsasser <jelsasser@appneta.com>
Date: Mon, 26 Nov 2018 16:54:11 -0800
> Jeff Kirsher <jeffrey.t.kirsher@intel.com> wrote:
>
>> No need to re-spin the patch, just reply with the additional "Fixes"
>> tag and if patchwork does not pick it up, I will add it to the patch I
>> have in my tree for validation and review.
>
> Thanks, let’s try that.
>
> Fixes: e23f33367882 ("ixgbe: Fix 1G and 10G link stability for X550EM_x SFP+”)
Unfortunately, patchwork isn't smart enough to pick up Fixes: tags
still.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-wired-lan] [PATCH net] ixgbe: recognize 1000BaseLX SFP modules as 1Gbps
2018-11-27 4:52 ` David Miller
@ 2018-11-27 16:27 ` Jeff Kirsher
2018-11-27 18:07 ` Florian Fainelli
1 sibling, 0 replies; 9+ messages in thread
From: Jeff Kirsher @ 2018-11-27 16:27 UTC (permalink / raw)
To: David Miller, jelsasser; +Cc: intel-wired-lan, netdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 730 bytes --]
On Mon, 2018-11-26 at 20:52 -0800, David Miller wrote:
> From: Josh Elsasser <jelsasser@appneta.com>
> Date: Mon, 26 Nov 2018 16:54:11 -0800
>
> > Jeff Kirsher <jeffrey.t.kirsher@intel.com> wrote:
> >
> > > No need to re-spin the patch, just reply with the additional
> > > "Fixes"
> > > tag and if patchwork does not pick it up, I will add it to the
> > > patch I
> > > have in my tree for validation and review.
> >
> > Thanks, let’s try that.
> >
> > Fixes: e23f33367882 ("ixgbe: Fix 1G and 10G link stability for
> > X550EM_x SFP+”)
>
> Unfortunately, patchwork isn't smart enough to pick up Fixes: tags
> still.
:-( I will get it added to the patch in my tree then. Thanks Dave for
the info.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-wired-lan] [PATCH net] ixgbe: recognize 1000BaseLX SFP modules as 1Gbps
2018-11-27 4:52 ` David Miller
2018-11-27 16:27 ` Jeff Kirsher
@ 2018-11-27 18:07 ` Florian Fainelli
1 sibling, 0 replies; 9+ messages in thread
From: Florian Fainelli @ 2018-11-27 18:07 UTC (permalink / raw)
To: David Miller, jelsasser
Cc: jeffrey.t.kirsher, intel-wired-lan, netdev, linux-kernel
On 11/26/2018 8:52 PM, David Miller wrote:
> From: Josh Elsasser <jelsasser@appneta.com>
> Date: Mon, 26 Nov 2018 16:54:11 -0800
>
>> Jeff Kirsher <jeffrey.t.kirsher@intel.com> wrote:
>>
>>> No need to re-spin the patch, just reply with the additional "Fixes"
>>> tag and if patchwork does not pick it up, I will add it to the patch I
>>> have in my tree for validation and review.
>>
>> Thanks, let’s try that.
>>
>> Fixes: e23f33367882 ("ixgbe: Fix 1G and 10G link stability for X550EM_x SFP+”)
>
> Unfortunately, patchwork isn't smart enough to pick up Fixes: tags
> still.
>
This is something that can be added easily in the patchwork
administration panel, maybe ask Jeremy or Stephen to do that?
--
Florian
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-11-27 18:07 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-24 20:57 [PATCH net] ixgbe: recognize 1000BaseLX SFP modules as 1Gbps Josh Elsasser
2018-11-25 11:07 ` Bjørn Mork
2018-11-26 17:54 ` Josh Elsasser
2018-11-26 23:52 ` Jeff Kirsher
2018-11-27 0:54 ` [Intel-wired-lan] " Josh Elsasser
2018-11-27 4:52 ` David Miller
2018-11-27 16:27 ` Jeff Kirsher
2018-11-27 18:07 ` Florian Fainelli
2018-11-26 23:35 ` Bowers, AndrewX
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).