From: Nadav Amit <nadav.amit@gmail.com>
To: Peter Xu <peterx@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Andi Kleen <andi.kleen@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
Huang Ying <ying.huang@intel.com>,
"Kirill A . Shutemov" <kirill@shutemov.name>,
Vlastimil Babka <vbabka@suse.cz>,
David Hildenbrand <david@redhat.com>,
Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCH 2/2] mm: Remember young bit for page migrations
Date: Thu, 4 Aug 2022 10:16:50 -0700 [thread overview]
Message-ID: <40FDA6B1-EB53-484D-91A0-323606199C4E@gmail.com> (raw)
In-Reply-To: <Yuv811AnT9aoBxbH@xz-m1.local>
On Aug 4, 2022, at 10:07 AM, Peter Xu <peterx@redhat.com> wrote:
> On Wed, Aug 03, 2022 at 11:42:39PM -0700, Nadav Amit wrote:
>> On Aug 3, 2022, at 9:45 AM, Peter Xu <peterx@redhat.com> wrote:
>
> For this series, I can think more of dropping the young bit for migration
> entry during these madvises (which should be relatively safe with the
> pgtable held, since I don't need to touch the page but just modify the swap
> entry within), but probably that's not really the major problem here, so
> not sure whether that matters a huge lot (e.g., for FREE we should really
> drop the whole entry?).
Sounds good to me. I just had a look whether the swap entry should be
checked and hit these additional cases, so I thought they are worthy of
consideration. But as they are already not handling some cases, which is
valid for madvise's hints, leaving it to later sounds fine.
Handling migration entries anyhow might not be worthy of the risk of
breaking something.
next prev parent reply other threads:[~2022-08-04 17:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 1:21 [PATCH 0/2] mm: Remember young bit for migration entries Peter Xu
2022-08-03 1:21 ` [PATCH 1/2] mm/swap: Add swp_offset_pfn() to fetch PFN from swap entry Peter Xu
2022-08-03 1:21 ` [PATCH 2/2] mm: Remember young bit for page migrations Peter Xu
2022-08-03 7:42 ` Nadav Amit
2022-08-03 16:45 ` Peter Xu
2022-08-04 6:42 ` Nadav Amit
2022-08-04 17:07 ` Peter Xu
2022-08-04 17:16 ` Nadav Amit [this message]
2022-08-03 12:21 ` kernel test robot
2022-08-03 21:47 ` Peter Xu
2022-08-03 13:53 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40FDA6B1-EB53-484D-91A0-323606199C4E@gmail.com \
--to=nadav.amit@gmail.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi.kleen@intel.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=peterx@redhat.com \
--cc=vbabka@suse.cz \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).