From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF3C6C169C4 for ; Tue, 29 Jan 2019 11:35:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A97A920844 for ; Tue, 29 Jan 2019 11:35:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728619AbfA2Lfr (ORCPT ); Tue, 29 Jan 2019 06:35:47 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:59619 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725811AbfA2Lfr (ORCPT ); Tue, 29 Jan 2019 06:35:47 -0500 X-Originating-IP: 83.155.44.161 Received: from classic (mon69-7-83-155-44-161.fbx.proxad.net [83.155.44.161]) (Authenticated sender: hadess@hadess.net) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 670D8C0005; Tue, 29 Jan 2019 11:35:43 +0000 (UTC) Message-ID: <40a185818ed76b2965b117d62fae2d21264d1fb7.camel@hadess.net> Subject: Re: [PATCH v2] input: goodix - support Goodix gt5688 From: Bastien Nocera To: Guido =?ISO-8859-1?Q?G=FCnther?= Cc: Dmitry Torokhov , Rob Herring , Mark Rutland , Matthias Brugger , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Date: Tue, 29 Jan 2019 12:35:42 +0100 In-Reply-To: <20190129111113.GA32222@bogon.m.sigxcpu.org> References: <20190129111113.GA32222@bogon.m.sigxcpu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.4 (3.30.4-1.fc29) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2019-01-29 at 12:11 +0100, Guido Günther wrote: > From what I've seen in vendor trees it's fine to treat this as gt1x¹. > Tested on the Purism Librem 5 Devkit (Rocktech JH057N00900 panel). > > [1]: > https://github.com/TadiT7/android_kernel_mtk-4.4/tree/master/drivers/input/touchscreen/mediatek/GT5688 > > Signed-off-by: Guido Günther Not super fond of the casual commit message, but the code and explanation are fine. Reviewed-by: Bastien Nocera > --- > Changes from v1: > * Add tested board to commit message > > Documentation/devicetree/bindings/input/touchscreen/goodix.txt | 1 + > drivers/input/touchscreen/goodix.c | 2 > ++ > 2 files changed, 3 insertions(+) > > diff --git > a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt > b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt > index f7e95c52f3c7..57d3d8870a09 100644 > --- a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt > +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt > @@ -3,6 +3,7 @@ Device tree bindings for Goodix GT9xx series > touchscreen controller > Required properties: > > - compatible : Should be "goodix,gt1151" > + or "goodix,gt5688" > or "goodix,gt911" > or "goodix,gt9110" > or "goodix,gt912" > diff --git a/drivers/input/touchscreen/goodix.c > b/drivers/input/touchscreen/goodix.c > index f2d9c2c41885..47b1ced41576 100644 > --- a/drivers/input/touchscreen/goodix.c > +++ b/drivers/input/touchscreen/goodix.c > @@ -216,6 +216,7 @@ static const struct goodix_chip_data > *goodix_get_chip_data(u16 id) > { > switch (id) { > case 1151: > + case 5688: > return >1x_chip_data; > > case 911: > @@ -942,6 +943,7 @@ MODULE_DEVICE_TABLE(acpi, goodix_acpi_match); > #ifdef CONFIG_OF > static const struct of_device_id goodix_of_match[] = { > { .compatible = "goodix,gt1151" }, > + { .compatible = "goodix,gt5688" }, > { .compatible = "goodix,gt911" }, > { .compatible = "goodix,gt9110" }, > { .compatible = "goodix,gt912" },