From: Sibi Sankar <sibis@codeaurora.org>
To: govinds@codeaurora.org
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Brian Norris <briannorris@chromium.org>,
John Stultz <john.stultz@linaro.org>,
lkml <linux-kernel@vger.kernel.org>,
Rakesh Pillai <pillair@qti.qualcomm.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Niklas Cassel <niklas.cassel@linaro.org>,
Amit Pundir <amit.pundir@linaro.org>,
Kalle Valo <kvalo@codeaurora.org>,
ath10k <ath10k@lists.infradead.org>,
linux-kernel-owner@vger.kernel.org
Subject: Re: [PATCH] wireless: ath10k: Return early in ath10k_qmi_event_server_exit() to avoid hard crash on reboot
Date: Thu, 04 Jun 2020 23:47:18 +0530 [thread overview]
Message-ID: <40a7d87e5774d56d9ca31e4de0c17831@codeaurora.org> (raw)
In-Reply-To: <4e0642b9882c41f4c10963b265bf6d9f@codeaurora.org>
On 2020-06-03 15:37, govinds@codeaurora.org wrote:
> Hi Mani,
>
> On 2020-06-03 05:57, Manivannan Sadhasivam wrote:
>> On Tue, Jun 02, 2020 at 01:04:26PM -0700, Brian Norris wrote:
>>> On Tue, Jun 2, 2020 at 12:40 PM John Stultz <john.stultz@linaro.org>
>>> wrote:
>>> > On Tue, Jun 2, 2020 at 12:16 PM Brian Norris <briannorris@chromium.org> wrote:
>>> > > On Mon, Jun 1, 2020 at 10:25 PM John Stultz <john.stultz@linaro.org> wrote:
>>> > > >
>>> > > > Ever since 5.7-rc1, if we call
>>> > > > ath10k_qmi_remove_msa_permission(), the db845c hard crashes on
>>> > > > reboot, resulting in the device getting stuck in the usb crash
>>> > > > debug mode and not coming back up wihthout a hard power off.
>>> > > >
>>> > > > This hack avoids the issue by returning early in
>>> > > > ath10k_qmi_event_server_exit().
>>> > > >
>>> > > > A better solution is very much desired!
>>> > >
>>> > > Any chance you can bisect what caused this? There are a lot of
>>> > > non-ath10k pieces involved in this stuff.
>>> >
>>> > Amit had spent some work on chasing it down to the in kernel qrtr-ns
>>> > work, and reported it here:
>>> > https://lists.infradead.org/pipermail/ath10k/2020-April/014970.html
>>> >
>>> > But that discussion seemingly stalled out, so I came up with this hack
>>> > to workaround it for us.
>>>
>>> If I'm reading it right, then that means we should revert this stuff
>>> from v5.7-rc1:
>>>
>>> 0c2204a4ad71 net: qrtr: Migrate nameservice to kernel from userspace
>>>
>>> At least, until people can resolve the tail end of that thread. New
>>> features (ath11k, etc.) are not a reason to break existing features
>>> (ath10k/wcn3990).
>>
>> I don't agree with this. If you read through the replies to the bug
>> report,
>> it is clear that NS migration uncovered a corner case or even a bug.
>> So we
>> should try to fix that indeed.
>>
>> Govind: Did you get chance to work on fixing this issue?
>>
>
> I have done basic testing by moving msa map/unmap from qmi service
> callbacks to init/de-init path.
> I will send patch for review.
> Reason for del_server needs to investigated from rproc side.
Govind,
On receiving SIGTERM, rmtfs would try
to perform a graceful shutdown of the
modem, that should be the source of
the del_server.
>
>> Thanks,
>> Mani
>>
>>>
>>> Brian
>
> Thanks,
> Govind
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2020-06-04 18:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 5:25 [PATCH] wireless: ath10k: Return early in ath10k_qmi_event_server_exit() to avoid hard crash on reboot John Stultz
2020-06-02 19:16 ` Brian Norris
2020-06-02 19:40 ` John Stultz
2020-06-02 20:04 ` Brian Norris
2020-06-03 0:27 ` Manivannan Sadhasivam
2020-06-03 10:07 ` govinds
2020-06-04 18:17 ` Sibi Sankar [this message]
2020-06-08 11:37 ` Kalle Valo
2020-08-17 9:06 ` Amit Pundir
2020-08-28 12:52 ` Kalle Valo
2020-08-28 13:07 ` Govind Singh
2020-09-07 16:12 ` Kalle Valo
2020-06-08 11:17 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40a7d87e5774d56d9ca31e4de0c17831@codeaurora.org \
--to=sibis@codeaurora.org \
--cc=amit.pundir@linaro.org \
--cc=ath10k@lists.infradead.org \
--cc=bjorn.andersson@linaro.org \
--cc=briannorris@chromium.org \
--cc=govinds@codeaurora.org \
--cc=john.stultz@linaro.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel-owner@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=niklas.cassel@linaro.org \
--cc=pillair@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).