linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jaehoon Chung <jh80.chung@samsung.com>
To: Kalle Valo <kvalo@codeaurora.org>,
	Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "open list:TI WILINK WIRELES..." <linux-wireless@vger.kernel.org>,
	"open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" 
	<brcm80211-dev-list.pdl@broadcom.com>,
	brcm80211-dev-list@cypress.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Arend van Spriel <arend.vanspriel@broadcom.com>,
	Franky Lin <franky.lin@broadcom.com>,
	Hante Meuleman <hante.meuleman@broadcom.com>,
	Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
	Wright Feng <wright.feng@cypress.com>
Subject: Re: [PATCH] brcmfmac: fix wrong location to get firmware feature
Date: Wed, 1 Apr 2020 19:20:13 +0900	[thread overview]
Message-ID: <40b711a5-869b-1dac-0ac9-e6e59d4bcd52@samsung.com> (raw)
In-Reply-To: <87r1xaf8r7.fsf@codeaurora.org>

On 3/30/20 7:16 PM, Kalle Valo wrote:
> Andy Shevchenko <andy.shevchenko@gmail.com> writes:
> 
>> On Mon, Mar 30, 2020 at 8:26 AM Jaehoon Chung <jh80.chung@samsung.com> wrote:
>>>
>>> sup_wpa feature is getting after setting feature_disable flag.
>>> If firmware is supported sup_wpa feature,  it's always enabled
>>> regardless of feature_disable flag.
>>>
>>
>>> Fixes: b8a64f0e96c2 ("brcmfmac: support 4-way handshake offloading for WPA/WPA2-PSK")
>>>
>>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>>
>> No blank line in between. (Dunno if you need to resend, just wait what
>> maintainer says)
> 
> I can fix that during commit, no need to resend because of this.

Thanks!

BTW, I have a question about brcmfmac's firmware feature.
When i have tested on RPI4, it seems that 4-way handshake offloading feature is using.

If I entered the wrong password, which event is triggered from firmware? 
And how does wpa_supplicant know about wrong key?

I don't have much knowledge about this..but if my analyzing is correct.

<7>[  119.278494] brcmfmac: brcmf_is_nonetwork Processing failed supplicant state: 8
...
<7>[  119.278525] brcmfmac: brcmf_bss_connect_done Report connect result - connection failed
...
<7>[  119.278726] brcmfmac: brcmf_fweh_event_worker event DEAUTH_IND (6) ifidx 0 bsscfg 0 addr 70:5d:cc:6e:b5:xx

<7>[  119.280966] brcmfmac: brcmf_fweh_event_worker event DEAUTH (5) ifidx 0 bsscfg 0 addr 70:5d:cc:6e:b5:xx


firmware is indicating DEAUTH event and driver will be controlled with it, right?
Can someone explain to me in more detail, plz? 

Best Regards,
Jaehoon Chung



> 


  reply	other threads:[~2020-04-01 10:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200330052521epcas1p1eedc926d4b11513f8502cf0c90ecf433@epcas1p1.samsung.com>
2020-03-30  5:25 ` [PATCH] brcmfmac: fix wrong location to get firmware feature Jaehoon Chung
2020-03-30  9:08   ` Andy Shevchenko
2020-03-30 10:16     ` Kalle Valo
2020-04-01 10:20       ` Jaehoon Chung [this message]
2020-04-14 15:03   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40b711a5-869b-1dac-0ac9-e6e59d4bcd52@samsung.com \
    --to=jh80.chung@samsung.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=arend.vanspriel@broadcom.com \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=brcm80211-dev-list@cypress.com \
    --cc=chi-hsien.lin@cypress.com \
    --cc=franky.lin@broadcom.com \
    --cc=hante.meuleman@broadcom.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=wright.feng@cypress.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).