From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 640E2CA9ECB for ; Thu, 31 Oct 2019 15:53:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 401E72087F for ; Thu, 31 Oct 2019 15:53:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728458AbfJaPxR (ORCPT ); Thu, 31 Oct 2019 11:53:17 -0400 Received: from mx2.suse.de ([195.135.220.15]:38932 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726602AbfJaPxQ (ORCPT ); Thu, 31 Oct 2019 11:53:16 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E32D1B7DF; Thu, 31 Oct 2019 15:53:14 +0000 (UTC) Message-ID: <40d06d463c05d36968e8b64924d78f7794f8de50.camel@suse.de> Subject: Re: [PATCH] dma/direct: turn ARCH_ZONE_DMA_BITS into a variable From: Nicolas Saenz Julienne To: Christoph Hellwig Cc: Marek Szyprowski , Robin Murphy , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, iommu@lists.linux-foundation.org Date: Thu, 31 Oct 2019 16:53:13 +0100 In-Reply-To: <20191031154759.GA7162@lst.de> References: <20191031152837.15253-1-nsaenzjulienne@suse.de> <20191031154759.GA7162@lst.de> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-IbItouLWOYON9B5ojQkb" User-Agent: Evolution 3.34.1 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-IbItouLWOYON9B5ojQkb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2019-10-31 at 16:47 +0100, Christoph Hellwig wrote: > On Thu, Oct 31, 2019 at 04:28:37PM +0100, Nicolas Saenz Julienne wrote: > > Some architectures, notably ARM, are interested in tweaking this > > depending on their runtime DMA addressing limitations. > >=20 > > Signed-off-by: Nicolas Saenz Julienne > > --- > >=20 > > Changes since RFC: > > - Rebased to v5.4-rc6, fixed arm64 code. > >=20 > > NOTE: This will only apply to linux-next, where=20 >=20 > missing end of the sentence. But only applying to linux-next isn't > going to help anyone.. Arrgh, excuse me, I meant to delete that line. > > diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c > > index 45c00a54909c..f716ea634804 100644 > > --- a/arch/arm64/mm/init.c > > +++ b/arch/arm64/mm/init.c > > @@ -20,6 +20,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -41,6 +42,8 @@ > > #include > > #include > > =20 > > +#define ARM64_ZONE_DMA_BITS 30 > > + > > /* > > * We need to be able to catch inadvertent references to memstart_addr > > * that occur (potentially in generic code) before arm64_memblock_init= () > > @@ -424,6 +427,8 @@ void __init arm64_memblock_init(void) > > else > > arm64_dma_phys_limit =3D PHYS_MASK + 1; > > =20 > > + zone_dma_bits =3D ARM64_ZONE_DMA_BITS; > > + > > reserve_crashkernel(); >=20 > This actually adds a new limit, as there wasn't one before for arm64. Well, as zone_dma_bits is only relevant in dma/direct when ZONE_DMA is defi= ned I figured it doesn't matter if the variable is set conditionally to ZONE_DM= A or not. --=-IbItouLWOYON9B5ojQkb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEErOkkGDHCg2EbPcGjlfZmHno8x/4FAl27A2kACgkQlfZmHno8 x/7XBAf+KJ5m8SMWsJJk7jjM0aD1BkIeWDHPYCN7ZJq7655nTwa46aZv3zb18e3J 4muJ6LfXcTh/PbK64B+/uJ+wGYyg0y4ObyEshTyxygfgDnnyCQ4Mr3kD38jm40tR pJh9bItNrHBr+LzC2oZhwwnj4K4haI2q1HO8C6waGzeQLNW6KGmQquBqbROWiTG3 EJVQ5SwIHesd1qwzVo+Lpba3IHAf6FrVDoZ1/TnUCDgkEvPOX2N20IUroOb0O2Eu 5L80i++E4veGNr4AxY2Ne0kXVIZWCiZNoO5HpB7EPreFYta5w5JCbVqZDvGl9YGI T+txLLE6SqBuvD/E5j2iwzXXv2SqQA== =jZsg -----END PGP SIGNATURE----- --=-IbItouLWOYON9B5ojQkb--