From: Bean Huo <huobean@gmail.com>
To: Stanley Chu <stanley.chu@mediatek.com>
Cc: alim.akhtar@samsung.com, avri.altman@wdc.com,
asutoshd@codeaurora.org, jejb@linux.ibm.com,
martin.petersen@oracle.com, beanhuo@micron.com,
bvanassche@acm.org, tomas.winkler@intel.com, cang@codeaurora.org,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 5/6] scsi: ufs: Cleanup WB buffer flush toggle implementation
Date: Tue, 15 Dec 2020 10:28:02 +0100 [thread overview]
Message-ID: <410bf2a27978abb74ba41bc9f9198dcf85636b3c.camel@gmail.com> (raw)
In-Reply-To: <1608023234.10163.19.camel@mtkswgap22>
On Tue, 2020-12-15 at 17:07 +0800, Stanley Chu wrote:
> > if (ret) {
> > - dev_warn(hba->dev, "%s: WB - buf flush disable failed
> > %d\n",
> > - __func__, ret);
> > - } else {
> > - hba->dev_info.wb_buf_flush_enabled = false;
> > - dev_dbg(hba->dev, "WB - Flush disabled: %d\n", ret);
> > + dev_err(hba->dev, "%s WB-Buf Flush %s failed %d\n",
> > __func__,
> > + enable ? "enable" : "disable", ret);
> > + goto out;
> > }
> >
> > + if (enable)
> > + hba->dev_info.wb_buf_flush_enabled = true;
> > + else
> > + hba->dev_info.wb_buf_flush_enabled = false;
>
> Perhaps this could be simpler as below?
>
> hba->dev_info.wb_buf_flush_enabled = enable;
Thanks, will be changed in next version.
Bean
next prev parent reply other threads:[~2020-12-15 9:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 14:00 [PATCH v4 0/6] Several changes for UFS WriteBooster Bean Huo
2020-12-11 14:00 ` [PATCH v4 1/6] scsi: ufs: Add "wb_on" sysfs node to control WB on/off Bean Huo
2020-12-15 10:32 ` Greg KH
2020-12-15 19:56 ` Bean Huo
2020-12-11 14:00 ` [PATCH v4 2/6] scsi: ufs: Changes comment in the function ufshcd_wb_probe() Bean Huo
2020-12-11 14:00 ` [PATCH v4 3/6] scsi: ufs: Group UFS WB related flags to struct ufs_dev_info Bean Huo
2020-12-15 9:01 ` Stanley Chu
2020-12-15 9:42 ` Bean Huo
2020-12-15 10:11 ` Stanley Chu
2020-12-11 14:00 ` [PATCH v4 4/6] scsi: ufs: Remove d_wb_alloc_units from " Bean Huo
2020-12-15 8:57 ` Stanley Chu
2020-12-15 9:59 ` Bean Huo
2020-12-11 14:00 ` [PATCH v4 5/6] scsi: ufs: Cleanup WB buffer flush toggle implementation Bean Huo
2020-12-15 9:07 ` Stanley Chu
2020-12-15 9:28 ` Bean Huo [this message]
2020-12-11 14:00 ` [PATCH v4 6/6] scsi: ufs: Keep device active mode only fWriteBoosterBufferFlushDuringHibernate == 1 Bean Huo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=410bf2a27978abb74ba41bc9f9198dcf85636b3c.camel@gmail.com \
--to=huobean@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).