From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60330C433EF for ; Thu, 14 Oct 2021 08:04:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 413AA61040 for ; Thu, 14 Oct 2021 08:04:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230179AbhJNIHA (ORCPT ); Thu, 14 Oct 2021 04:07:00 -0400 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:57648 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230082AbhJNIG7 (ORCPT ); Thu, 14 Oct 2021 04:06:59 -0400 Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 63F813FFE7 for ; Thu, 14 Oct 2021 08:04:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1634198694; bh=ojVn2ZVbkcgXLj7A1DRlVPqyw/Wvd+lGjqh+OPrsbYg=; h=To:Cc:References:From:Subject:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=LM/6pF73JhqIwQSa7AcT6jtzjMmNOD5Mll19fFF+OhB8Qdkernr4Yq92BMmVUZ5n6 BSWAxFv2dbyfacaS4+Tm2mU1MpO2uQtGazMfIH72qQg1DY5gGU8B/k+cPiqnAevR6d N2dYy8awEiU+RNrkvDWXW4c4wC1uVsmXet0F6UdZTEcJ5IYU51eGoI2deGaPS+2Wh2 CW8hGUeYqW2ulImFdZcBPs0NOA4hv4s6jrsEtwfjI6Ilr+6vvu89sJBt1Vr32uTlQX S/9uo2vB1v26L2oKI2DliFzKWqiYkMYVYfVqrDFJu7s7Rk/W5De67SF0nsyUR0A/49 xl0tqk0RXA/EA== Received: by mail-lf1-f72.google.com with SMTP id x33-20020a0565123fa100b003fcfd99073dso3831409lfa.6 for ; Thu, 14 Oct 2021 01:04:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ojVn2ZVbkcgXLj7A1DRlVPqyw/Wvd+lGjqh+OPrsbYg=; b=OHq0oGQwr0IFI8ly0EJAssVtqXIHp+Gso/e13mCVH/wXSaI5PAWdzOUgnO9e+AdI6b PbOKdcCfH11s5p0FUipzGzQo+gV+C+kbooXUUmMog/xTZ5oZPzWjKfS3/u3blNgmO3FO MhgcwRGxdSMHFAbcLwzyRSrQ5nw65yERIBWZ7Hq5zk0gKkH28Iu4Yqn5rk/DPRgME4Bh m1LuWQTtXS2Lxm0Q0kIa3QSkqjepmhbEDShU2wORfl1e9RsdwyusPddx2rqzzhpgdsXp 16ka4q8PWXxi10jzCdxk34Bi0vRd7D1RJUtI4CIIJ8IbpD87hlC6vqqQYQXLtMrDmo6k qMrw== X-Gm-Message-State: AOAM531jw9fndRs466YvJzPa68BLYjXg6XUjz2nzzSrE9efBitT2+KtN a4IGWiF7DRnbq8NBrbApgXmMZkn6L8M1amjAdRw9PxNjtndfUE0tHvrUq7e0St7cIfK/Uupf6Kg mN0UKldJIKgCVnHLlg4Kldvx5Efawi0sGkUuaevKuCA== X-Received: by 2002:a05:651c:907:: with SMTP id e7mr4525989ljq.457.1634198693278; Thu, 14 Oct 2021 01:04:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw+fscirp5GuIbG7uOPrahokzBv9+3ns/V49MlZBkkCWBoqQbGM80foMTQ19Sle1sD5Y+4ZXA== X-Received: by 2002:a05:651c:907:: with SMTP id e7mr4525955ljq.457.1634198692964; Thu, 14 Oct 2021 01:04:52 -0700 (PDT) Received: from [192.168.3.161] (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id z12sm161733lfs.101.2021.10.14.01.04.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Oct 2021 01:04:52 -0700 (PDT) To: Hector Martin , linux-arm-kernel@lists.infradead.org Cc: Alyssa Rosenzweig , Sven Peter , Marc Zyngier , Mark Kettenis , Michael Turquette , Stephen Boyd , Rob Herring , Viresh Kumar , Nishanth Menon , Catalin Marinas , "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20211011165707.138157-1-marcan@marcan.st> <20211011165707.138157-7-marcan@marcan.st> <2a6f14e5-fbc9-4b9a-9378-a4b5200bc3fb@marcan.st> <00925242-b837-d75b-3655-536d45dcd4d2@marcan.st> From: Krzysztof Kozlowski Subject: Re: [RFC PATCH 6/9] memory: apple: Add apple-mcc driver to manage MCC perf in Apple SoCs Message-ID: <410c0ccb-68d3-478b-2b5b-9165890e614a@canonical.com> Date: Thu, 14 Oct 2021 10:04:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <00925242-b837-d75b-3655-536d45dcd4d2@marcan.st> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/10/2021 09:52, Hector Martin wrote: > On 14/10/2021 16.36, Krzysztof Kozlowski wrote: (...) > >>> Ah, I didn't realize that was a valid option for MODULE_LICENSE. I guess >>> anything containing "GPL" works with EXPORT_SYMBOL_GPL? >> >> I don't think exporting symbols is related to how you license your code. > > It is; only modules with a GPL-compatible MODULE_LICENSE get to use > symbols exported via EXPORT_SYMBOL_GPL. Although there might be such correlation but it's not a rule. You can have a GPL module exporting symbols without GPL requirement (EXPORT_SYMBOLS). You can have a GPL+MIT module exporting symbols as GPL. Obviously you cannot have a non-GPL module, as we do not accept these and there is no such choice. So answering your question that "GPL" works with EXPORT_SYMBOL_GPL - everything is GPL but it works with both EXPORT_SYMBOL and EXPORT_SYMBOL_GPL. > > See kernel/module.c for the symbol lookup logic and > include/linux/license.h for the logic to check the string (seems like > "Dual MIT/GPL" is explicitly whitelisted there). Not related to export symbol. It is used for determining the tainted kernel via other licenses. > > Of course, this is a futile effort, as ~every time I see a proprietary > module in some embedded device, it either falsely declares itself to be > GPL, or they have a shim module that re-exports GPL symbols as non-GPL. > This is being removed soon (or already). Best regards, Krzysztof