From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6D81C433ED for ; Wed, 14 Apr 2021 16:26:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9953E61158 for ; Wed, 14 Apr 2021 16:26:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352722AbhDNQ0v (ORCPT ); Wed, 14 Apr 2021 12:26:51 -0400 Received: from mx2.suse.de ([195.135.220.15]:40528 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233964AbhDNQ0s (ORCPT ); Wed, 14 Apr 2021 12:26:48 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 15DB5AF0E; Wed, 14 Apr 2021 16:26:26 +0000 (UTC) Subject: Re: [PATCH 04/11] mm/vmstat: Inline NUMA event counter updates From: Vlastimil Babka To: Mel Gorman , Linux-MM , Linux-RT-Users Cc: LKML , Chuck Lever , Jesper Dangaard Brouer , Thomas Gleixner , Peter Zijlstra , Ingo Molnar , Michal Hocko References: <20210414133931.4555-1-mgorman@techsingularity.net> <20210414133931.4555-5-mgorman@techsingularity.net> <6b25af48-9c6e-2c55-03d5-763de4aba149@suse.cz> Message-ID: <411a753f-ce03-389d-9a9f-93d17b284862@suse.cz> Date: Wed, 14 Apr 2021 18:26:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <6b25af48-9c6e-2c55-03d5-763de4aba149@suse.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/14/21 6:20 PM, Vlastimil Babka wrote: > On 4/14/21 3:39 PM, Mel Gorman wrote: >> __count_numa_event is small enough to be treated similarly to >> __count_vm_event so inline it. >> >> Signed-off-by: Mel Gorman > > Acked-by: Vlastimil Babka > >> --- >> include/linux/vmstat.h | 9 +++++++++ >> mm/vmstat.c | 9 --------- >> 2 files changed, 9 insertions(+), 9 deletions(-) >> >> diff --git a/include/linux/vmstat.h b/include/linux/vmstat.h >> index fc14415223c5..dde4dec4e7dd 100644 >> --- a/include/linux/vmstat.h >> +++ b/include/linux/vmstat.h >> @@ -237,6 +237,15 @@ static inline unsigned long zone_page_state_snapshot(struct zone *zone, >> } >> >> #ifdef CONFIG_NUMA >> +/* See __count_vm_event comment on why raw_cpu_inc is used. */ >> +static inline void >> +__count_numa_event(struct zone *zone, enum numa_stat_item item) >> +{ >> + struct per_cpu_zonestat __percpu *pzstats = zone->per_cpu_zonestats; >> + >> + raw_cpu_inc(pzstats->vm_numa_event[item]); >> +} >> + >> extern void __count_numa_event(struct zone *zone, enum numa_stat_item item); Ah, but the line above should be removed. >> extern unsigned long sum_zone_node_page_state(int node, >> enum zone_stat_item item); >> diff --git a/mm/vmstat.c b/mm/vmstat.c >> index 63bd84d122c0..b853df95ed0c 100644 >> --- a/mm/vmstat.c >> +++ b/mm/vmstat.c >> @@ -902,15 +902,6 @@ void drain_zonestat(struct zone *zone, struct per_cpu_zonestat *pzstats) >> #endif >> >> #ifdef CONFIG_NUMA >> -/* See __count_vm_event comment on why raw_cpu_inc is used. */ >> -void __count_numa_event(struct zone *zone, >> - enum numa_stat_item item) >> -{ >> - struct per_cpu_zonestat __percpu *pzstats = zone->per_cpu_zonestats; >> - >> - raw_cpu_inc(pzstats->vm_numa_event[item]); >> -} >> - >> /* >> * Determine the per node value of a stat item. This function >> * is called frequently in a NUMA machine, so try to be as >> >