From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C94BEC3F2CD for ; Wed, 4 Mar 2020 11:18:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9E1D720870 for ; Wed, 4 Mar 2020 11:18:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SOoAKofW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387901AbgCDLSU (ORCPT ); Wed, 4 Mar 2020 06:18:20 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:30091 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387488AbgCDLSU (ORCPT ); Wed, 4 Mar 2020 06:18:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583320698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tnbYBEfHFy2uHBhpK72x5hzqEk/RbkzKjku1Fg6oRoM=; b=SOoAKofWTfS9JkRqHDKMMkmWhaT4vyESh80eMQh7Hkcucbl64gIWCz4jIFbRcJNQqzVm4B E4W6qd+fLQumBPK6sOKufMgDpaWuq4YA6F3Sj8jCBOxwp5OSfppDZkz0aO22q3wf/zrPj6 +HkRK2Vtj99UePA5BklZM/bT2mbGMqQ= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-439-3-AYlm_9MVmi5AWil1_3RQ-1; Wed, 04 Mar 2020 06:18:17 -0500 X-MC-Unique: 3-AYlm_9MVmi5AWil1_3RQ-1 Received: by mail-wr1-f72.google.com with SMTP id w18so722011wro.2 for ; Wed, 04 Mar 2020 03:18:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=tnbYBEfHFy2uHBhpK72x5hzqEk/RbkzKjku1Fg6oRoM=; b=Ex27L6FD9x0/Yl9j0jv7yLD4pwv5jZMm/VxMqu3tV+a2HwPTsUlYQ+PCXvYBNEZASp Eep31G9oyGAWYZK8pW0pIpmTFlYjqK9fYBM8MFBOhppzuVA0aJaT61dopkuzy+msxQYn PPHU9CFtEAQNHG63na7GXnybF4vOVtN/8YWxt3ojsOLelwGJz576fRGKch70q1DYfugS YqTq9cEv0eRkMGzsuvcIUneHPiCToO5ld1C4Z/steBxDyFO5cPyca1Cwdl2PTgCny8z5 Z4vC1A1C+U25yKdGbDFIHpsnICxA/YkCs+a4Pxz8DNGiou89QOEwfbv33lXlpVaHuDVk a/Ug== X-Gm-Message-State: ANhLgQ1HZJ1IgZ9UsDkJn5VQC9CtoUDxr7b8BTQkRqyYSqaYYVrUHgK1 s3RoDyoksP8v2cUqBNpL+YtIEHx/Bxk/Vt520zmnOG9gbb5XsDZ4kjX+PN+t5KNe9SIesvmNZXN MkZQj0i/GgSwi4n1LvbFM0eBr X-Received: by 2002:a1c:f214:: with SMTP id s20mr3089672wmc.57.1583320695926; Wed, 04 Mar 2020 03:18:15 -0800 (PST) X-Google-Smtp-Source: ADFU+vuzwSpBrWFCEylCbjzVGJupWHaIFw5613/wH2N8f6ImpbqVP4zei3xmBS7rl8UDQcyeH0dqWA== X-Received: by 2002:a1c:f214:: with SMTP id s20mr3089656wmc.57.1583320695676; Wed, 04 Mar 2020 03:18:15 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:9def:34a0:b68d:9993? ([2001:b07:6468:f312:9def:34a0:b68d:9993]) by smtp.gmail.com with ESMTPSA id o26sm3527451wmc.33.2020.03.04.03.18.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Mar 2020 03:18:14 -0800 (PST) Subject: Re: [PATCH 2/6] KVM: x86: Fix CPUID range check for Centaur and Hypervisor ranges To: Sean Christopherson , Jim Mattson Cc: Vitaly Kuznetsov , Wanpeng Li , Joerg Roedel , kvm list , LKML , Jan Kiszka , Xiaoyao Li References: <20200302195736.24777-1-sean.j.christopherson@intel.com> <20200302195736.24777-3-sean.j.christopherson@intel.com> <20200303045838.GF27842@linux.intel.com> <20200303180122.GO1439@linux.intel.com> From: Paolo Bonzini Message-ID: <41235370-c095-6d8a-2546-be88b3974bfe@redhat.com> Date: Wed, 4 Mar 2020 12:18:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200303180122.GO1439@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/03/20 19:01, Sean Christopherson wrote: > static bool cpuid_function_in_range(struct kvm_vcpu *vcpu, u32 function) > { > struct kvm_cpuid_entry2 *max; > > if (function >= 0x40000000 && function <= 0x4fffffff) > max = kvm_find_cpuid_entry(vcpu, function & 0xffffff00, 0); > else > max = kvm_find_cpuid_entry(vcpu, function & 0x80000000, 0); > return max && function <= max->eax; > } Yes, this is a good idea (except it should be & 0xc0000000 to cover Centaur). Paolo