From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Billy Tsai <billy_tsai@aspeedtech.com>,
"jdelvare@suse.com" <jdelvare@suse.com>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"joel@jms.id.au" <joel@jms.id.au>,
"andrew@aj.id.au" <andrew@aj.id.au>,
"lee@kernel.org" <lee@kernel.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
"corbet@lwn.net" <corbet@lwn.net>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: Re: [v4 1/5] dt-bindings: mfd: Add aspeed pwm-tach binding
Date: Fri, 9 Dec 2022 08:48:13 +0100 [thread overview]
Message-ID: <41500a04-b004-0e2c-20a1-3a3092b90e6d@linaro.org> (raw)
In-Reply-To: <A5EA19E5-21D8-4954-9636-9B28AC8D946A@aspeedtech.com>
On 09/12/2022 01:54, Billy Tsai wrote:
> > > However I am surprised to see such change, so I have no clue why this
> > > was done.
>
> > Actually now I see it was like that in previous patch, I just missed it
> > during previous review. Anyway this must be fixed.
>
> I have two module (PWM and TACH) but share with the same base address,
> The PWM will use the offset (N*0x10) + 0x0 and 0x04.
> The TACH will use the offset (N*0x10) + 0x8 and 0x0c.
> The range of the N is 0~15.
> Can you give me some advice to fix this problem without using simple-mfd?
Use regular driver which populates children.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-09 7:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 6:16 [v4 0/5] Support pwm/tach driver for aspeed ast26xx Billy Tsai
2022-11-23 6:16 ` [v4 1/5] dt-bindings: mfd: Add aspeed pwm-tach binding Billy Tsai
2022-11-23 8:24 ` Krzysztof Kozlowski
2022-11-23 8:27 ` Krzysztof Kozlowski
2022-12-09 0:54 ` Billy Tsai
2022-12-09 7:48 ` Krzysztof Kozlowski [this message]
2023-01-06 3:31 ` Billy Tsai
2023-06-08 6:43 ` Krzysztof Kozlowski
[not found] ` <SG2PR06MB3365AE9D075601CB62C6E7F78B50A@SG2PR06MB3365.apcprd06.prod.outlook.com>
2023-06-08 7:20 ` Krzysztof Kozlowski
2022-11-23 15:07 ` Rob Herring
2022-11-23 6:16 ` [v4 2/5] dt-bindings: pwm: Add bindings for aspeed pwm controller Billy Tsai
2022-11-23 8:30 ` Krzysztof Kozlowski
2022-11-23 15:07 ` Rob Herring
2022-11-23 6:16 ` [v4 3/5] dt-bindings: hwmon: Add bindings for aspeed tach controller Billy Tsai
2022-11-23 8:33 ` Krzysztof Kozlowski
2022-11-23 15:21 ` Guenter Roeck
2022-11-23 6:16 ` [v4 4/5] pwm: Add Aspeed ast2600 PWM support Billy Tsai
2022-11-23 8:43 ` Bagas Sanjaya
2023-04-24 10:12 ` Delphine_CC_Chiu/WYHQ/Wiwynn
2022-11-23 6:16 ` [v4 5/5] hwmon: Add Aspeed ast2600 TACH support Billy Tsai
2022-11-23 8:45 ` Bagas Sanjaya
2022-11-23 15:44 ` Guenter Roeck
2022-11-29 7:08 ` Billy Tsai
2022-11-29 15:06 ` Guenter Roeck
2023-01-17 21:48 ` [v4 0/5] Support pwm/tach driver for aspeed ast26xx Uwe Kleine-König
2023-01-18 1:48 ` Billy Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41500a04-b004-0e2c-20a1-3a3092b90e6d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@aj.id.au \
--cc=billy_tsai@aspeedtech.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).