From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751578AbdCCI4Z (ORCPT ); Fri, 3 Mar 2017 03:56:25 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:40598 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751083AbdCCI4S (ORCPT ); Fri, 3 Mar 2017 03:56:18 -0500 X-AuditID: b6c32a37-f796f6d000001a35-f3-58b92f0c4199 From: Bartlomiej Zolnierkiewicz To: Rob Herring Cc: Martin Kaiser , linux-fbdev@vger.kernel.org, Philipp Zabel , Mark Rutland , Sascha Hauer , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] video: fbdev: imxfb: support AUS mode Date: Fri, 03 Mar 2017 09:53:29 +0100 Message-id: <4163470.X1j77etRtO@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170303062130.eu5i6kcusxuodoea@rob-hp-laptop> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprKKsWRmVeSWpSXmKPExsWy7bCmgS6P/s4IgymnBS3mHznHarFq6k4W ixN9H1gtLu+aw2ax9PpFJouN7yIt7t47wWLxf88OdgcOjzXz1jB6dF3fwuKxaVUnm0f/XwOP z5vkAlijuGxSUnMyy1KL9O0SuDIetDUyFszmrli/tYO1gfEiRxcjJ4eEgInE+fVdTBC2mMSF e+vZuhi5OIQEdjBKPF34kxXCaWeSWHPoJzNMx5MPTVBVyxklmmfsZYRwvjJK3JwzgxWkik3A SmJi+ypGEFtEQFHid9s0sDizwBdGiX2tdiC2sICtxKcbB1hAbBYBVYn5Cx6A1fMKaEocW/2E DcQWFfCS2LKvHeg+Dg5OARuJGw3OECWCEj8m32OBGCkvsW//VKjxOhJnj61jhDh0E7vElh9W IK0SArISmw5A3e8iMenVblYIW1ji1fEt7BC2tMSqf7egITGdUWL7bwmQtyQENjNKrNo9AarI WuLw8YtQu/gk3n3tYYWYzyvR0SYEUeIhcfbzVqgTHCX+9n+ChtUxRonXayazTmCUn4XkhVlI XpiF5IUFjMyrGMVSC4pz01OLDQuM9YoTc4tL89L1kvNzNzGCE4uW+Q7GDed8DjEKcDAq8fBe sNkRIcSaWFZcmXuIUYKDWUmEN20vUIg3JbGyKrUoP76oNCe1+BCjNAeLkjgvq8HECCGB9MSS 1OzU1ILUIpgsEwenVAOjytmt85L/6t/7mjptpdChScU3DNf87g4+tzc4zL1ox8Rzl3+xTrz8 au3Og98PrirYbHeu07E/d8Ue/sDktFrGk3LpOszbNS7uT/9TIvQlNn+vbke/1eyElZePRvPX B8vmzrqctqaeizNf8ceuCQJ5nfFtGn82f/161vBYeLqRj86JNUEhr7OvKrEUZyQaajEXFScC AKBBFMkoAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrBIsWRmVeSWpSXmKPExsVy+t9jAV1u/Z0RBt3nFSzmHznHarFq6k4W ixN9H1gtLu+aw2ax9PpFJouN7yIt7t47wWLxf88OdgcOjzXz1jB6dF3fwuKxaVUnm0f/XwOP z5vkAlij3GwyUhNTUosUUvOS81My89JtlUJD3HQtlBTyEnNTbZUidH1DgpQUyhJzSoE8IwM0 4OAc4B6spG+X4JbxoK2RsWA2d8X6rR2sDYwXOboYOTkkBEwknnxoYoOwxSQu3FsPZHNxCAks ZZSY/fMaM0hCSOAro8S9hjgQm03ASmJi+ypGEFtEQFHid9s0VpAGZoEvjBLt8zaygiSEBWwl Pt04wAJiswioSsxf8ACsgVdAU+LY6idg20QFvCS27Gtn6mLk4OAUsJG40eAMsfgYo8T6/wuZ IeoFJX5Mvgc2h1lAXmLf/qmsELaWxPqdx5kmMArMQlI2C0nZLCRlCxiZVzFKpBYkFxQnpeca 5qWW6xUn5haX5qXrJefnbmIEx9ozqR2MB3e5H2IU4GBU4uG9YLMjQog1say4MvcQowQHs5II b9peoBBvSmJlVWpRfnxRaU5q8SFGU6AHJzJLiSbnA9NAXkm8oYm5ibmxgYW5paWJkZI4b+Ps Z+FCAumJJanZqakFqUUwfUwcnFINjI0zbwRFNSvKv3MV/pAx8Z5Z5IujT7wzhU7VFT2+uOXP g/9p19vrg5ectbz5s+LcMTO7z/+3Lr68RKVveZ2mwVmFJhYLuc9R+e6GTpvWu97QP7/FvHbB rVlBnkc2ya+btcZ69rbt3lErRTe2peTK+am/iTbNypzgtY+BYcMPj+WuebPWbXQUtVViKc5I NNRiLipOBABT612XywIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170303085331epcas1p44e290ef3d2ab305f14b20d4c466d41e1 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-HopCount: 7 X-CMS-RootMailID: 20170303062135epcas4p378b4158904ba20a06ea308331dca05ec X-RootMTR: 20170303062135epcas4p378b4158904ba20a06ea308331dca05ec References: <1488193030-13064-1-git-send-email-martin@kaiser.cx> <20170303062130.eu5i6kcusxuodoea@rob-hp-laptop> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Friday, March 03, 2017 12:21:30 AM Rob Herring wrote: > On Tue, Feb 28, 2017 at 09:04:16PM +0100, Martin Kaiser wrote: > > Some displays require setting AUS mode in the LDCD AUS Mode Control > > Register to work with the imxfb driver. Like the value of the Panel > > Configuration Register, the AUS Mode Control Register's value depends on > > the display mode. > > > > Allow setting this register from the device tree. Make the device tree > > node optional to keep the DT ABI stable. This register is available only > > on imx21 and compatible chipsets. Update the device tree bindings with > > this info. > > > > Signed-off-by: Martin Kaiser > > --- > > v2: > > re-sending DT bindings and code changes as one patch > > The opposite is what is prefered. Do you mean that you want to have code adding bindings and its documentation in separate patches (because that is like it was before)? This doesn't sound good for me from kernel changes integrity POV but if this is what you prefer I can live with that. ;) > > .../devicetree/bindings/display/imx/fsl,imx-fb.txt | 2 ++ > > drivers/video/fbdev/imxfb.c | 19 +++++++++++++++++++ > > include/linux/platform_data/video-imxfb.h | 1 + > > 3 files changed, 22 insertions(+) Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics