From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B15FC433EF for ; Fri, 11 Feb 2022 07:55:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347857AbiBKHz3 (ORCPT ); Fri, 11 Feb 2022 02:55:29 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:57096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347824AbiBKHz0 (ORCPT ); Fri, 11 Feb 2022 02:55:26 -0500 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8019FBD2 for ; Thu, 10 Feb 2022 23:55:25 -0800 (PST) Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 64A4D402B4 for ; Fri, 11 Feb 2022 07:55:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1644566123; bh=MQDLOkOWyhrokLh/q2SGFaaeI8uLaofwFWx6RTobIHo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HrXeIwAY6eAuWPnCHU6Bvme4zi3lq4IpQgUbbTCLol7Uq6drq0CtJ51s10bCuHDOJ uBYVed7mYFc9bv5sv/WnUZ/U8H7Lyz4MiIDymgAKPa6yvW3Edz59dftpIh4Y3TmxIa 45KYgpqPImxD++RxaIQOrP1o+tTzudyL2hsBw9V4BWXFg/T4Lu/JYKhbLs3IvpGqI+ rLTlcWam80xiaJuGDKfkN2pFuybuJ3VzJYBgXvuMgtot+9bd1xUmi9V2ZxNwyU864g GSZvwUL5whQaTz8yG4pyJkLDDdFVuVBArghLhfYKTEp6HMWTDopH5NJUo66MWWmnjH Wndd6a1MCdrog== Received: by mail-ed1-f72.google.com with SMTP id w3-20020a50c443000000b0040696821132so4840106edf.22 for ; Thu, 10 Feb 2022 23:55:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=MQDLOkOWyhrokLh/q2SGFaaeI8uLaofwFWx6RTobIHo=; b=jF8XIJbs3Ts2WJh+t5jNM1bFqiLq2zze226PZrzbZ/sFnUE4AL+RDklrVvqA32wm93 6hUGZEEvQk/ZCK0tQEmycUNtMhJ7gstB5Rh9AllRHWub+OZ2VqJzcc/CEc6EDXRYPVf/ VK3BzaaEHwzna23XY2tnRbcUzTlPp0V4DZPzhVRmLFNTT9wfzi1kb+yb32oEG/JQKl4b 2iL7ECvK8ciZvCAR5e/GBHKFIcGlHHx5Pbi+H8Qqw9du4ZbO14cpEOZo1H0FgcCWAAeD aTJOm1PdvcX0FzTx58tZw1wltIScm1OzTf4OHCV+kqujmaewmsTHEnnSX1HndXju3fmY yriQ== X-Gm-Message-State: AOAM532kcfcR7RSMXA3zSb7SMET/IDMmz4fMAtvn4hnIrF7eDb/12+vs L0KSOxqkD583O7nB0KNL2vfGkbGidJwecfvHcXYEwHXv5K0nshmvSyfchWYtw3oFyAXG9s2ZB3Q huGOORZCZPra/jz71Vka8qfS2UvTDVJpC3A7pCPF+jg== X-Received: by 2002:aa7:c9cf:: with SMTP id i15mr564744edt.115.1644566122416; Thu, 10 Feb 2022 23:55:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJxS2mWZknsLENYbOC1IbYB+o7Y3nGS6XqPGFBYc0O9YHzbfrvYAJgRo8QBScWMffqbdP1Uo2A== X-Received: by 2002:aa7:c9cf:: with SMTP id i15mr564724edt.115.1644566122272; Thu, 10 Feb 2022 23:55:22 -0800 (PST) Received: from [192.168.0.99] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id 27sm157401eji.66.2022.02.10.23.55.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Feb 2022 23:55:21 -0800 (PST) Message-ID: <416c07c1-c563-c72c-edfd-ae14ecf0cf13@canonical.com> Date: Fri, 11 Feb 2022 08:55:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v5 3/9] dt-bindings: memory: lpddr2: Add revision-id properties Content-Language: en-US To: Dmitry Osipenko , Julius Werner Cc: Rob Herring , linux-tegra@vger.kernel.org, Rob Herring , Jonathan Hunter , devicetree@vger.kernel.org, LKML , Thierry Reding References: <20211006224659.21434-1-digetx@gmail.com> <20211006224659.21434-4-digetx@gmail.com> <6568fd31-113f-1581-4eff-45a4a1eb4e5d@canonical.com> <20220211021739.14f3614c@dimatab> From: Krzysztof Kozlowski In-Reply-To: <20220211021739.14f3614c@dimatab> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/02/2022 00:17, Dmitry Osipenko wrote: > В Wed, 9 Feb 2022 16:32:25 -0800 > Julius Werner пишет: > > >>> I made each LPDDR2 revision-id property to correspond to a >>> dedicated MR of LPDDR, which feels okay to me to since it matches >>> h/w. >> >> I'm not super married to my solution, so if that makes things easier >> we can standardize on the two-property version as well. I mostly >> designed it my way because I thought we may one day also want to do >> something like this for the 8-byte LPDDR5 serial-id, and then it would >> get kinda cumbersome to have serial-id1 through serial-id8 all as >> separate properties. But that's also a bridge we can cross when we get >> there. >> >> My use case is in a position where we could still change this now >> without requiring backwards-compatibility. Krzysztof, would you be >> okay if I instead changed the "jedec,lpddr3" to the same thing >> "jedec,lpddr2" does -- seeing as the original patch was from me, my >> use case could handle the switch, there has never been any actual >> kernel code using the property, and it seems very unlikely that anyone >> else has silently started using the same thing in the time it's been >> in the tree? Or do we also need to go the official deprecation route >> for that? > > If you're going to use multiple cells for other properties, then indeed > will be better to keep it consistent. Yeah, LPDDR5 is a nice argument. Let's go with the array approach (so LPDDR3). Julius, Official deprecation is needed, because the property might be used also in other projects or customers. But this is not a big deal - we will just keep old property for some time. Will you send a patch for it? Best regards, Krzysztof