From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C77E8C433E0 for ; Tue, 23 Jun 2020 01:12:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F6BB2053B for ; Tue, 23 Jun 2020 01:12:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ozlabs-ru.20150623.gappssmtp.com header.i=@ozlabs-ru.20150623.gappssmtp.com header.b="k73Sz8AB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731716AbgFWBMS (ORCPT ); Mon, 22 Jun 2020 21:12:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731466AbgFWBMR (ORCPT ); Mon, 22 Jun 2020 21:12:17 -0400 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 200CEC061573 for ; Mon, 22 Jun 2020 18:12:17 -0700 (PDT) Received: by mail-pf1-x441.google.com with SMTP id z63so9294822pfb.1 for ; Mon, 22 Jun 2020 18:12:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ozlabs-ru.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=BhvtqZcJDKiaLp2sYRd1RWOIXgwIS0nWz00ZGRo01j0=; b=k73Sz8ABPKHq+ATvqFrqBb4MX3qEA1bRIEhli7DScp6sjz2muJuvehPSVTMXfup+v/ LbcxiYCb9URuDN48c1c1EMdX/5B+P1/t8Fhyqa5k684XhUnHo2Jn5mJ/Dii288xf6oM6 SSRwMRQkQXRGE9niQLRxzpRZYKhtDm5FjMGBd01zn2wnknacTOTP7CteIkoohgxk/qaV PHjg3x5rR7uGqM0yEs+nEI+s2l42nLctSeYm7n4x5XlMEWVEQyaYwXPd6oJF0l2BXYFB AB/VvV2aFApXyxb7ew/7r68NS1+TgSYmzINvBHh7xzcip0wmT0vgPQ+bGnT9v4NDM6Zo Cmbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=BhvtqZcJDKiaLp2sYRd1RWOIXgwIS0nWz00ZGRo01j0=; b=VQMvl9xdC5srcF0VrbMrUa+TAccC+jSn6Dj7gzPu/qbTAIotXcQhofGWoIIuszmfWz qwYJ5wK76L0oIua3qzFKKIIPVSVkbq2or+KAFaqQ/OzEAChnkr2PpmRkSzHYZBz+SgQR hqRSY8zBvwLTvzaEJI9DESrLDAj4CwUFb50MktIrC/Row7IAihTEXtZ4JaFm60eEgAx/ cslqJG5YhtrtDWzxdfa3ODdcL9dCq+emgioOGf4wPXOD7UQtVKIRZtJGSmTX97/c3hyI Rajs65XLMxtGx5gdEjnCSejOGP3OgU9BHssjbnpgT4c1ay5IcJIqtsehWThszbhv3m8R oJbQ== X-Gm-Message-State: AOAM531P5xW7yECsfnOSeChDxuYGw39/k5b62G2TFeZIe8EK1XBlvVpH KWirpzskVwyl8qecTX7+3/21VKP6Ac7EIw== X-Google-Smtp-Source: ABdhPJz6gza2Th1jcPu6rITsPDEk9rkuIwB+4bwcBBtSc1hwEBKvfF+bzTvKH/U/it32yNCaFsn6aQ== X-Received: by 2002:a63:461c:: with SMTP id t28mr15701205pga.316.1592874736136; Mon, 22 Jun 2020 18:12:16 -0700 (PDT) Received: from [192.168.10.94] (124-171-83-152.dyn.iinet.net.au. [124.171.83.152]) by smtp.gmail.com with ESMTPSA id c2sm11965931pgk.77.2020.06.22.18.12.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jun 2020 18:12:15 -0700 (PDT) Subject: Re: [PATCH 1/4] powerpc/pseries/iommu: Update call to ibm,query-pe-dma-windows To: Leonardo Bras Cc: Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Thiago Jung Bauermann , Ram Pai , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20200619050619.266888-1-leobras.c@gmail.com> <20200619050619.266888-2-leobras.c@gmail.com> From: Alexey Kardashevskiy Autocrypt: addr=aik@ozlabs.ru; keydata= mQINBE+rT0sBEADFEI2UtPRsLLvnRf+tI9nA8T91+jDK3NLkqV+2DKHkTGPP5qzDZpRSH6mD EePO1JqpVuIow/wGud9xaPA5uvuVgRS1q7RU8otD+7VLDFzPRiRE4Jfr2CW89Ox6BF+q5ZPV /pS4v4G9eOrw1v09lEKHB9WtiBVhhxKK1LnUjPEH3ifkOkgW7jFfoYgTdtB3XaXVgYnNPDFo PTBYsJy+wr89XfyHr2Ev7BB3Xaf7qICXdBF8MEVY8t/UFsesg4wFWOuzCfqxFmKEaPDZlTuR tfLAeVpslNfWCi5ybPlowLx6KJqOsI9R2a9o4qRXWGP7IwiMRAC3iiPyk9cknt8ee6EUIxI6 t847eFaVKI/6WcxhszI0R6Cj+N4y+1rHfkGWYWupCiHwj9DjILW9iEAncVgQmkNPpUsZECLT WQzMuVSxjuXW4nJ6f4OFHqL2dU//qR+BM/eJ0TT3OnfLcPqfucGxubhT7n/CXUxEy+mvWwnm s9p4uqVpTfEuzQ0/bE6t7dZdPBua7eYox1AQnk8JQDwC3Rn9kZq2O7u5KuJP5MfludMmQevm pHYEMF4vZuIpWcOrrSctJfIIEyhDoDmR34bCXAZfNJ4p4H6TPqPh671uMQV82CfTxTrMhGFq 8WYU2AH86FrVQfWoH09z1WqhlOm/KZhAV5FndwVjQJs1MRXD8QARAQABtCRBbGV4ZXkgS2Fy ZGFzaGV2c2tpeSA8YWlrQG96bGFicy5ydT6JAjgEEwECACIFAk+rT0sCGwMGCwkIBwMCBhUI AgkKCwQWAgMBAh4BAheAAAoJEIYTPdgrwSC5fAIP/0wf/oSYaCq9PhO0UP9zLSEz66SSZUf7 AM9O1rau1lJpT8RoNa0hXFXIVbqPPKPZgorQV8SVmYRLr0oSmPnTiZC82x2dJGOR8x4E01gK TanY53J/Z6+CpYykqcIpOlGsytUTBA+AFOpdaFxnJ9a8p2wA586fhCZHVpV7W6EtUPH1SFTQ q5xvBmr3KkWGjz1FSLH4FeB70zP6uyuf/B2KPmdlPkyuoafl2UrU8LBADi/efc53PZUAREih sm3ch4AxaL4QIWOmlE93S+9nHZSRo9jgGXB1LzAiMRII3/2Leg7O4hBHZ9Nki8/fbDo5///+ kD4L7UNbSUM/ACWHhd4m1zkzTbyRzvL8NAVQ3rckLOmju7Eu9whiPueGMi5sihy9VQKHmEOx OMEhxLRQbzj4ypRLS9a+oxk1BMMu9cd/TccNy0uwx2UUjDQw/cXw2rRWTRCxoKmUsQ+eNWEd iYLW6TCfl9CfHlT6A7Zmeqx2DCeFafqEd69DqR9A8W5rx6LQcl0iOlkNqJxxbbW3ddDsLU/Y r4cY20++WwOhSNghhtrroP+gouTOIrNE/tvG16jHs8nrYBZuc02nfX1/gd8eguNfVX/ZTHiR gHBWe40xBKwBEK2UeqSpeVTohYWGBkcd64naGtK9qHdo1zY1P55lHEc5Uhlk743PgAnOi27Q ns5zuQINBE+rT0sBEACnV6GBSm+25ACT+XAE0t6HHAwDy+UKfPNaQBNTTt31GIk5aXb2Kl/p AgwZhQFEjZwDbl9D/f2GtmUHWKcCmWsYd5M/6Ljnbp0Ti5/xi6FyfqnO+G/wD2VhGcKBId1X Em/B5y1kZVbzcGVjgD3HiRTqE63UPld45bgK2XVbi2+x8lFvzuFq56E3ZsJZ+WrXpArQXib2 hzNFwQleq/KLBDOqTT7H+NpjPFR09Qzfa7wIU6pMNF2uFg5ihb+KatxgRDHg70+BzQfa6PPA o1xioKXW1eHeRGMmULM0Eweuvpc7/STD3K7EJ5bBq8svoXKuRxoWRkAp9Ll65KTUXgfS+c0x gkzJAn8aTG0z/oEJCKPJ08CtYQ5j7AgWJBIqG+PpYrEkhjzSn+DZ5Yl8r+JnZ2cJlYsUHAB9 jwBnWmLCR3gfop65q84zLXRQKWkASRhBp4JK3IS2Zz7Nd/Sqsowwh8x+3/IUxVEIMaVoUaxk Wt8kx40h3VrnLTFRQwQChm/TBtXqVFIuv7/Mhvvcq11xnzKjm2FCnTvCh6T2wJw3de6kYjCO 7wsaQ2y3i1Gkad45S0hzag/AuhQJbieowKecuI7WSeV8AOFVHmgfhKti8t4Ff758Z0tw5Fpc BFDngh6Lty9yR/fKrbkkp6ux1gJ2QncwK1v5kFks82Cgj+DSXK6GUQARAQABiQIfBBgBAgAJ BQJPq09LAhsMAAoJEIYTPdgrwSC5NYEP/2DmcEa7K9A+BT2+G5GXaaiFa098DeDrnjmRvumJ BhA1UdZRdfqICBADmKHlJjj2xYo387sZpS6ABbhrFxM6s37g/pGPvFUFn49C47SqkoGcbeDz Ha7JHyYUC+Tz1dpB8EQDh5xHMXj7t59mRDgsZ2uVBKtXj2ZkbizSHlyoeCfs1gZKQgQE8Ffc F8eWKoqAQtn3j4nE3RXbxzTJJfExjFB53vy2wV48fUBdyoXKwE85fiPglQ8bU++0XdOr9oyy j1llZlB9t3tKVv401JAdX8EN0++ETiOovQdzE1m+6ioDCtKEx84ObZJM0yGSEGEanrWjiwsa nzeK0pJQM9EwoEYi8TBGhHC9ksaAAQipSH7F2OHSYIlYtd91QoiemgclZcSgrxKSJhyFhmLr QEiEILTKn/pqJfhHU/7R7UtlDAmFMUp7ByywB4JLcyD10lTmrEJ0iyRRTVfDrfVP82aMBXgF tKQaCxcmLCaEtrSrYGzd1sSPwJne9ssfq0SE/LM1J7VdCjm6OWV33SwKrfd6rOtvOzgadrG6 3bgUVBw+bsXhWDd8tvuCXmdY4bnUblxF2B6GOwSY43v6suugBttIyW5Bl2tXSTwP+zQisOJo +dpVG2pRr39h+buHB3NY83NEPXm1kUOhduJUA17XUY6QQCAaN4sdwPqHq938S3EmtVhsuQIN BFq54uIBEACtPWrRdrvqfwQF+KMieDAMGdWKGSYSfoEGGJ+iNR8v255IyCMkty+yaHafvzpl PFtBQ/D7Fjv+PoHdFq1BnNTk8u2ngfbre9wd9MvTDsyP/TmpF0wyyTXhhtYvE267Av4X/BQT lT9IXKyAf1fP4BGYdTNgQZmAjrRsVUW0j6gFDrN0rq2J9emkGIPvt9rQt6xGzrd6aXonbg5V j6Uac1F42ESOZkIh5cN6cgnGdqAQb8CgLK92Yc8eiCVCH3cGowtzQ2m6U32qf30cBWmzfSH0 HeYmTP9+5L8qSTA9s3z0228vlaY0cFGcXjdodBeVbhqQYseMF9FXiEyRs28uHAJEyvVZwI49 CnAgVV/n1eZa5qOBpBL+ZSURm8Ii0vgfvGSijPGbvc32UAeAmBWISm7QOmc6sWa1tobCiVmY SNzj5MCNk8z4cddoKIc7Wt197+X/X5JPUF5nQRvg3SEHvfjkS4uEst9GwQBpsbQYH9MYWq2P PdxZ+xQE6v7cNB/pGGyXqKjYCm6v70JOzJFmheuUq0Ljnfhfs15DmZaLCGSMC0Amr+rtefpA y9FO5KaARgdhVjP2svc1F9KmTUGinSfuFm3quadGcQbJw+lJNYIfM7PMS9fftq6vCUBoGu3L j4xlgA/uQl/LPneu9mcvit8JqcWGS3fO+YeagUOon1TRqQARAQABiQRsBBgBCAAgFiEEZSrP ibrORRTHQ99dhhM92CvBILkFAlq54uICGwICQAkQhhM92CvBILnBdCAEGQEIAB0WIQQIhvWx rCU+BGX+nH3N7sq0YorTbQUCWrni4gAKCRDN7sq0YorTbVVSD/9V1xkVFyUCZfWlRuryBRZm S4GVaNtiV2nfUfcThQBfF0sSW/aFkLP6y+35wlOGJE65Riw1C2Ca9WQYk0xKvcZrmuYkK3DZ 0M9/Ikkj5/2v0vxz5Z5w/9+IaCrnk7pTnHZuZqOh23NeVZGBls/IDIvvLEjpD5UYicH0wxv+ X6cl1RoP2Kiyvenf0cS73O22qSEw0Qb9SId8wh0+ClWet2E7hkjWFkQfgJ3hujR/JtwDT/8h 3oCZFR0KuMPHRDsCepaqb/k7VSGTLBjVDOmr6/C9FHSjq0WrVB9LGOkdnr/xcISDZcMIpbRm EkIQ91LkT/HYIImL33ynPB0SmA+1TyMgOMZ4bakFCEn1vxB8Ir8qx5O0lHMOiWMJAp/PAZB2 r4XSSHNlXUaWUg1w3SG2CQKMFX7vzA31ZeEiWO8tj/c2ZjQmYjTLlfDK04WpOy1vTeP45LG2 wwtMA1pKvQ9UdbYbovz92oyZXHq81+k5Fj/YA1y2PI4MdHO4QobzgREoPGDkn6QlbJUBf4To pEbIGgW5LRPLuFlOPWHmIS/sdXDrllPc29aX2P7zdD/ivHABslHmt7vN3QY+hG0xgsCO1JG5 pLORF2N5XpM95zxkZqvYfC5tS/qhKyMcn1kC0fcRySVVeR3tUkU8/caCqxOqeMe2B6yTiU1P aNDq25qYFLeYxg67D/4w/P6BvNxNxk8hx6oQ10TOlnmeWp1q0cuutccblU3ryRFLDJSngTEu ZgnOt5dUFuOZxmMkqXGPHP1iOb+YDznHmC0FYZFG2KAc9pO0WuO7uT70lL6larTQrEneTDxQ CMQLP3qAJ/2aBH6SzHIQ7sfbsxy/63jAiHiT3cOaxAKsWkoV2HQpnmPOJ9u02TPjYmdpeIfa X2tXyeBixa3i/6dWJ4nIp3vGQicQkut1YBwR7dJq67/FCV3Mlj94jI0myHT5PIrCS2S8LtWX ikTJSxWUKmh7OP5mrqhwNe0ezgGiWxxvyNwThOHc5JvpzJLd32VDFilbxgu4Hhnf6LcgZJ2c Zd44XWqUu7FzVOYaSgIvTP0hNrBYm/E6M7yrLbs3JY74fGzPWGRbBUHTZXQEqQnZglXaVB5V ZhSFtHopZnBSCUSNDbB+QGy4B/E++Bb02IBTGl/JxmOwG+kZUnymsPvTtnNIeTLHxN/H/ae0 c7E5M+/NpslPCmYnDjs5qg0/3ihh6XuOGggZQOqrYPC3PnsNs3NxirwOkVPQgO6mXxpuifvJ DG9EMkK8IBXnLulqVk54kf7fE0jT/d8RTtJIA92GzsgdK2rpT1MBKKVffjRFGwN7nQVOzi4T XrB5p+6ML7Bd84xOEGsj/vdaXmz1esuH7BOZAGEZfLRCHJ0GVCSssg== Message-ID: <4176ea2b-c778-2f59-ba57-7339b873ead5@ozlabs.ru> Date: Tue, 23 Jun 2020 11:12:10 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/06/2020 04:58, Leonardo Bras wrote: > Hello Alexey, thank you for the feedback! > > On Mon, 2020-06-22 at 20:02 +1000, Alexey Kardashevskiy wrote: >> >> On 19/06/2020 15:06, Leonardo Bras wrote: >>> From LoPAR level 2.8, "ibm,ddw-extensions" index 3 can make the number of >>> outputs from "ibm,query-pe-dma-windows" go from 5 to 6. >>> >>> This change of output size is meant to expand the address size of >>> largest_available_block PE TCE from 32-bit to 64-bit, which ends up >>> shifting page_size and migration_capable. >>> >>> This ends up requiring the update of >>> ddw_query_response->largest_available_block from u32 to u64, and manually >>> assigning the values from the buffer into this struct, according to >>> output size. >>> >>> Signed-off-by: Leonardo Bras >>> --- >>> arch/powerpc/platforms/pseries/iommu.c | 57 +++++++++++++++++++++----- >>> 1 file changed, 46 insertions(+), 11 deletions(-) >>> >>> diff --git a/arch/powerpc/platforms/pseries/iommu.c b/arch/powerpc/platforms/pseries/iommu.c >>> index 6d47b4a3ce39..e5a617738c8b 100644 >>> --- a/arch/powerpc/platforms/pseries/iommu.c >>> +++ b/arch/powerpc/platforms/pseries/iommu.c >>> @@ -334,7 +334,7 @@ struct direct_window { >>> /* Dynamic DMA Window support */ >>> struct ddw_query_response { >>> u32 windows_available; >>> - u32 largest_available_block; >>> + u64 largest_available_block; >>> u32 page_size; >>> u32 migration_capable; >>> }; >>> @@ -869,14 +869,32 @@ static int find_existing_ddw_windows(void) >>> } >>> machine_arch_initcall(pseries, find_existing_ddw_windows); >>> >>> +/* >>> + * From LoPAR level 2.8, "ibm,ddw-extensions" index 3 can rule how many output >>> + * parameters ibm,query-pe-dma-windows will have, ranging from 5 to 6. >>> + */ >>> + >>> +static int query_ddw_out_sz(struct device_node *par_dn) >> >> Can easily be folded into query_ddw(). > > Sure, but it will get inlined by the compiler, and I think it reads > better this way. > I mean, I understand you have a reason to think it's better to fold it > in query_ddw(), and I would like to better understand that to improve > my code in the future. You have numbers 5 and 6 (the number of parameters) twice in the file, this is why I brought it up. query_ddw_out_sz() can potentially return something else than 5 or 6 and you will have to change the callsite(s) then, since these are not macros, this allows to think there may be more places with 5 and 6. Dunno. A single function will simplify things imho. > >>> +{ >>> + int ret; >>> + u32 ddw_ext[3]; >>> + >>> + ret = of_property_read_u32_array(par_dn, "ibm,ddw-extensions", >>> + &ddw_ext[0], 3); >>> + if (ret || ddw_ext[0] < 2 || ddw_ext[2] != 1) >> >> Oh that PAPR thing again :-/ >> >> === >> The “ibm,ddw-extensions” property value is a list of integers the first >> integer indicates the number of extensions implemented and subsequent >> integers, one per extension, provide a value associated with that >> extension. >> === >> >> So ddw_ext[0] is length. >> Listindex==2 is for "reset" says PAPR and >> Listindex==3 is for this new 64bit "largest_available_block". >> >> So I'd expect ddw_ext[2] to have the "reset" token and ddw_ext[3] to >> have "1" for this new feature but indexes are smaller. I am confused. >> Either way these "2" and "3" needs to be defined in macros, "0" probably >> too. > > Remember these indexes are not C-like 0-starting indexes, where the > size would be Listindex==1. Yeah I can see that is the assumption but out of curiosity - is it written anywhere? Across PAPR, they index bytes from 1 but bits from 0 :-/ Either way make them macros. > Basically, in C-like array it's : > a[0] == size, > a[1] == reset_token, > a[2] == new 64bit "largest_available_block" > >> Please post 'lsprop "ibm,ddw-extensions"' here. Thanks, > > Sure: > [root@host pci@800000029004005]# lsprop "ibm,ddw-extensions" > ibm,dd > w-extensions > 00000002 00000056 00000000 Right, good. Thanks, > > >> >>> + return 5; >>> + return 6; >>> +} >>> + >>> static int query_ddw(struct pci_dev *dev, const u32 *ddw_avail, >>> - struct ddw_query_response *query) >>> + struct ddw_query_response *query, >>> + struct device_node *par_dn) >>> { >>> struct device_node *dn; >>> struct pci_dn *pdn; >>> - u32 cfg_addr; >>> + u32 cfg_addr, query_out[5]; >>> u64 buid; >>> - int ret; >>> + int ret, out_sz; >>> >>> /* >>> * Get the config address and phb buid of the PE window. >>> @@ -888,12 +906,29 @@ static int query_ddw(struct pci_dev *dev, const u32 *ddw_avail, >>> pdn = PCI_DN(dn); >>> buid = pdn->phb->buid; >>> cfg_addr = ((pdn->busno << 16) | (pdn->devfn << 8)); >>> + out_sz = query_ddw_out_sz(par_dn); >>> + >>> + ret = rtas_call(ddw_avail[0], 3, out_sz, query_out, >>> + cfg_addr, BUID_HI(buid), BUID_LO(buid)); >>> + dev_info(&dev->dev, "ibm,query-pe-dma-windows(%x) %x %x %x returned %d\n", >>> + ddw_avail[0], cfg_addr, BUID_HI(buid), BUID_LO(buid), ret); >>> + >>> + switch (out_sz) { >>> + case 5: >>> + query->windows_available = query_out[0]; >>> + query->largest_available_block = query_out[1]; >>> + query->page_size = query_out[2]; >>> + query->migration_capable = query_out[3]; >>> + break; >>> + case 6: >>> + query->windows_available = query_out[0]; >>> + query->largest_available_block = ((u64)query_out[1] << 32) | >>> + query_out[2]; >>> + query->page_size = query_out[3]; >>> + query->migration_capable = query_out[4]; >>> + break; >>> + } >>> >>> - ret = rtas_call(ddw_avail[0], 3, 5, (u32 *)query, >>> - cfg_addr, BUID_HI(buid), BUID_LO(buid)); >>> - dev_info(&dev->dev, "ibm,query-pe-dma-windows(%x) %x %x %x" >>> - " returned %d\n", ddw_avail[0], cfg_addr, BUID_HI(buid), >>> - BUID_LO(buid), ret); >>> return ret; >>> } >>> >>> @@ -1040,7 +1075,7 @@ static u64 enable_ddw(struct pci_dev *dev, struct device_node *pdn) >>> * of page sizes: supported and supported for migrate-dma. >>> */ >>> dn = pci_device_to_OF_node(dev); >>> - ret = query_ddw(dev, ddw_avail, &query); >>> + ret = query_ddw(dev, ddw_avail, &query, pdn); >>> if (ret != 0) >>> goto out_failed; >>> >>> @@ -1068,7 +1103,7 @@ static u64 enable_ddw(struct pci_dev *dev, struct device_node *pdn) >>> /* check largest block * page size > max memory hotplug addr */ >>> max_addr = ddw_memory_hotplug_max(); >>> if (query.largest_available_block < (max_addr >> page_shift)) { >>> - dev_dbg(&dev->dev, "can't map partition max 0x%llx with %u " >>> + dev_dbg(&dev->dev, "can't map partition max 0x%llx with %llu " >>> "%llu-sized pages\n", max_addr, query.largest_available_block, >>> 1ULL << page_shift); >>> goto out_failed; >>> > > Best regards, > Leonardo > -- Alexey