From: Mikko Perttunen <cyndis@kapsi.fi>
To: Jon Hunter <jonathanh@nvidia.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Thierry Reding <thierry.reding@gmail.com>
Cc: Mikko Perttunen <mperttunen@nvidia.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] reset: tegra-bpmp: Revert Handle errors in BPMP response
Date: Mon, 15 Nov 2021 19:21:39 +0200 [thread overview]
Message-ID: <417a93fd-7581-1d33-1522-31f05ca253b9@kapsi.fi> (raw)
In-Reply-To: <20211112112712.21587-1-jonathanh@nvidia.com>
On 11/12/21 1:27 PM, Jon Hunter wrote:
> Commit c045ceb5a145 ("reset: tegra-bpmp: Handle errors in BPMP
> response") fixed an issue in the Tegra BPMP error handling but has
> exposed an issue in the Tegra194 HDA driver and now resetting the
> Tegra194 HDA controller is failing. For now revert the commit
> c045ceb5a145 ("reset: tegra-bpmp: Handle errors in BPMP response")
> while a fix for the Tegra HDA driver is created.
>
> Fixes: c045ceb5a145 ("reset: tegra-bpmp: Handle errors in BPMP response")
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> drivers/reset/tegra/reset-bpmp.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/reset/tegra/reset-bpmp.c b/drivers/reset/tegra/reset-bpmp.c
> index 4c5bba52b105..24d3395964cc 100644
> --- a/drivers/reset/tegra/reset-bpmp.c
> +++ b/drivers/reset/tegra/reset-bpmp.c
> @@ -20,7 +20,6 @@ static int tegra_bpmp_reset_common(struct reset_controller_dev *rstc,
> struct tegra_bpmp *bpmp = to_tegra_bpmp(rstc);
> struct mrq_reset_request request;
> struct tegra_bpmp_message msg;
> - int err;
>
> memset(&request, 0, sizeof(request));
> request.cmd = command;
> @@ -31,13 +30,7 @@ static int tegra_bpmp_reset_common(struct reset_controller_dev *rstc,
> msg.tx.data = &request;
> msg.tx.size = sizeof(request);
>
> - err = tegra_bpmp_transfer(bpmp, &msg);
> - if (err)
> - return err;
> - if (msg.rx.ret)
> - return -EINVAL;
> -
> - return 0;
> + return tegra_bpmp_transfer(bpmp, &msg);
> }
>
> static int tegra_bpmp_reset_module(struct reset_controller_dev *rstc,
>
Is there some reason the subject and commit message does not follow
normal revert convention (as done by 'git revert')?
Mikko
next prev parent reply other threads:[~2021-11-15 18:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 11:27 [PATCH] reset: tegra-bpmp: Revert Handle errors in BPMP response Jon Hunter
2021-11-15 17:21 ` Mikko Perttunen [this message]
2021-11-15 18:09 ` Jon Hunter
2021-11-17 16:23 ` Philipp Zabel
2021-12-06 11:37 ` Jon Hunter
2021-12-06 14:23 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=417a93fd-7581-1d33-1522-31f05ca253b9@kapsi.fi \
--to=cyndis@kapsi.fi \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=p.zabel@pengutronix.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).