linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [Cocci] coccinelle issues
@ 2020-06-14 16:12 Markus Elfring
  0 siblings, 0 replies; 4+ messages in thread
From: Markus Elfring @ 2020-06-14 16:12 UTC (permalink / raw)
  To: Julia Lawall, Randy Dunlap; +Cc: cocci, linux-kernel

> > Note2: https://github.com/coccinelle/coccinelle/blob/master/install.txt
> > says that 'spatch' is a script, but it seems to be a binary executable file.
>
> Actually, it is a script, and the fact that you say it is a binary may be
> the reason for your python problem.  Normally there is a script
> (scripts/spatch) that make install puts in place that refers back to where
> your Coccinelle is installed.

I suggest to take another look at the corresponding software development history.
The build infrastructures were occasionally updated in the meantime.

elfring@Sonne:~> SP=$(which spatch) && file $SP && du -h $SP
/usr/local/bin/spatch: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 3.2.0, with debug_info, not stripped
16M	/usr/local/bin/spatch

Regards,
Markus

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Cocci] coccinelle issues
  2020-06-14 14:40   ` Randy Dunlap
@ 2020-06-14 15:20     ` Julia Lawall
  0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2020-06-14 15:20 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: LKML, cocci



On Sun, 14 Jun 2020, Randy Dunlap wrote:

> On 6/14/20 12:39 AM, Julia Lawall wrote:
> >
> >
> > On Sat, 13 Jun 2020, Randy Dunlap wrote:
> >
> >> Hi,
> >>
> >> OK, I've not used Coccinelle and now I am trying to use it.
> >> It seems that I am having a few issues.
> >> The primary one is when I run spatch (via 'make coccicheck' in
> >> the kernel source tree), it tells me:
> >>
> >> Python error: No module named coccilib.elems
> >>
> >> I do see "elems.py" in /usr/local/lib64/coccinelle/python/coccilib.
> >>
> >> I am using coccinelle-master downloaded from github on
> >> Friday June 12, 2020.
> >>
> >>
> >> I have also made the following notes while building/installing it.
> >>
> >>
> >> Note1: The latest coccinelle tarball is not actually available
> >> at the coccinelle home page although the kernel documentation says it is.
> >
> > Yes, I'm aware of this problem.  We're not able to update the home page at
> > the moment.  This problem is being worked on.
> >
> >>
> >> Note2: https://github.com/coccinelle/coccinelle/blob/master/install.txt
> >> says that 'spatch' is a script, but it seems to be a binary executable
> >> file.
> >
> > Actually, it is a script, and the fact that you say it is a binary may be
> > the reason for your python problem.  Normally there is a script
> > (scripts/spatch) that make install puts in place that refers back to where
> > your Coccinelle is installed.
>
> Yes, I saw scripts/spatch, but that script is not what is installed in
> /usr/local/bin.
> (see more below)

OK.  I don't install Coccinelle in the normal way.  I will check on what
is intended.

>
> >> Note3: https://github.com/coccinelle/coccinelle/blob/master/install.txt
> >> probably should say to use 'sudo make install' instead of just
> >> 'make install', just like 'coccinelle.rst' file in the kernel tree says.
> >
> > OK.  A lot of documentation for a lot of projects seems to omit the sudo,
> > but I have indeed never understood why.
> >
> > Maybe try again with make distclean, ./autogen, ./configure, sudo make
> > install?
>
> OK, I did all of those.
>
> Is this expected?
>
> $ ./autogen
> cat: VERSION: No such file or directory
> cat: VERSION: No such file or directory
> cat: VERSION: No such file or directory
> cat: VERSION: No such file or directory
> cat: VERSION: No such file or directory
> cat: VERSION: No such file or directory
> cat: VERSION: No such file or directory
> cat: VERSION: No such file or directory
> cat: VERSION: No such file or directory
> cat: VERSION: No such file or directory
> cat: VERSION: No such file or directory

Sorry.  This problem has no impact, but I just pushed a commit to github
to solve it.

julia

>
>
> spatch is installed in /usr/local/bin/spatch:
>
> $ ll /usr/local/bin/spatch
> -rwxr-xr-x 1 root root 15547736 Jun 14 07:32 /usr/local/bin/spatch*
>
> $ file /usr/local/bin/spatch
> /usr/local/bin/spatch: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/l, BuildID[sha1]=2b658c12a1a49deae24010b71d22d262988ce041, for GNU/Linux 3.2.0, with debug_info, not stripped
>
>
> I still get this runtime error:
>
> Python error: No module named coccilib.elems
>
> --
> ~Randy
>
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Cocci] coccinelle issues
  2020-06-14  7:39 ` [Cocci] " Julia Lawall
@ 2020-06-14 14:40   ` Randy Dunlap
  2020-06-14 15:20     ` Julia Lawall
  0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2020-06-14 14:40 UTC (permalink / raw)
  To: Julia Lawall; +Cc: LKML, cocci

On 6/14/20 12:39 AM, Julia Lawall wrote:
> 
> 
> On Sat, 13 Jun 2020, Randy Dunlap wrote:
> 
>> Hi,
>>
>> OK, I've not used Coccinelle and now I am trying to use it.
>> It seems that I am having a few issues.
>> The primary one is when I run spatch (via 'make coccicheck' in
>> the kernel source tree), it tells me:
>>
>> Python error: No module named coccilib.elems
>>
>> I do see "elems.py" in /usr/local/lib64/coccinelle/python/coccilib.
>>
>> I am using coccinelle-master downloaded from github on
>> Friday June 12, 2020.
>>
>>
>> I have also made the following notes while building/installing it.
>>
>>
>> Note1: The latest coccinelle tarball is not actually available
>> at the coccinelle home page although the kernel documentation says it is.
> 
> Yes, I'm aware of this problem.  We're not able to update the home page at
> the moment.  This problem is being worked on.
> 
>>
>> Note2: https://github.com/coccinelle/coccinelle/blob/master/install.txt
>> says that 'spatch' is a script, but it seems to be a binary executable
>> file.
> 
> Actually, it is a script, and the fact that you say it is a binary may be
> the reason for your python problem.  Normally there is a script
> (scripts/spatch) that make install puts in place that refers back to where
> your Coccinelle is installed.

Yes, I saw scripts/spatch, but that script is not what is installed in
/usr/local/bin.
(see more below)

>> Note3: https://github.com/coccinelle/coccinelle/blob/master/install.txt
>> probably should say to use 'sudo make install' instead of just
>> 'make install', just like 'coccinelle.rst' file in the kernel tree says.
> 
> OK.  A lot of documentation for a lot of projects seems to omit the sudo,
> but I have indeed never understood why.
> 
> Maybe try again with make distclean, ./autogen, ./configure, sudo make
> install?

OK, I did all of those.

Is this expected?

$ ./autogen
cat: VERSION: No such file or directory
cat: VERSION: No such file or directory
cat: VERSION: No such file or directory
cat: VERSION: No such file or directory
cat: VERSION: No such file or directory
cat: VERSION: No such file or directory
cat: VERSION: No such file or directory
cat: VERSION: No such file or directory
cat: VERSION: No such file or directory
cat: VERSION: No such file or directory
cat: VERSION: No such file or directory


spatch is installed in /usr/local/bin/spatch:

$ ll /usr/local/bin/spatch
-rwxr-xr-x 1 root root 15547736 Jun 14 07:32 /usr/local/bin/spatch*

$ file /usr/local/bin/spatch
/usr/local/bin/spatch: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/l, BuildID[sha1]=2b658c12a1a49deae24010b71d22d262988ce041, for GNU/Linux 3.2.0, with debug_info, not stripped


I still get this runtime error:

Python error: No module named coccilib.elems

-- 
~Randy


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Cocci] coccinelle issues
  2020-06-14  4:07 Randy Dunlap
@ 2020-06-14  7:39 ` Julia Lawall
  2020-06-14 14:40   ` Randy Dunlap
  0 siblings, 1 reply; 4+ messages in thread
From: Julia Lawall @ 2020-06-14  7:39 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: LKML, cocci



On Sat, 13 Jun 2020, Randy Dunlap wrote:

> Hi,
>
> OK, I've not used Coccinelle and now I am trying to use it.
> It seems that I am having a few issues.
> The primary one is when I run spatch (via 'make coccicheck' in
> the kernel source tree), it tells me:
>
> Python error: No module named coccilib.elems
>
> I do see "elems.py" in /usr/local/lib64/coccinelle/python/coccilib.
>
> I am using coccinelle-master downloaded from github on
> Friday June 12, 2020.
>
>
> I have also made the following notes while building/installing it.
>
>
> Note1: The latest coccinelle tarball is not actually available
> at the coccinelle home page although the kernel documentation says it is.

Yes, I'm aware of this problem.  We're not able to update the home page at
the moment.  This problem is being worked on.

>
> Note2: https://github.com/coccinelle/coccinelle/blob/master/install.txt
> says that 'spatch' is a script, but it seems to be a binary executable
> file.

Actually, it is a script, and the fact that you say it is a binary may be
the reason for your python problem.  Normally there is a script
(scripts/spatch) that make install puts in place that refers back to where
your Coccinelle is installed.

> Note3: https://github.com/coccinelle/coccinelle/blob/master/install.txt
> probably should say to use 'sudo make install' instead of just
> 'make install', just like 'coccinelle.rst' file in the kernel tree says.

OK.  A lot of documentation for a lot of projects seems to omit the sudo,
but I have indeed never understood why.

Maybe try again with make distclean, ./autogen, ./configure, sudo make
install?

julia

>
> thanks for any help that you can provide.
>
> --
> ~Randy
>
> _______________________________________________
> Cocci mailing list
> Cocci@systeme.lip6.fr
> https://systeme.lip6.fr/mailman/listinfo/cocci
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-06-14 16:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-14 16:12 [Cocci] coccinelle issues Markus Elfring
  -- strict thread matches above, loose matches on Subject: below --
2020-06-14  4:07 Randy Dunlap
2020-06-14  7:39 ` [Cocci] " Julia Lawall
2020-06-14 14:40   ` Randy Dunlap
2020-06-14 15:20     ` Julia Lawall

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).