From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A81B5C4727C for ; Wed, 30 Sep 2020 22:06:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6FF22206CA for ; Wed, 30 Sep 2020 22:06:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731322AbgI3WG4 (ORCPT ); Wed, 30 Sep 2020 18:06:56 -0400 Received: from smtprelay0109.hostedemail.com ([216.40.44.109]:49994 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730269AbgI3WG4 (ORCPT ); Wed, 30 Sep 2020 18:06:56 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id B223A100E7B43; Wed, 30 Sep 2020 22:06:54 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: river77_3d14b8027196 X-Filterd-Recvd-Size: 4026 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf04.hostedemail.com (Postfix) with ESMTPA; Wed, 30 Sep 2020 22:06:52 +0000 (UTC) Message-ID: <417ffa3fd3fba5d4a481db6a0b0c9b48cbbb17c4.camel@perches.com> Subject: Re: [RFC PATCH next-20200930] treewide: Convert macro and uses of __section(foo) to __section("foo") From: Joe Perches To: Nick Desaulniers Cc: Sedat Dilek , "Paul E . McKenney" , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Josh Triplett , Kees Cook , LKML , rcu@vger.kernel.org, Clang-Built-Linux ML , Miguel Ojeda , Michael Ellerman Date: Wed, 30 Sep 2020 15:06:51 -0700 In-Reply-To: References: <20200929192549.501516-1-ndesaulniers@google.com> <133589afbe999347454dfcc46ae782897bf9e3a2.camel@perches.com> <46f69161e60b802488ba8c8f3f8bbf922aa3b49b.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-09-30 at 14:40 -0700, Nick Desaulniers wrote: > On Wed, Sep 30, 2020 at 12:16 PM Joe Perches wrote: > > Use a more generic form for __section that requires quotes to avoid > > complications with clang and gcc differences. > > > > Remove the quote operator # from compiler_attributes.h __section macro. > > > > Convert all unquoted __section(foo) uses to quoted __section("foo"). > > Also convert __attribute__((section("foo"))) uses to __section("foo") > > even if the __attribute__ has multiple list entry forms. > > > > Signed-off-by: Joe Perches > > --- > > > > This is the current output from the script against next-20200930 > > attached in this link: > > > > https://lore.kernel.org/lkml/0e582a7f5144a33f465978d97701f9b3dcc377f3.camel@perches.com/ > > > > It might be useful to run the script immediately before > > the next -rc1. > > $ ARCH=powerpc CROSS_COMPILE=powerpc64le-linux-gnu- make CC=clang -j71 > powernv_defconfig > $ ARCH=powerpc CROSS_COMPILE=powerpc64le-linux-gnu- make CC=clang -j71 > ... > arch/powerpc/boot/main.c:193:44: error: expected ';' after top level declarator > static char cmdline[BOOT_COMMAND_LINE_SIZE] The script does not convert files in scripts/ tools/ uapi/ and include/linux/compiler_attributes.h It otherwise assumes that any __attribute__((__section__ use should be converted to __section. If this ppc file is the only file outside of the listed exclusions, I can either exclude it directly or add compiler.h to it. You have a preference? Perhaps these are also possible files that need exclusions: ./arch/x86/boot/video.h:#define __videocard struct card_info __section(".videocards") __attribute__((used)) ./arch/x86/boot/compressed/pgtable_64.c:unsigned long *trampoline_32bit __section(".data"); ./arch/x86/boot/tty.c:static void __section(".inittext") serial_putchar(int ch) ./arch/x86/boot/tty.c:static void __section(".inittext") bios_putchar(int ch) ./arch/x86/boot/tty.c:void __section(".inittext") putchar(int ch) ./arch/x86/boot/tty.c:void __section(".inittext") puts(const char *str) ./arch/s390/boot/startup.c:static struct diag210 _diag210_tmp_dma __section(".dma.data"); ./arch/powerpc/boot/main.c: __section("__builtin_cmdline"); ./arch/powerpc/boot/ps3.c: __section("__builtin_cmdline");