From: John Garry <john.garry@huawei.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
<peterz@infradead.org>, <mingo@redhat.com>,
<alexander.shishkin@linux.intel.com>, <jolsa@redhat.com>,
<namhyung@kernel.org>, <mark.rutland@arm.com>, <will@kernel.org>
Cc: <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Linuxarm <linuxarm@huawei.com>,
"linux-perf-users@vger.kernel.org"
<linux-perf-users@vger.kernel.org>
Subject: perf top for arm64?
Date: Tue, 10 Dec 2019 16:13:49 +0000 [thread overview]
Message-ID: <418023e7-a50d-cb6f-989f-2e6d114ce5d8@huawei.com> (raw)
In-Reply-To: <20191106140036.GA6259@kernel.org>
Hi all,
I find to my surprise that "perf top" does not work for arm64:
root@ubuntu:/home/john/linux# tools/perf/perf top
Couldn't read the cpuid for this machine: No such file or directory
That's v5.5-rc1 release.
It seems that we are just missing an arm64 version of get_cpuid() - with
the patch below, I now get as hoped:
PerfTop: 32857 irqs/sec kernel:85.0% exact: 0.0% lost: 0/0
drop: 0/0 [4000Hz cycles], (all, 64 CPUs)
-------------------------------------------------------------------------------
8.99% [kernel] [k] arm_smmu_cmdq_issue_cmdlist
5.80% [kernel] [k] __softirqentry_text_start
4.49% [kernel] [k] _raw_spin_unlock_irqrestore
3.48% [kernel] [k] el0_svc_common.constprop.2
3.37% [kernel] [k] _raw_write_lock_irqsave
3.28% [kernel] [k] __local_bh_enable_ip
3.05% [kernel] [k] __blk_complete_request
2.07% [kernel] [k] queued_spin_lock_slowpath
1.93% [vdso] [.] 0x0000000000000484
Was this just missed? Or is there a good reason to omit?
Thanks,
John
--->8---
Subject: [PATCH] perf: Add perf top support for arm64
Copied from get_cpuid_str() essentially...
Signed-off-by: John Garry <john.garry@huawei.com>
diff --git a/tools/perf/arch/arm64/util/header.c
b/tools/perf/arch/arm64/util/header.c
index a32e4b72a98f..ecd1f86e29cc 100644
--- a/tools/perf/arch/arm64/util/header.c
+++ b/tools/perf/arch/arm64/util/header.c
@@ -1,10 +1,12 @@
#include <stdio.h>
#include <stdlib.h>
#include <perf/cpumap.h>
+#include <util/cpumap.h>
#include <internal/cpumap.h>
#include <api/fs/fs.h>
#include "debug.h"
#include "header.h"
+#include <errno.h>
#define MIDR "/regs/identification/midr_el1"
#define MIDR_SIZE 19
@@ -12,6 +14,59 @@
#define MIDR_VARIANT_SHIFT 20
#define MIDR_VARIANT_MASK (0xf << MIDR_VARIANT_SHIFT)
+int
+get_cpuid(char *buffer, size_t sz)
+{
+ char *buf = NULL;
+ char path[PATH_MAX];
+ const char *sysfs = sysfs__mountpoint();
+ int cpu;
+ u64 midr = 0;
+ FILE *file;
+
+ if (!sysfs)
+ return EINVAL;
+
+ buf = malloc(MIDR_SIZE);
+ if (!buf)
+ return EINVAL;
+
+ /* read midr from list of cpus mapped to this pmu */
+ for (cpu = 0; cpu < cpu__max_present_cpu(); cpu++) {
+ scnprintf(path, sz, "%s/devices/system/cpu/cpu%d"MIDR,
+ sysfs, cpu);
+
+ file = fopen(path, "r");
+ if (!file) {
+ pr_debug("fopen failed for file %s\n", path);
+ continue;
+ }
+
+ if (!fgets(buf, MIDR_SIZE, file)) {
+ fclose(file);
+ continue;
+ }
+ fclose(file);
+
+ /* Ignore/clear Variant[23:20] and
+ * Revision[3:0] of MIDR
+ */
+ midr = strtoul(buf, NULL, 16);
+ midr &= (~(MIDR_VARIANT_MASK | MIDR_REVISION_MASK));
+ scnprintf(buffer, MIDR_SIZE, "0x%016lx", midr);
+ /* got midr break loop */
+ break;
+ }
+
+ if (!midr) {
+ pr_err("failed to get cpuid string\n");
+ free(buf);
+ return EINVAL;
+ }
+ return 0;
+}
+
next prev parent reply other threads:[~2019-12-10 16:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 13:00 [RFC PATCH] perf tools: Fix cross compile for ARM64 John Garry
2019-11-06 14:00 ` Arnaldo Carvalho de Melo
2019-12-10 16:13 ` John Garry [this message]
2019-12-10 16:36 ` perf top for arm64? Jiri Olsa
2019-12-10 16:52 ` John Garry
2019-12-10 17:08 ` Jiri Olsa
2019-12-10 17:17 ` John Garry
2019-12-10 19:51 ` Arnaldo Carvalho de Melo
2019-12-11 13:33 ` [PATCHES] Fix 'perf top' breakage on architectures not providing get_cpuid() " Arnaldo Carvalho de Melo
2019-12-11 14:46 ` Mark Rutland
2019-12-11 15:28 ` Arnaldo Carvalho de Melo
2019-12-11 14:50 ` John Garry
2019-12-11 14:54 ` Jiri Olsa
2019-12-11 1:48 ` Joakim Zhang
2019-12-11 2:36 ` Zenghui Yu
2019-12-10 19:48 ` Arnaldo Carvalho de Melo
2019-11-12 11:17 ` [tip: perf/core] perf tools: Fix cross compile for ARM64 tip-bot2 for John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=418023e7-a50d-cb6f-989f-2e6d114ce5d8@huawei.com \
--to=john.garry@huawei.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnaldo.melo@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).