From: Neil Armstrong <narmstrong@baylibre.com>
To: Yue Haibing <yuehaibing@huawei.com>,
airlied@linux.ie, daniel@ffwll.ch, khilman@baylibre.com
Cc: linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH -next] drm/meson: Make some functions static
Date: Wed, 17 Apr 2019 20:26:33 +0200 [thread overview]
Message-ID: <4195f74e-a531-c216-534f-a56786b88ce6@baylibre.com> (raw)
In-Reply-To: <5CB5BB43.5040007@baylibre.com>
On 16/04/2019 13:23, Neil Armstrong wrote:
>
>
> Le 13/04/2019 16:14, Yue Haibing a écrit :
>> From: YueHaibing <yuehaibing@huawei.com>
>>
>> Fix sparse warnings:
>>
>> drivers/gpu/drm/meson/meson_viu.c:93:6: warning: symbol 'meson_viu_set_g12a_osd1_matrix' was not declared. Should it be static?
>> drivers/gpu/drm/meson/meson_viu.c:121:6: warning: symbol 'meson_viu_set_osd_matrix' was not declared. Should it be static?
>> drivers/gpu/drm/meson/meson_viu.c:190:6: warning: symbol 'meson_viu_set_osd_lut' was not declared. Should it be static?
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> drivers/gpu/drm/meson/meson_viu.c | 16 ++++++++--------
>> 1 file changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/meson/meson_viu.c b/drivers/gpu/drm/meson/meson_viu.c
>> index 0169c98..b590723 100644
>> --- a/drivers/gpu/drm/meson/meson_viu.c
>> +++ b/drivers/gpu/drm/meson/meson_viu.c
>> @@ -90,8 +90,8 @@ static int eotf_bypass_coeff[EOTF_COEFF_SIZE] = {
>> EOTF_COEFF_RIGHTSHIFT /* right shift */
>> };
>>
>> -void meson_viu_set_g12a_osd1_matrix(struct meson_drm *priv, int *m,
>> - bool csc_on)
>> +static void meson_viu_set_g12a_osd1_matrix(struct meson_drm *priv,
>> + int *m, bool csc_on)
>> {
>> /* VPP WRAP OSD1 matrix */
>> writel(((m[0] & 0xfff) << 16) | (m[1] & 0xfff),
>> @@ -118,8 +118,8 @@ void meson_viu_set_g12a_osd1_matrix(struct meson_drm *priv, int *m,
>> priv->io_base + _REG(VPP_WRAP_OSD1_MATRIX_EN_CTRL));
>> }
>>
>> -void meson_viu_set_osd_matrix(struct meson_drm *priv,
>> - enum viu_matrix_sel_e m_select,
>> +static void meson_viu_set_osd_matrix(struct meson_drm *priv,
>> + enum viu_matrix_sel_e m_select,
>> int *m, bool csc_on)
>> {
>> if (m_select == VIU_MATRIX_OSD) {
>> @@ -187,10 +187,10 @@ void meson_viu_set_osd_matrix(struct meson_drm *priv,
>> #define OSD_EOTF_LUT_SIZE 33
>> #define OSD_OETF_LUT_SIZE 41
>>
>> -void meson_viu_set_osd_lut(struct meson_drm *priv, enum viu_lut_sel_e lut_sel,
>> - unsigned int *r_map, unsigned int *g_map,
>> - unsigned int *b_map,
>> - bool csc_on)
>> +static void
>> +meson_viu_set_osd_lut(struct meson_drm *priv, enum viu_lut_sel_e lut_sel,
>> + unsigned int *r_map, unsigned int *g_map,
>> + unsigned int *b_map, bool csc_on)
>> {
>> unsigned int addr_port;
>> unsigned int data_port;
>>
>
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
>
Applied to drm-misc-next, thanks
prev parent reply other threads:[~2019-04-17 18:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-13 14:14 [PATCH -next] drm/meson: Make some functions static Yue Haibing
2019-04-16 11:23 ` Neil Armstrong
2019-04-17 18:26 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4195f74e-a531-c216-534f-a56786b88ce6@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).