From: Badari Pulavarty <pbadari@us.ibm.com>
To: Hariprasad Nellitheertha <hari@in.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, Vara Prasad <varap@us.ibm.com>
Subject: Re: [PATCH] kdump: Fix for boot problems on SMP
Date: Thu, 18 Nov 2004 07:34:53 -0800 [thread overview]
Message-ID: <419CC11D.7040303@us.ibm.com> (raw)
In-Reply-To: <419CACE2.7060408@in.ibm.com>
Hari,
Tested the patch on my 4-way P-III (where it was hanging earlier)
and it works fine for me.
Thanks,
Badari
Hariprasad Nellitheertha wrote:
> Hi Andrew,
>
> There was a buggy (and unnecessary) reserve_bootmem call in the kdump
> call which was causing hangs during early on some SMP machines. The
> attached patch removes that.
>
> Kindly include this patch into the -mm tree.
>
> Thanks and Regards, Hari
>
>
> ------------------------------------------------------------------------
>
>
>
> Signed-off-by: Hariprasad Nellitheertha <hari@in.ibm.com>
> ---
>
> linux-2.6.10-rc2-hari/include/asm-i386/crash_dump.h | 1 -
> 1 files changed, 1 deletion(-)
>
> diff -puN include/asm-i386/crash_dump.h~kdump-reserve-bootmem-fix include/asm-i386/crash_dump.h
> --- linux-2.6.10-rc2/include/asm-i386/crash_dump.h~kdump-reserve-bootmem-fix 2004-11-18 19:20:47.000000000 +0530
> +++ linux-2.6.10-rc2-hari/include/asm-i386/crash_dump.h 2004-11-18 19:21:03.000000000 +0530
> @@ -37,7 +37,6 @@ static inline void set_saved_max_pfn(voi
> static inline void crash_reserve_bootmem(void)
> {
> if (!dump_enabled) {
> - reserve_bootmem(0, CRASH_RELOCATE_SIZE);
> reserve_bootmem(CRASH_BACKUP_BASE,
> CRASH_BACKUP_SIZE + CRASH_RELOCATE_SIZE + PAGE_SIZE);
> }
> _
next prev parent reply other threads:[~2004-11-18 15:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-18 14:08 [PATCH] kdump: Fix for boot problems on SMP Hariprasad Nellitheertha
2004-11-18 15:34 ` Badari Pulavarty [this message]
2004-11-19 17:56 ` Akinobu Mita
2004-11-19 23:30 ` Andrew Morton
2004-11-19 23:29 ` Badari Pulavarty
2004-11-20 1:05 ` Badari Pulavarty
2004-11-20 3:04 ` Akinobu Mita
2004-11-22 16:03 ` Hariprasad Nellitheertha
2004-11-22 22:34 ` Badari Pulavarty
2004-11-23 0:43 ` Badari Pulavarty
2004-11-23 18:15 ` Hariprasad Nellitheertha
2004-11-24 20:07 ` Badari Pulavarty
2004-11-25 15:13 ` Hariprasad Nellitheertha
2004-11-25 17:21 ` Akinobu Mita
2004-11-26 11:57 ` Hariprasad Nellitheertha
2004-11-20 3:46 ` Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=419CC11D.7040303@us.ibm.com \
--to=pbadari@us.ibm.com \
--cc=akpm@osdl.org \
--cc=hari@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=varap@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).