From: Ian Abbott <abbotti@mev.co.uk>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: linux-kernel@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>,
Russell King <rmk+lkml@arm.linux.org.uk>
Subject: Re: [PATCH 2.4] serial closing_wait and close_delay
Date: Thu, 16 Dec 2004 13:17:37 +0000 [thread overview]
Message-ID: <41C18AF1.30009@mev.co.uk> (raw)
In-Reply-To: <20041213115640.GI24597@logos.cnet>
On 13/12/04 11:56, Marcelo Tosatti wrote:
> On Tue, Nov 30, 2004 at 07:06:02PM +0000, Ian Abbott wrote:
>>* In several drivers, the closing_wait and close_delay values are
>>written to a struct serial_state by TIOCSSERIAL, but the values used in
>>the close routine are read from a struct async_struct, with no code to
>>transfer of values between the two structures. My patch ignores the
>>members in struct async_struct and uses the values from struct serial_state.
>
>
> Can you please split this part of the patch? (and send as a separate patch
> to me CC Alan and Russell).
Okay, I'm about to send that. By the way, while going through my
original patch, I noticed that one of its changes to drivers/char/moxa.c
was incorrect. Line 671 of the original used a fixed 30 second timeout.
My change replaced that to use closing_wait but I got the name of the
variable wrong; it should have been 'ch', not 'info'. My split-off
patch doesn't change moxa.c.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
prev parent reply other threads:[~2004-12-16 13:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-30 19:06 [PATCH 2.4] serial closing_wait and close_delay Ian Abbott
2004-11-30 18:57 ` Alan Cox
2004-12-01 9:32 ` Ian Abbott
2004-12-01 10:48 ` Russell King
2004-12-13 11:56 ` Marcelo Tosatti
2004-12-16 13:17 ` Ian Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41C18AF1.30009@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).