From: Con Kolivas <kernel@kolivas.org>
To: Li Shaohua <shaohua.li@intel.com>
Cc: Pavel Machek <pavel@ucw.cz>,
ACPI mailing list <acpi-devel@lists.sourceforge.net>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [ACPI] ACPI using smp_processor_id in preemptible code
Date: Tue, 11 Jan 2005 12:24:28 +1100 [thread overview]
Message-ID: <41E32ACC.8010103@kolivas.org> (raw)
In-Reply-To: <1105405464.18834.4.camel@sli10-desk.sh.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1184 bytes --]
Li Shaohua wrote:
> On Mon, 2005-01-10 at 17:55, Pavel Machek wrote:
>
>>>>I enabled CPU hotplug and preemptible debugging... now I get...
>>>>
>>>>BUG: using smp_processor_id() in preemptible [00000001] code:
>>>>swapper/0
>>>>caller is acpi_processor_idle+0xb/0x235
>>>>[<c020ba28>] smp_processor_id+0xa8/0xc0
>>>>[<c02338ce>] acpi_processor_idle+0xb/0x235
>>>>[<c02338c3>] acpi_processor_idle+0x0/0x235
>>>>[<c02338ce>] acpi_processor_idle+0xb/0x235
>>>>[<c02338c3>] acpi_processor_idle+0x0/0x235
>>>>[<c02338c3>] acpi_processor_idle+0x0/0x235
>>>>[<c02338c3>] acpi_processor_idle+0x0/0x235
>>>>[<c0101115>] cpu_idle+0x75/0x110
>>>>[<c04f5988>] start_kernel+0x158/0x180
>>>>[<c04f5390>] unknown_bootoption+0x0/0x1e0
>>>
>>>It doesn't trouble to me. It's in idle thread.
>>
>>You mean it does not happen to you? On my machine it fills logs very
>>quickly...
>
> What I mean is idle thread can't be migrated so this doesn't impact the
> correctness. I guess the preemptible debugging can't recognise such
> situation.
This patch should help. If it's safe to use smp_processor_id() in
acpi_processor_idle use the alternative call.
Signed-off-by: Con Kolivas <kernel@kolivas.org>
[-- Attachment #2: fix_acpi_smp_processor_id.diff --]
[-- Type: text/x-patch, Size: 471 bytes --]
Index: linux-2.6.10-mm2/drivers/acpi/processor_idle.c
===================================================================
--- linux-2.6.10-mm2.orig/drivers/acpi/processor_idle.c 2005-01-11 12:20:31.399070008 +1100
+++ linux-2.6.10-mm2/drivers/acpi/processor_idle.c 2005-01-11 12:22:19.931570560 +1100
@@ -162,7 +162,7 @@
int sleep_ticks = 0;
u32 t1, t2 = 0;
- pr = processors[smp_processor_id()];
+ pr = processors[_smp_processor_id()];
if (!pr)
return;
next prev parent reply other threads:[~2005-01-11 1:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-10 1:24 [ACPI] ACPI using smp_processor_id in preemptible code Li, Shaohua
2005-01-10 9:55 ` Pavel Machek
2005-01-11 1:04 ` Li Shaohua
2005-01-11 1:24 ` Con Kolivas [this message]
2005-01-11 2:09 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41E32ACC.8010103@kolivas.org \
--to=kernel@kolivas.org \
--cc=acpi-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).