From: Oleg Nesterov <oleg@tv-sign.ru>
To: Ram <linuxram@us.ibm.com>
Cc: linux-kernel@vger.kernel.org,
Steven Pratt <slpratt@austin.ibm.com>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 2/4] page_cache_readahead: remove duplicated code
Date: Wed, 26 Jan 2005 15:02:55 +0300 [thread overview]
Message-ID: <41F786EF.9FE19AEC@tv-sign.ru> (raw)
In-Reply-To: 1106698119.3298.57.camel@localhost
Ram wrote:
>
> No. There is a reason why we had some duplication. With your patch,
> we will end up reading-on-demand instead of reading ahead.
>
> When we notice a sequential reads have resumed, we first read in the
> data that is requested.
> However if the read request is for more pages than what are being held
> in the current window, we make the ahead window as the current window
> and read in more pages in the ahead window. Doing that gives the
> opportunity of always having pages in the ahead window when the next
> sequential read request comes in.
Yes, sorry. I have not noticed that this 'goto out' is conditional in
the 'no ahead window' case.
Thank you for explanation.
However, I still think it makes sense to factor out the common code in
these two cases, just for readability.
I'll redo these patches.
Oleg.
next prev parent reply other threads:[~2005-01-26 10:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-25 11:59 [PATCH 2/4] page_cache_readahead: remove duplicated code Oleg Nesterov
2005-01-25 21:46 ` Steven Pratt
2005-01-26 0:08 ` Ram
2005-01-26 0:16 ` Steven Pratt
2005-01-26 12:02 ` Oleg Nesterov [this message]
2005-01-28 20:13 ` Ram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41F786EF.9FE19AEC@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxram@us.ibm.com \
--cc=slpratt@austin.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).