From: Pierre Ossman <drzeus-list@drzeus.cx>
To: Christoph Hellwig <hch@infradead.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
LKML <linux-kernel@vger.kernel.org>,
wbsd-devel@list.drzeus.cx
Subject: Re: [Wbsd-devel] [PATCH 540] MMC_WBSD depends on ISA
Date: Sat, 29 Jan 2005 17:27:46 +0100 [thread overview]
Message-ID: <41FBB982.10608@drzeus.cx> (raw)
In-Reply-To: <20050129161325.GA1834@infradead.org>
Christoph Hellwig wrote:
>On Sat, Jan 29, 2005 at 05:08:32PM +0100, Pierre Ossman wrote:
>
>
>>For i386 and x86_64 it's defined as virt_to_phys in asm/io.h without any
>>#ifdef:s protecting it.
>>
>>
>
>Not all the world is a PC
>
>
>
Then the dependency should in that case be on architectures. It is
connected similar to a floppy (which is not dependent on ISA and uses
isa_virt_to_bus).
The point is that isa_virt_to_bus() is the method used by devices
connected in the same way. This works on the platforms where the device
can be found (i386 and x86_64). We can not make it dependent on ISA
since you cannot enable ISA on all platforms where it exists (i.e.
x86_64). Either fix that or make the driver depend on architecture the
same way floppy does.
Using the generic DMA API might be a viable option now that x86_64 seems
to be fixed. But it doesn't have a good track record so I'm not prepared
to commit any changes until I have time to properly test it. There might
still be assumptions about PCI lurking around.
Rgds
Pierre
next prev parent reply other threads:[~2005-01-29 16:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-07 22:50 [PATCH 540] MMC_WBSD depends on ISA Geert Uytterhoeven
2005-01-10 7:14 ` [Wbsd-devel] " Pierre Ossman
2005-01-29 13:37 ` Pierre Ossman
2005-01-29 13:57 ` Christoph Hellwig
2005-01-29 14:54 ` Russell King
2005-01-29 15:00 ` Christoph Hellwig
2005-01-29 15:13 ` Russell King
2005-01-29 15:16 ` Christoph Hellwig
2005-01-29 15:31 ` Pierre Ossman
2005-01-29 15:57 ` Christoph Hellwig
2005-01-29 16:08 ` Pierre Ossman
2005-01-29 16:13 ` Christoph Hellwig
2005-01-29 16:27 ` Pierre Ossman [this message]
2005-01-30 9:37 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41FBB982.10608@drzeus.cx \
--to=drzeus-list@drzeus.cx \
--cc=geert@linux-m68k.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wbsd-devel@list.drzeus.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).