From: Taeung Song <treeze.taeung@gmail.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Markus Trippelsdorf <markus@trippelsdorf.de>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@kernel.org>
Subject: Re: Scrolling down broken with "perf top --hierarchy"
Date: Thu, 27 Oct 2016 09:45:44 +0900 [thread overview]
Message-ID: <41b3567a-1157-b409-e64a-674174a0a345@gmail.com> (raw)
In-Reply-To: <20161024163749.GA17995@danjae.aot.lge.com>
Sorry for late reply, Namhyung
On 10/25/2016 01:37 AM, Namhyung Kim wrote:
> Hi Taeung,
>
> On Mon, Oct 24, 2016 at 07:10:24PM +0900, Taeung Song wrote:
>> Hi, Namhyung and Arnaldo :)
>>
>> On 10/24/2016 02:11 PM, Namhyung Kim wrote:
>>> Hi Arnaldo,
>>>
>>> Sorry for late reply.
>>>
>>> On Fri, Oct 07, 2016 at 11:35:45AM -0300, Arnaldo Carvalho de Melo wrote:
>>>> Em Fri, Oct 07, 2016 at 01:53:57PM +0900, Namhyung Kim escreveu:
>>>>> Cc-ing perf maintainers,
>>>>>
>>>>> On Fri, Oct 07, 2016 at 06:32:29AM +0200, Markus Trippelsdorf wrote:
>>>>>> On 2016.10.07 at 13:22 +0900, Namhyung Kim wrote:
>>>>>>> On Fri, Oct 07, 2016 at 05:51:18AM +0200, Markus Trippelsdorf wrote:
>>>>>>>> On 2016.10.07 at 10:17 +0900, Namhyung Kim wrote:
>>>>>>>>> On Thu, Oct 06, 2016 at 06:33:33PM +0200, Markus Trippelsdorf wrote:
>>>>>>>>>> Scrolling down is broken when using "perf top --hierarchy".
>>>>>>>>>> When it starts up everything is OK and one can scroll up and down to all
>>>>>>>>>> entries. But as further and further new entries get added to the list,
>>>>>>>>>> scrolling down is blocked (at the position of the last entry that was
>>>>>>>>>> shown directly after startup).
>>>>>>>>>
>>>>>>>>> I think below patch will fix the problem. Please check.
>>>>>>>>
>>>>>>>> Yes. It works fine now. Many thanks.
>>>>>>>
>>>>>>> Good. Can I add your Tested-by then?
>>>>>>
>>>>>> Sure.
>>>>>
>>>>> Ok, I'll send a formal patch with it.
>>>>>
>>>>>>
>>>>>> (And in the long run you should think of making "perf top --hierarchy"
>>>>>> the default for perf top, because it gives a much better (uncluttered)
>>>>>> overview of what is going on.)
>>>>>
>>>>> I think it's a matter of taste. Some people prefer to see the top
>>>>> single function or something (i.e. current behavior) while others
>>>>> prefer to see a higher-level view.
>>>>>
>>>>> But we can think again about the default at least for perf-top. I
>>>>> worried about changing default behavior because last time we did it
>>>>> for children mode many people complained about it. But I do think the
>>>>> hierarchy mode is useful for many people though.
>>>>
>>>> So, I think in such cases we could experiment with asking the user about
>>>> switching to the new mode by showing a popup message telling what it is
>>>> about, if the user says "yes, I want to try it" switch to it and if
>>>> another hotkey is pressed later, write what was chosen (yes, switch to
>>>> this new mode, no, I don't like it, don't pester me about it anymore) to
>>>> its ~/.perfconfig file so that next time it goes straight to this new
>>>> mode, else don't ask the user again and keep using whatever mode was
>>>> there already.
>>>>
>>>> What do you think?
>>>
>>> I think it's a flexible way to set the default behavior while it seems
>>> like a little bit complicated for implementation. Also I think it's
>>> better to popup another dialog at the end and asks for comfirmation
>>> (but it might not be appropriate for --stdio).
>>>
>>> And to do that, we need to have a (programmable) way of dealing with
>>> the configs.
>>>
>>> Taeung, is there an update on your config patchset (especially for
>>> write support)?
>>>
>>
>> Is related this link with what you said ?
>> https://lkml.org/lkml/2016/1/11/495
>
> Yep, that kind of thing.
>
>>
>> Yes, the config patchset would be need to be updated.
>> Because the config patchset which has 'write' feature
>> don't use a recent 'struct perf_config_set' so I should change it
>> to use 'perf_config_set' like show_config() of builtin-config.c:36.
>>
>> Do you need write support of perf-config command ?
>> If this feature is more necessary than a recent patchset about default
>> config array https://lkml.org/lkml/2016/9/5/17,
>> I'd remake config patchset for getting and setting features first. :)
>
> What I need is a way to add a config item with specific value. Maybe
> I can just append a line into a config file, but it needs to check
> possible conflict somehow. So I think it needs to process existing
> config items properly and update with the new value.
>
I got it. Understood what you said!
I'll send a patchset for this. :)
Thanks,
Taeung
next prev parent reply other threads:[~2016-10-27 0:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 16:33 Scrolling down broken with "perf top --hierarchy" Markus Trippelsdorf
2016-10-07 1:17 ` Namhyung Kim
2016-10-07 3:51 ` Markus Trippelsdorf
2016-10-07 4:22 ` Namhyung Kim
2016-10-07 4:32 ` Markus Trippelsdorf
2016-10-07 4:53 ` Namhyung Kim
2016-10-07 14:35 ` Arnaldo Carvalho de Melo
2016-10-24 5:11 ` Namhyung Kim
2016-10-24 10:10 ` Taeung Song
2016-10-24 16:37 ` Namhyung Kim
2016-10-27 0:45 ` Taeung Song [this message]
2016-10-07 4:56 ` Markus Trippelsdorf
2016-10-07 5:09 ` Markus Trippelsdorf
2016-10-08 11:21 ` Markus Trippelsdorf
2016-10-10 17:54 ` Markus Trippelsdorf
2016-10-24 4:55 ` Namhyung Kim
2016-10-24 5:53 ` Markus Trippelsdorf
2016-10-24 6:02 ` Namhyung Kim
2016-10-24 6:04 ` Markus Trippelsdorf
2016-10-24 6:14 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41b3567a-1157-b409-e64a-674174a0a345@gmail.com \
--to=treeze.taeung@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).