From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751031AbeAOVEb convert rfc822-to-8bit (ORCPT + 1 other); Mon, 15 Jan 2018 16:04:31 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:37362 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750876AbeAOVE3 (ORCPT ); Mon, 15 Jan 2018 16:04:29 -0500 From: Loic PALLARDY To: Bjorn Andersson CC: "ohad@wizery.com" , "linux-remoteproc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Arnaud POULIQUEN , "benjamin.gaignard@linaro.org" Subject: RE: [PATCH v2 15/16] remoteproc: st: associate memory device to memory regions Thread-Topic: [PATCH v2 15/16] remoteproc: st: associate memory device to memory regions Thread-Index: AQHTafrkhUEic5TG00Oe219gQ6m/+6NCVomAgDNdGhA= Date: Mon, 15 Jan 2018 21:04:26 +0000 Message-ID: <41c42a3c54ec45c4bccac6f5500b4697@SFHDAG7NODE2.st.com> References: <1512060411-729-1-git-send-email-loic.pallardy@st.com> <1512060411-729-16-git-send-email-loic.pallardy@st.com> <20171214053729.GP17344@builder> In-Reply-To: <20171214053729.GP17344@builder> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.45] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-15_09:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: > -----Original Message----- > From: Bjorn Andersson [mailto:bjorn.andersson@linaro.org] > Sent: Thursday, December 14, 2017 6:37 AM > To: Loic PALLARDY > Cc: ohad@wizery.com; linux-remoteproc@vger.kernel.org; linux- > kernel@vger.kernel.org; Arnaud POULIQUEN ; > benjamin.gaignard@linaro.org > Subject: Re: [PATCH v2 15/16] remoteproc: st: associate memory device to > memory regions > > On Thu 30 Nov 08:46 PST 2017, Loic Pallardy wrote: > > > Enable memory device creation for each memory region added > > by rproc_add_carveout function. > > > > Signed-off-by: Loic Pallardy > > --- > > drivers/remoteproc/st_remoteproc.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/remoteproc/st_remoteproc.c > b/drivers/remoteproc/st_remoteproc.c > > index da42ec9..bf83d82 100644 > > --- a/drivers/remoteproc/st_remoteproc.c > > +++ b/drivers/remoteproc/st_remoteproc.c > > @@ -279,6 +279,7 @@ static int st_rproc_parse_dt(struct platform_device > *pdev) > > mem->dma = res.start; > > mem->da = res.start; > > mem->len = resource_size(&res); > > + strncpy(mem->name, node->name, sizeof(mem->name)); > > Please add this to the previous patch. As indicated in cover letter, I'll some patches to have a coherent series. /Loic > > > mem->va = devm_ioremap_wc(dev, mem->dma, mem- > >len); > > if (!mem->va) { > > dev_err(dev, "Unable to map memory region: > %pa+%zx\n", > > @@ -286,7 +287,7 @@ static int st_rproc_parse_dt(struct platform_device > *pdev) > > return -EBUSY; > > } > > > > - rproc_add_carveout(rproc, mem, false); > > + rproc_add_carveout(rproc, mem, true); > > Here you can see how easy it is to accidentally double-map the memory > region. > > Regards, > Bjorn