linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Dadap <ddadap@nvidia.com>
To: Joe Perches <joe@perches.com>, <apw@canonical.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] checkpatch: improve MAINTAINERS file update test
Date: Mon, 27 Jul 2020 17:02:05 -0500	[thread overview]
Message-ID: <41c8d9a1-cc4d-7ff0-c269-3f631b7d4a78@nvidia.com> (raw)
In-Reply-To: <0801ef9d2489ed816ec97ee3054de2d20bfac14c.camel@perches.com>


On 7/27/20 4:07 PM, Joe Perches wrote:
> External email: Use caution opening links or attachments
>
>
> On Mon, 2020-07-27 at 15:58 -0500, Daniel Dadap wrote:
>> Add an additional regular expression to detect updates to the
>> MAINTAINERS file as reported in the unified diffs generated by
>> `git format-patch`. This suppresses the "does MAINTAINERS need
>> updating" message when MAINTAINERS is updated with this format.
> Please cc at least LKML.


Oops; thanks for adding the list. I'll be sure to include it for any 
revised patches.


>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
>> @@ -2621,7 +2621,8 @@ sub process {
>>
>>   # Check if MAINTAINERS is being updated.  If so, there's probably no need to
>>   # emit the "does MAINTAINERS need updating?" message on file add/move/delete
>> -             if ($line =~ /^\s*MAINTAINERS\s*\|/) {
>> +             if ($line =~ /^\s*MAINTAINERS\s*\|/ ||
>> +                 $line =~ /^[-+]{3} [ab]\/MAINTAINERS$/) {
> I don't believe this works well as any test
> for a file modification to MAINTAINERS occurs
> after the block that would show a diffstat
> where the warning is emitted.


Hmm. It must have worked for me because the MAINTAINERS file appeared 
earlier in the patch than a newly added file in a patch I was checking 
that triggers this warning before this change, but doesn't after this 
change. This needn't be the case, though. Would it make sense to move 
the check for a diffstat-style /^\sMAINTAINERS\s*\|/ as well as a 
unidiff-style /^[-+]{3} [ab]\/MAINTAINERS$/ to the pre-scan sanitize phase?


      reply	other threads:[~2020-07-27 22:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200727205856.28343-1-ddadap@nvidia.com>
2020-07-27 21:07 ` [PATCH] checkpatch: improve MAINTAINERS file update test Joe Perches
2020-07-27 22:02   ` Daniel Dadap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41c8d9a1-cc4d-7ff0-c269-3f631b7d4a78@nvidia.com \
    --to=ddadap@nvidia.com \
    --cc=apw@canonical.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).