linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Johan Hovold <johan+linaro@kernel.org>,
	freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-phy@lists.infradead.org, linux-arm-msm@vger.kernel.org,
	kernel-janitors@vger.kernel.org,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Vinod Koul <vkoul@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Kuogee Hsieh <quic_khsieh@quicinc.com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Rob Clark <robdclark@gmail.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH 3/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free
Date: Tue, 20 Feb 2024 09:25:44 +0100	[thread overview]
Message-ID: <41ca529d-ad0c-40e7-b68c-c90297815bbc@web.de> (raw)
In-Reply-To: <20240217150228.5788-4-johan+linaro@kernel.org>

…
> Specifically, the dp-hpd bridge is currently registered before all
> resources have been acquired which means that it can also be
> deregistered on probe deferrals.
>
> In the meantime there is a race window where the new aux bridge driver
> (or PHY driver previously) may have looked up the dp-hpd bridge and
> stored a (non-reference-counted) pointer to the bridge which is about to
> be deallocated.
…

I got the impression that the change description can be improved another bit.

1. Will any additional imperative wordings become helpful?
   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.8-rc5#n94> +++ b/drivers/soc/qcom/pmic_glink_altmode.c
> @@ -76,7 +76,7 @@ struct pmic_glink_altmode_port {
>
>  	struct work_struct work;
>
> -	struct device *bridge;
> +	struct auxiliary_device *bridge;
>
>  	enum typec_orientation orientation;
>  	u16 svid;
…

2. How do you think about to stress such a data type adjustment?

Regards,
Markus

  reply	other threads:[~2024-02-20  8:26 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-17 15:02 [PATCH 0/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free Johan Hovold
2024-02-17 15:02 ` [PATCH 1/6] drm/bridge: aux-hpd: fix OF node leaks Johan Hovold
2024-02-19 17:48   ` Markus Elfring
2024-02-20  7:24     ` Johan Hovold
2024-02-20 11:52       ` Julia Lawall
2024-02-20 11:55         ` Dmitry Baryshkov
2024-02-20 12:56           ` Julia Lawall
2024-02-20 13:35             ` Dmitry Baryshkov
2024-02-22  1:22   ` Bjorn Andersson
2024-02-22 21:00   ` Dmitry Baryshkov
2024-02-23 10:56   ` Neil Armstrong
2024-02-23 10:56   ` Neil Armstrong
2024-02-17 15:02 ` [PATCH 2/6] drm/bridge: aux-hpd: separate allocation and registration Johan Hovold
2024-02-22  2:06   ` Bjorn Andersson
2024-02-22 16:06     ` Johan Hovold
2024-02-22 20:57   ` Dmitry Baryshkov
2024-02-23 12:46     ` Johan Hovold
2024-02-17 15:02 ` [PATCH 3/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free Johan Hovold
2024-02-20  8:25   ` Markus Elfring [this message]
2024-02-20 10:55   ` Markus Elfring
2024-02-20 11:26     ` Johan Hovold
2024-02-20 12:40       ` [3/6] " Markus Elfring
2024-02-22  2:11   ` [PATCH 3/6] " Bjorn Andersson
2024-02-22 21:10   ` Dmitry Baryshkov
2024-02-17 15:02 ` [PATCH 4/6] soc: qcom: pmic_glink: Fix boot when QRTR=m Johan Hovold
2024-02-22  2:18   ` Bjorn Andersson
2024-02-22 21:10   ` Dmitry Baryshkov
2024-02-23 11:04   ` Neil Armstrong
2024-02-17 15:02 ` [PATCH 5/6] phy: qcom-qmp-combo: fix drm bridge registration Johan Hovold
2024-02-19  9:03   ` Neil Armstrong
2024-02-22  2:21   ` Bjorn Andersson
2024-02-22 21:11   ` Dmitry Baryshkov
2024-02-23 12:09   ` Vinod Koul
2024-02-17 15:02 ` [PATCH 6/6] phy: qcom-qmp-combo: fix type-c switch registration Johan Hovold
2024-02-22  2:23   ` Bjorn Andersson
2024-02-22 21:12   ` Dmitry Baryshkov
2024-02-23 12:10   ` Vinod Koul
2024-02-23 11:02 ` [PATCH 0/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free Neil Armstrong
2024-02-23 11:03   ` Neil Armstrong
2024-02-23 12:51     ` Johan Hovold
2024-02-23 13:52       ` Neil Armstrong
2024-02-23 14:18         ` Dmitry Baryshkov
2024-02-23 14:28           ` Johan Hovold
2024-02-23 14:21         ` Johan Hovold
2024-02-23 14:38           ` Neil Armstrong
2024-02-23 14:52             ` Johan Hovold
2024-02-23 14:55               ` Neil Armstrong
2024-02-23 15:07                 ` Dmitry Baryshkov
2024-02-23 14:54 ` Neil Armstrong
2024-02-23 15:06 ` (subset) " Dmitry Baryshkov
2024-03-06 17:47 ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41ca529d-ad0c-40e7-b68c-c90297815bbc@web.de \
    --to=markus.elfring@web.de \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=andersson@kernel.org \
    --cc=andrzej.hajda@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=johan+linaro@kernel.org \
    --cc=jonas@kwiboo.se \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kishon@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_khsieh@quicinc.com \
    --cc=rfoss@kernel.org \
    --cc=robdclark@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=tzimmermann@suse.de \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).