From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1033141AbdAEIUr (ORCPT <rfc822;w@1wt.eu>);
        Thu, 5 Jan 2017 03:20:47 -0500
Received: from mail-pg0-f53.google.com ([74.125.83.53]:35802 "EHLO
        mail-pg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1033128AbdAEIUX (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 5 Jan 2017 03:20:23 -0500
Subject: Re: [PATCH v6 08/14] ACPI: ARM64: IORT: rework iort_node_get_id()
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
References: <1483363905-2806-1-git-send-email-hanjun.guo@linaro.org>
 <1483363905-2806-9-git-send-email-hanjun.guo@linaro.org>
 <20170104175822.GD8604@red-moon>
Cc: Marc Zyngier <marc.zyngier@arm.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>, linux-acpi@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linuxarm@huawei.com, Thomas Gleixner <tglx@linutronix.de>,
        Greg KH <gregkh@linuxfoundation.org>, Tomasz Nowicki <tn@semihalf.com>,
        Ma Jun <majun258@huawei.com>, Kefeng Wang <wangkefeng.wang@huawei.com>,
        Agustin Vega-Frias <agustinv@codeaurora.org>,
        Sinan Kaya <okaya@codeaurora.org>, charles.garcia-tobin@arm.com,
        huxinwei@huawei.com, yimin@huawei.com, Jon Masters <jcm@redhat.com>
From: Hanjun Guo <hanjun.guo@linaro.org>
Message-ID: <41ea75c7-e371-a9a6-6143-af34c42ab59e@linaro.org>
Date: Thu, 5 Jan 2017 16:19:58 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <20170104175822.GD8604@red-moon>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Lorenzo,

On 2017/1/5 1:58, Lorenzo Pieralisi wrote:
> On Mon, Jan 02, 2017 at 09:31:39PM +0800, Hanjun Guo wrote:
>> iort_node_get_id() has two output, one is the mapped ids,
>> the other is the referenced parent node which is returned
>> from the function.
>>
>> For now we need a API just return its parent node for
>> single mapping, so just update this function slightly then
>> reuse it later.
>
> I think we need to fix iort_node_get_id() first though, I am referring
> to the index usage in relation to acpi_iort_id_mapping.output_reference
> and related parent pointer retrieval as you reported to me, I am happy
> to send it upstream independently.

Sure, please.

>
> As for this patch it is ok even though we can create an API that
> just retrieve a node parent without fiddling about with passing
> a NULL pointer for the id_out to achieve the same.

Since you commented "[PATCH v6 05/14] ACPI: platform-msi: retrieve dev
id from IORT" which also refer to this API, I will reply in that
email.

Thanks
Hanjun