From: Vlastimil Babka <vbabka@suse.cz>
To: Rashmica Gupta <rashmica.g@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: toshi.kani@hpe.com, tglx@linutronix.de, bp@suse.de,
brijesh.singh@amd.com, thomas.lendacky@amd.com,
jglisse@redhat.com, gregkh@linuxfoundation.org,
baiyaowei@cmss.chinamobile.com, dan.j.williams@intel.com,
mhocko@suse.com, iamjoonsoo.kim@lge.com, malat@debian.org,
Bjorn Helgaas <bhelgaas@google.com>,
osalvador@techadventures.net, yasu.isimatu@gmail.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Mike Rapoport <rppt@linux.vnet.ibm.com>
Subject: Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory
Date: Fri, 10 Aug 2018 10:28:26 +0200 [thread overview]
Message-ID: <41eb4fc8-3b57-478b-05b4-88bed24ed66e@suse.cz> (raw)
In-Reply-To: <CAC6rBs=yYYZw-c02yp6rx-+TN2oUGgrp=uuLhZ=Kc_nnjmTRqA@mail.gmail.com>
On 08/10/2018 08:55 AM, Rashmica Gupta wrote:
> On Fri, Aug 10, 2018 at 11:12 AM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
>>
>> What is the end-user impact of this patch?
>>
>
> Only architectures/setups that allow the user to remove and add memory of
> different sizes or different start addresses from the kernel at runtime will
> potentially encounter the resource fragmentation.
>
> Trying to remove memory that overlaps iomem resources the first time
> gives us this warning: "Unable to release resource <%pa-%pa>".
>
> Attempting a second time results in a kernel oops (on ppc at least).
An oops? I think that should be investigated and fixed, even if resource
merging prevents it. Do you have the details?
Thanks,
Vlastimil
next prev parent reply other threads:[~2018-08-10 8:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 2:54 [PATCH v3] resource: Merge resources on a node when hot-adding memory Rashmica Gupta
2018-08-09 14:30 ` Vlastimil Babka
2018-08-09 15:03 ` Mike Rapoport
2018-08-10 1:12 ` Andrew Morton
2018-08-10 6:55 ` Rashmica Gupta
2018-08-10 8:28 ` Vlastimil Babka [this message]
2018-08-10 13:00 ` Michal Hocko
2018-08-10 14:25 ` Rashmica Gupta
2018-08-10 19:32 ` Oscar Salvador
2018-08-10 12:26 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41eb4fc8-3b57-478b-05b4-88bed24ed66e@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=baiyaowei@cmss.chinamobile.com \
--cc=bhelgaas@google.com \
--cc=bp@suse.de \
--cc=brijesh.singh@amd.com \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=malat@debian.org \
--cc=mhocko@suse.com \
--cc=osalvador@techadventures.net \
--cc=rashmica.g@gmail.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=toshi.kani@hpe.com \
--cc=yasu.isimatu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).