From: Bagas Sanjaya <bagasdotme@gmail.com>
To: David Gow <davidgow@google.com>
Cc: "open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
KUnit Development <kunit-dev@googlegroups.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Brendan Higgins <brendan.higgins@linux.dev>,
Jonathan Corbet <corbet@lwn.net>,
Khalid Masum <khalid.masum.92@gmail.com>,
Sadiya Kazi <sadiyakazi@google.com>
Subject: Re: [PATCH v2] Documentation: kunit: rewrite writing first test instructions
Date: Sat, 1 Oct 2022 10:07:47 +0700 [thread overview]
Message-ID: <41fe0989-9157-944d-c796-21e28c8265b9@gmail.com> (raw)
In-Reply-To: <CABVgOSko6kgA_T3LNgTPxQZS8Ab8E+XhMcOGHFx76nd2HN_RBg@mail.gmail.com>
On 9/30/22 17:32, David Gow wrote:
>>
>> The indentation for code-block directive is required, since the preceding
>> paragraph is multiline; otherwise there will be Sphinx warnings.
>>
>
> I don't see any such warnings on my machine (which claims to have
> sphinx-build 4.5.0).
>
> Could you send an example warning, and your sphinx version to me so I
> can try to reproduce it.
>
> Regardless, if it's causing warnings, keep these changes. (Though it'd
> be nice to include the warnings in the commit message, so it's obvious
> that these are being re-aligned for a reason.)
>
I'm using Sphinx 2.4.4 (as installed from pip through
Documentation/sphinx/requirements.txt).
Sorry I can't reproduce the warning I mentioned earlier (I forget
the recipe that triggers it when writing the improv).
In any case, I'd like to keep code block aligning in the separate patch.
It would be nice to see code blocks aligned to the instructions list.
--
An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2022-10-01 3:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 13:25 [PATCH v2] Documentation: kunit: rewrite writing first test instructions Bagas Sanjaya
2022-09-30 6:42 ` David Gow
2022-09-30 9:51 ` Bagas Sanjaya
2022-09-30 10:32 ` David Gow
2022-10-01 3:07 ` Bagas Sanjaya [this message]
2022-10-01 6:51 ` David Gow
[not found] ` <CAO2JNKUqkt3p1OcRt9tSa9T=sv8RG+F3LydZfTdVBc0WewhHVg@mail.gmail.com>
2022-10-07 3:03 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41fe0989-9157-944d-c796-21e28c8265b9@gmail.com \
--to=bagasdotme@gmail.com \
--cc=brendan.higgins@linux.dev \
--cc=corbet@lwn.net \
--cc=davidgow@google.com \
--cc=khalid.masum.92@gmail.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=sadiyakazi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).