From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Jisheng Zhang <jszhang@marvell.com>,
will.deacon@arm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: mm: only initialize swiotlb when necessary
Date: Tue, 21 Jun 2016 22:13:45 +0200 [thread overview]
Message-ID: <4203245.3RUrvgiPFd@wuerfel> (raw)
In-Reply-To: <20160621160625.GE14542@e104818-lin.cambridge.arm.com>
On Tuesday, June 21, 2016 5:06:25 PM CEST Catalin Marinas wrote:
> On Wed, Jun 08, 2016 at 05:49:59PM +0200, Arnd Bergmann wrote:
> > On Wednesday, June 8, 2016 1:08:29 PM CEST Catalin Marinas wrote:
> > > On Wed, Jun 08, 2016 at 03:53:46PM +0800, Jisheng Zhang wrote:
> > > > static int __init arm64_dma_init(void)
> > > > {
> > > > + if (swiotlb_force || max_pfn > (arm64_dma_phys_limit >> PAGE_SHIFT))
> > > > + swiotlb = 1;
> > > > +
> > > > return atomic_pool_init();
> > > > }
> > >
> > > So any platform with RAM larger than 4GB would still initialise swiotlb.
> > > I wouldn't say it's an issue, 64MB is not a significant loss on such
> > > systems.
> > >
> > > An alternative would be to defer the freeing until we are aware of all
> > > possible dma masks for the populated devices (e.g. from DT), though I'm
> > > not sure that's enough, drivers may try to change such masks when
> > > probed.
> >
> > Right, this is a hard problem, because you can in theory have odd devices
> > that require a DMA mask lower than the limit of ZONE_DMA.
>
> I'm not sure what we can do about such devices even with swiotlb. The
> bounce buffer is allocated from ZONE_DMA and currently it assumes a
> 32-bit mask from the start of RAM, so it is not guaranteed to support a
> smaller mask. We may need to come up with some DT memory node attribute
> to define the minimum DMA-able memory and restrict ZONE_DMA during early
> boot but I would rather wait until we hit a real issue in practice.
The bounce buffer is allocated at early boot time in order to get an address
as low as possible, in the hope that it is small enough for those cases.
Arnd
next prev parent reply other threads:[~2016-06-21 20:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 7:53 [PATCH] arm64: mm: only initialize swiotlb when necessary Jisheng Zhang
2016-06-08 8:01 ` Jisheng Zhang
2016-06-08 12:08 ` Catalin Marinas
2016-06-08 15:49 ` Arnd Bergmann
2016-06-21 16:06 ` Catalin Marinas
2016-06-21 20:13 ` Arnd Bergmann [this message]
2016-06-22 16:56 ` Catalin Marinas
2016-06-08 12:13 ` Catalin Marinas
2016-06-12 7:14 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4203245.3RUrvgiPFd@wuerfel \
--to=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).