From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5C6EC432BE for ; Tue, 3 Aug 2021 09:01:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89E5A600CD for ; Tue, 3 Aug 2021 09:01:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234947AbhHCJBa (ORCPT ); Tue, 3 Aug 2021 05:01:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:28135 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234690AbhHCJB3 (ORCPT ); Tue, 3 Aug 2021 05:01:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627981278; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pKHXn9wnTp9qRrDvUqHWpePjL7Y3hrbra/6xW/dla90=; b=i2GmHkTtKvwab5yr2VLy8d3OzP5Yu5366PdB8wBfuniNBbF4CcJWFwIpRHdD6Pi7HLI3Lw 9QX5OAndZVmBFvEF3JeYfzatWiy57KkI7odUZ0yv+TEH+mmOmxjWYh2W2rz41rTPwXvdVx /cA5ikfkzWGKKLwbz1JAukXGJTixZME= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-445-CfReJm_aP6qSnq-HUG1FCg-1; Tue, 03 Aug 2021 05:01:14 -0400 X-MC-Unique: CfReJm_aP6qSnq-HUG1FCg-1 Received: by mail-wr1-f70.google.com with SMTP id l12-20020a5d6d8c0000b029015488313d96so1595940wrs.15 for ; Tue, 03 Aug 2021 02:01:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pKHXn9wnTp9qRrDvUqHWpePjL7Y3hrbra/6xW/dla90=; b=MAJPPv4hxRpWzCqQ6YyhxPmrgtriTrZavDmk2sKStzdsXlBYsjFOyZO+YgcVfQ6KgG VaJcWx4FSmyw1oOlVuygriGvmxzxdy0OnhB71N5C3PAYGmVMgFJdKrmZDMxm6u07XmTI pP0oPiTv6wFZe8i+Wff5vU31OxwAbqvWQ6kQoqG7qlKdawO1NHw+IaxU5WdZbD4g6tkD 34il6Q02uxBeCm5APOle5N+7jTbm8awQH/dmba6DFTrLPlqU+coj+gJMA5MLBoS10m/S NBs+qYwKU19BFW8rEnanqwMTbfB7ScizPuTeqENG/mS+/4nmYyyj6MhJgkTPaajSyOAX pK0g== X-Gm-Message-State: AOAM531UMhPKUctvn16i75zycsxAJGjLHLrO4JxbF1Z9bqd9/tSHBEgK KBPvwIC/tQMSTGEnWqIiao2j4NbS7PS1UeKIRYzweTFNKqFjhM/H4Y1U24XbdZmeu6wwRC0Ochc aIxt2eQGI7p4HMqhl9tHU3IOS X-Received: by 2002:a1c:46c4:: with SMTP id t187mr3244029wma.64.1627981273321; Tue, 03 Aug 2021 02:01:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxSMW8XDmM6IKA3v4gzcbw7RQQimpJW2BqmCZ8OTl1PXZEjUdI1YetIiIV7wNFHI9aSeYjXEg== X-Received: by 2002:a1c:46c4:: with SMTP id t187mr3244005wma.64.1627981273140; Tue, 03 Aug 2021 02:01:13 -0700 (PDT) Received: from [192.168.10.118] ([93.56.169.140]) by smtp.gmail.com with ESMTPSA id a16sm14072483wrx.7.2021.08.03.02.01.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Aug 2021 02:01:12 -0700 (PDT) Subject: Re: [PATCH v3 09/12] KVM: x86: hyper-v: Deactivate APICv only when AutoEOI feature is in use To: Maxim Levitsky , kvm@vger.kernel.org Cc: Wanpeng Li , Thomas Gleixner , Joerg Roedel , Borislav Petkov , Sean Christopherson , Jim Mattson , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Suravee Suthikulpanit , Vitaly Kuznetsov , Ingo Molnar , "H. Peter Anvin" References: <20210802183329.2309921-1-mlevitsk@redhat.com> <20210802183329.2309921-10-mlevitsk@redhat.com> From: Paolo Bonzini Message-ID: <4209384b-68f3-a0d2-24da-3b047422f114@redhat.com> Date: Tue, 3 Aug 2021 11:01:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210802183329.2309921-10-mlevitsk@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/08/21 20:33, Maxim Levitsky wrote: > From: Vitaly Kuznetsov > > APICV_INHIBIT_REASON_HYPERV is currently unconditionally forced upon > SynIC activation as SynIC's AutoEOI is incompatible with APICv/AVIC. It is, > however, possible to track whether the feature was actually used by the > guest and only inhibit APICv/AVIC when needed. > > TLFS suggests a dedicated 'HV_DEPRECATING_AEOI_RECOMMENDED' flag to let > Windows know that AutoEOI feature should be avoided. While it's up to > KVM userspace to set the flag, KVM can help a bit by exposing global > APICv/AVIC enablement. > > Maxim: > - always set HV_DEPRECATING_AEOI_RECOMMENDED in kvm_get_hv_cpuid, > since this feature can be used regardless of AVIC > > Signed-off-by: Vitaly Kuznetsov > Signed-off-by: Maxim Levitsky > --- > arch/x86/include/asm/kvm_host.h | 3 +++ > arch/x86/kvm/hyperv.c | 27 +++++++++++++++++++++------ > 2 files changed, 24 insertions(+), 6 deletions(-) > > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h > index 80323b5fb20a..55b1f79d9c43 100644 > --- a/arch/x86/include/asm/kvm_host.h > +++ b/arch/x86/include/asm/kvm_host.h > @@ -988,6 +988,9 @@ struct kvm_hv { > /* How many vCPUs have VP index != vCPU index */ > atomic_t num_mismatched_vp_indexes; > > + /* How many SynICs use 'AutoEOI' feature */ > + atomic_t synic_auto_eoi_used; > + > struct hv_partition_assist_pg *hv_pa_pg; > struct kvm_hv_syndbg hv_syndbg; > }; > diff --git a/arch/x86/kvm/hyperv.c b/arch/x86/kvm/hyperv.c > index b07592ca92f0..638f3c559623 100644 > --- a/arch/x86/kvm/hyperv.c > +++ b/arch/x86/kvm/hyperv.c > @@ -88,6 +88,10 @@ static bool synic_has_vector_auto_eoi(struct kvm_vcpu_hv_synic *synic, > static void synic_update_vector(struct kvm_vcpu_hv_synic *synic, > int vector) > { > + struct kvm_vcpu *vcpu = hv_synic_to_vcpu(synic); > + struct kvm_hv *hv = to_kvm_hv(vcpu->kvm); > + int auto_eoi_old, auto_eoi_new; > + > if (vector < HV_SYNIC_FIRST_VALID_VECTOR) > return; > > @@ -96,10 +100,25 @@ static void synic_update_vector(struct kvm_vcpu_hv_synic *synic, > else > __clear_bit(vector, synic->vec_bitmap); > > + auto_eoi_old = bitmap_weight(synic->auto_eoi_bitmap, 256); > + > if (synic_has_vector_auto_eoi(synic, vector)) > __set_bit(vector, synic->auto_eoi_bitmap); > else > __clear_bit(vector, synic->auto_eoi_bitmap); > + > + auto_eoi_new = bitmap_weight(synic->auto_eoi_bitmap, 256); > + > + /* Hyper-V SynIC auto EOI SINTs are not compatible with APICV */ > + if (!auto_eoi_old && auto_eoi_new) { > + if (atomic_inc_return(&hv->synic_auto_eoi_used) == 1) > + kvm_request_apicv_update(vcpu->kvm, false, > + APICV_INHIBIT_REASON_HYPERV); > + } else if (!auto_eoi_new && auto_eoi_old) { > + if (atomic_dec_return(&hv->synic_auto_eoi_used) == 0) > + kvm_request_apicv_update(vcpu->kvm, true, > + APICV_INHIBIT_REASON_HYPERV); > + } > } > > static int synic_set_sint(struct kvm_vcpu_hv_synic *synic, int sint, > @@ -933,12 +952,6 @@ int kvm_hv_activate_synic(struct kvm_vcpu *vcpu, bool dont_zero_synic_pages) > > synic = to_hv_synic(vcpu); > > - /* > - * Hyper-V SynIC auto EOI SINT's are > - * not compatible with APICV, so request > - * to deactivate APICV permanently. > - */ > - kvm_request_apicv_update(vcpu->kvm, false, APICV_INHIBIT_REASON_HYPERV); > synic->active = true; > synic->dont_zero_synic_pages = dont_zero_synic_pages; > synic->control = HV_SYNIC_CONTROL_ENABLE; > @@ -2466,6 +2479,8 @@ int kvm_get_hv_cpuid(struct kvm_vcpu *vcpu, struct kvm_cpuid2 *cpuid, > ent->eax |= HV_X64_ENLIGHTENED_VMCS_RECOMMENDED; > if (!cpu_smt_possible()) > ent->eax |= HV_X64_NO_NONARCH_CORESHARING; > + > + ent->eax |= HV_DEPRECATING_AEOI_RECOMMENDED; > /* > * Default number of spinlock retry attempts, matches > * HyperV 2016. > Reviewed-by: Paolo Bonzini