From: Randy Dunlap <rdunlap@infradead.org>
To: Nick Crews <ncrews@chromium.org>,
bleung@chromium.org, enric.balletbo@collabora.com
Cc: linux-kernel@vger.kernel.org, dlaurie@chromium.org, sfr@canb.auug.org.au
Subject: Re: [PATCH -next] platform/chrome: Fix Kconfig dependencies for wilco_ec
Date: Wed, 20 Feb 2019 15:09:36 -0800 [thread overview]
Message-ID: <420e6e26-6270-e577-6bbc-3ebe884168b5@infradead.org> (raw)
In-Reply-To: <20190220221128.48476-1-ncrews@chromium.org>
On 2/20/19 2:11 PM, Nick Crews wrote:
> In the initial version of the Wilco EC Driver, the
> dependency order was wrong. It before was possible to
> select CONFIG_WILCO_EC and CONFIG_CROS_EC_LPC without
> having CONFIG_CROS_EC_LPC_MEC. This was wrong, since
> WILCO_EC depends upon CONFIG CROS_EC_LPC_MEC, not the
> other way around.
>
> Fixes: 1733c32834e5d1 ("platform/chrome: Add new driver for Wilco EC")
> Signed-off-by: Nick Crews <ncrews@chromium.org>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
> ---
> drivers/platform/chrome/Kconfig | 2 +-
> drivers/platform/chrome/wilco_ec/Kconfig | 3 +--
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig
> index 462eb9dfa4f2..b69561050868 100644
> --- a/drivers/platform/chrome/Kconfig
> +++ b/drivers/platform/chrome/Kconfig
> @@ -95,7 +95,7 @@ config CROS_EC_LPC
>
> config CROS_EC_LPC_MEC
> bool "ChromeOS Embedded Controller LPC Microchip EC (MEC) variant"
> - depends on CROS_EC_LPC || WILCO_EC
> + depends on CROS_EC_LPC
> default n
> help
> If you say Y here, a variant LPC protocol for the Microchip EC
> diff --git a/drivers/platform/chrome/wilco_ec/Kconfig b/drivers/platform/chrome/wilco_ec/Kconfig
> index 20945a301ec6..c6bc4e8f3062 100644
> --- a/drivers/platform/chrome/wilco_ec/Kconfig
> +++ b/drivers/platform/chrome/wilco_ec/Kconfig
> @@ -1,7 +1,6 @@
> config WILCO_EC
> tristate "ChromeOS Wilco Embedded Controller"
> - depends on ACPI && X86
> - select CROS_EC_LPC_MEC
> + depends on ACPI && X86 && CROS_EC_LPC_MEC
> help
> If you say Y here, you get support for talking to the ChromeOS
> Wilco EC over an eSPI bus. This uses a simple byte-level protocol
>
--
~Randy
next prev parent reply other threads:[~2019-02-20 23:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 22:11 [PATCH -next] platform/chrome: Fix Kconfig dependencies for wilco_ec Nick Crews
2019-02-20 23:09 ` Randy Dunlap [this message]
2019-02-21 7:57 ` Enric Balletbo i Serra
2019-02-22 16:50 ` Randy Dunlap
2019-02-25 10:11 ` Enric Balletbo i Serra
2019-02-25 10:22 ` Cheng-yi Chiang
2019-02-25 12:23 ` Enric Balletbo i Serra
2019-02-25 13:56 ` Cheng-yi Chiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=420e6e26-6270-e577-6bbc-3ebe884168b5@infradead.org \
--to=rdunlap@infradead.org \
--cc=bleung@chromium.org \
--cc=dlaurie@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ncrews@chromium.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).