linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Witold Krecicki <adasi@kernel.pl>
Cc: linux-kernel@vger.kernel.org
Subject: Re: sil_blacklist - are all those entries necessary?
Date: Wed, 16 Feb 2005 19:59:50 -0500	[thread overview]
Message-ID: <4213EC86.9020108@pobox.com> (raw)
In-Reply-To: <200502170143.00817.adasi@kernel.pl>

Witold Krecicki wrote:
> Dnia wtorek 15 luty 2005 21:29, napisałeś:
> 
>>Dnia wtorek 15 luty 2005 17:52, napisałeś:
>>
>>>Witold Krecicki wrote:
>>>
>>>>in sata_sil.c there is:
>>>>sil_blacklist [] = {
>>>>        { "ST320012AS",         SIL_QUIRK_MOD15WRITE },
>>>>        { "ST330013AS",         SIL_QUIRK_MOD15WRITE },
>>>>        { "ST340017AS",         SIL_QUIRK_MOD15WRITE },
>>>>        { "ST360015AS",         SIL_QUIRK_MOD15WRITE },
>>>>        { "ST380023AS",         SIL_QUIRK_MOD15WRITE },
>>>>        { "ST3120023AS",        SIL_QUIRK_MOD15WRITE },
>>>>        { "ST3160023AS",        SIL_QUIRK_MOD15WRITE },
>>>>        { "ST3120026AS",        SIL_QUIRK_MOD15WRITE },
>>>>        { "ST340014ASL",        SIL_QUIRK_MOD15WRITE },
>>>>        { "ST360014ASL",        SIL_QUIRK_MOD15WRITE },
>>>>        { "ST380011ASL",        SIL_QUIRK_MOD15WRITE },
>>>>        { "ST3120022ASL",       SIL_QUIRK_MOD15WRITE },
>>>>        { "ST3160021ASL",       SIL_QUIRK_MOD15WRITE },
>>>>        { "Maxtor 4D060H3",     SIL_QUIRK_UDMA5MAX },
>>>>        { }
>>>>};
>>>>I've got ST3120026AS and I've been using it with SIL3112 without this
>>>>hack for a long time - without any negative effects. The same
>>>>impression on ST3200822AS - is there any way to check if it is REALLY
>>>>necessary? 15MB/s is not what I'd expect on SATA...
>>>
>>>It's necessary until we can prove otherwise.  Simply running well
>>>without your drive in the blacklist means nothing -- you just haven't
>>>hit the error condition yet.
>>
>>So how can I proove it? Are there any tests? It's been running for over a
>>year, almost 24/7 and nothing...
> 
> Still no response - so again:
> is there ANY way to test if this hack is necessary for specific model of a 
> disk?

You need a bus analyzer, and need to test different sizes of FIS's.  If 
all possible sizes (2048 combinations) work on your device, the 
blacklist entry is not needed.

	Jeff



  reply	other threads:[~2005-02-17  1:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-15 16:06 sil_blacklist - are all those entries necessary? Witold Krecicki
2005-02-15 16:52 ` Jeff Garzik
2005-02-15 20:29   ` Witold Krecicki
2005-02-17  0:43     ` Witold Krecicki
2005-02-17  0:59       ` Jeff Garzik [this message]
2005-02-17  1:05         ` Witold Krecicki
2005-02-17 18:45           ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4213EC86.9020108@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=adasi@kernel.pl \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).